[Bug other/55292] New: libsanitizer doesn't support x32

[Bug other/55292] New: libsanitizer doesn't support x32

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55292

             Bug #: 55292
           Summary: libsanitizer doesn't support x32
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: hjl.tools@gmail.com


sanitizer_common/sanitizer_linux.cc has

void *internal_mmap(void *addr, uptr length, int prot, int flags,
                    int fd, u64 offset) {
#if __WORDSIZE == 64
  return (void *)syscall(__NR_mmap, addr, length, prot, flags, fd, offset);
#else
  return (void *)syscall(__NR_mmap2, addr, length, prot, flags, fd, offset);
#endif
}

uptr internal_filesize(fd_t fd) {
#if __WORDSIZE == 64
  struct stat st;
  if (syscall(__NR_fstat, fd, &st))
    return -1;
#else
  struct stat64 st;
  if (syscall(__NR_fstat64, fd, &st))
    return -1;
#endif
  return (uptr)st.st_size;
}

They are incorrect for x32.

[Bug other/55292] libsanitizer doesn't support x32

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55292

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

[Bug other/55292] libsanitizer doesn't support x32

[hjl at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55292

--- Comment #1 from hjl at gcc dot gnu.org <hjl at gcc dot gnu.org> 2012-11-14 13:46:01 UTC ---
Author: hjl
Date: Wed Nov 14 13:45:56 2012
New Revision: 193500

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193500
Log:
Check __x86_64__ instead of __WORDSIZE

    PR other/55292
    Backport from upstream revision 167883
    * sanitizer_common/sanitizer_linux.cc (internal_mmap): Check
    __x86_64__ instead of __WORDSIZE.
    (internal_filesize): Likwise.

Modified:
    trunk/libsanitizer/ChangeLog
    trunk/libsanitizer/sanitizer_common/sanitizer_linux.cc

[Bug other/55292] libsanitizer doesn't support x32

[hjl.tools at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55292

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> 2012-11-14 13:47:25 UTC ---
Fixed.