[Bug fortran/55352] Erroneous gfortran warning of unused module variable when variable is only used in namelist

["janus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55352

--- Comment #3 from janus at gcc dot gnu.org 2012-11-16 21:43:34 UTC ---
(In reply to comment #2)
> I guess we should either set attr.referenced in gfc_match_namelist (match.c),
> or check for attr.in_namelist in generate_local_decl (trans-decl.c).

The latter is what we do for related cases. Proposed patch:

Index: gcc/fortran/trans-decl.c
===================================================================
--- gcc/fortran/trans-decl.c    (revision 193567)
+++ gcc/fortran/trans-decl.c    (working copy)
@@ -4589,23 +4589,26 @@ generate_local_decl (gfc_symbol * sym)
     }

       /* Warn for unused variables, but not if they're inside a common
-     block, a namelist, or are use-associated.  */
+     block or a namelist.  */
       else if (warn_unused_variable
-           && !(sym->attr.in_common || sym->attr.use_assoc || sym->mark
-            || sym->attr.in_namelist))
+           && !(sym->attr.in_common || sym->mark || sym->attr.in_namelist))
     {
-      gfc_warning ("Unused variable '%s' declared at %L", sym->name,
-               &sym->declared_at);
-      if (sym->backend_decl != NULL_TREE)
-        TREE_NO_WARNING(sym->backend_decl) = 1;
+      if (sym->attr.use_only)
+        {
+          gfc_warning ("Unused module variable '%s' which has been "
+               "explicitly imported at %L", sym->name,
+               &sym->declared_at);
+          if (sym->backend_decl != NULL_TREE)
+        TREE_NO_WARNING(sym->backend_decl) = 1;
+        }
+      else if (!sym->attr.use_assoc)
+        {
+          gfc_warning ("Unused variable '%s' declared at %L",
+               sym->name, &sym->declared_at);
+          if (sym->backend_decl != NULL_TREE)
+        TREE_NO_WARNING(sym->backend_decl) = 1;
+        }
     }
-      else if (warn_unused_variable && sym->attr.use_only)
-    {
-      gfc_warning ("Unused module variable '%s' which has been explicitly "
-               "imported at %L", sym->name, &sym->declared_at);
-      if (sym->backend_decl != NULL_TREE)
-        TREE_NO_WARNING(sym->backend_decl) = 1;
-    }

       /* For variable length CHARACTER parameters, the PARM_DECL already
      references the length variable, so force gfc_get_symbol_decl