[Bug fortran/55362] New: [4.6/4.7/4.8 Regression] ICE with size() on character pointer

[Bug fortran/55362] New: [4.6/4.7/4.8 Regression] ICE with size() on character pointer

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

             Bug #: 55362
           Summary: [4.6/4.7/4.8 Regression] ICE with size() on character
                    pointer
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dominiq@lps.ens.fr


>From http://gcc.gnu.org/ml/fortran/2012-11/msg00034.html
the following test

program ice_test
  implicit none
  write(*,*) 'message: ', size(Error_Msg),Error_Msg()
contains
  function Error_Msg() result(ErrorMsg)
    character, dimension(:), pointer :: ErrorMsg
    character, dimension(1), target :: str = '!'
    ErrorMsg => str
  end function Error_Msg
end program ice_test

gives an ICE when compiled with 4.6.3, 4.7.2

error_msg.f90:3:0: internal compiler error: in gfc_conv_intrinsic_size, at
fortran/trans-intrinsic.c:4427 (4.6) or 5059 (4.7)

and trunk (r193382)

error_msg.f90:3:0: internal compiler error: in gfc_conv_expr_descriptor, at
fortran/trans-array.c:6417
   write(*,*) 'message: ', size(Error_Msg),Error_Msg()

while 4.5.3 gives an error

error_msg.f90:3.31:

  write(*,*) 'message: ', size(Error_Msg),Error_Msg()
                               1
Error: Internal procedure 'error_msg' is not allowed as an actual argument at
(1)

In all cases the ICE occurs in gfc_conv_intrinsic_size (4.6/4.7) or
gfc_conv_expr_descriptor (4.8) at

  gcc_assert (ss != gfc_ss_terminator);

Revision 163532 (2010-08-24) gives the error; revision 163841 (2010-09-03)
gives the ICE (a lot of changes in this range: f2008 intrinsics and float_128).

The backtrace for 4.6 revision 182981 is

#1  0x00000001000e62f6 in gfc_conv_intrinsic_function (se=0x7fff5fbfd2a0,
expr=0x141d0d870) at ../../p6_work/gcc/fortran/trans-intrinsic.c:4427
#2  0x00000001000d7043 in gfc_conv_function_expr (se=0x7fff5fbfd2a0,
expr=<value optimized out>) at ../../p6_work/gcc/fortran/trans-expr.c:4064
#3  0x00000001000d1b33 in gfc_conv_expr_reference (se=0x7fff5fbfd2a0,
expr=<value optimized out>) at ../../p6_work/gcc/fortran/trans-expr.c:4889
#4  0x00000001000eabcf in gfc_trans_transfer (code=0x141d0dba0) at
../../p6_work/gcc/fortran/trans-io.c:2314
#5  0x00000001000b01e8 in trans_code (code=0x141d0dba0, cond=0x141c61498) at
../../p6_work/gcc/fortran/trans.c:1382
#6  0x00000001000e8896 in build_dt (function=0x141ef8800, code=0x141d0df60) at
../../p6_work/gcc/fortran/trans-io.c:1838
#7  0x00000001000b0228 in trans_code (code=0x141d0df60, cond=0x0) at
../../p6_work/gcc/fortran/trans.c:1354
#8  0x00000001000caa81 in gfc_generate_function_code (ns=<value optimized out>)
at ../../p6_work/gcc/fortran/trans-decl.c:4827
#9  0x000000010006ff1c in gfc_parse_file () at
../../p6_work/gcc/fortran/parse.c:4265
#10 0x00000001000aba36 in gfc_be_parse_file () at
../../p6_work/gcc/fortran/f95-lang.c:250
#11 0x0000000100626b3e in toplev_main (argc=2, argv=0x7fff5fbfd7a8) at
../../p6_work/gcc/toplev.c:579

and for trunk revision 193329

#12 0x00000001000d9162 in gfc_conv_expr_descriptor (se=<value optimized out>,
expr=<value optimized out>)
    at ../../p_work/gcc/fortran/trans-array.c:6417
#13 0x00000001000f827d in gfc_conv_intrinsic_size (se=<value optimized out>,
expr=<value optimized out>)
    at ../../p_work/gcc/fortran/trans-intrinsic.c:5052
#14 0x0000000100104ee6 in gfc_conv_intrinsic_function (se=<value optimized
out>, expr=<value optimized out>)
    at ../../p_work/gcc/fortran/trans-intrinsic.c:6763
#15 0x00000001000eff59 in gfc_conv_expr (se=<value optimized out>, expr=<value
optimized out>) at ../../p_work/gcc/fortran/trans-expr.c:5408
#16 0x00000001000f4226 in gfc_conv_expr_reference (se=<value optimized out>,
expr=<value optimized out>)
    at ../../p_work/gcc/fortran/trans-expr.c:6244
#17 0x000000010010b890 in gfc_trans_transfer (code=0x141514b00) at
../../p_work/gcc/fortran/trans-io.c:2307
#18 0x00000001000c7d88 in trans_code (code=0x141514b00, cond=0x141b0ee88) at
../../p_work/gcc/fortran/trans.c:1510
#19 0x0000000100109666 in build_dt (function=0x141b09e00, code=0x141514ec0) at
../../p_work/gcc/fortran/trans-io.c:1831
#20 0x00000001000c7da8 in trans_code (code=0x141514ec0, cond=0x0) at
../../p_work/gcc/fortran/trans.c:1482
#21 0x00000001000e6b14 in gfc_generate_function_code (ns=<value optimized out>)
at ../../p_work/gcc/fortran/trans-decl.c:5349
#22 0x000000010008435c in gfc_parse_file () at
../../p_work/gcc/fortran/parse.c:4467
#23 0x00000001000c3e86 in gfc_be_parse_file () at
../../p_work/gcc/fortran/f95-lang.c:191
#24 0x0000000100669989 in compile_file () at ../../p_work/gcc/toplev.c:544
#25 0x000000010066b7e9 in toplev_main(int, char**) (argc=2,
argv=0x7fff5fbfd780) at ../../p_work/gcc/toplev.c:1797
#26 0x000000010000a7c4 in start (pc=<value optimized out>, bases=0x0) at
../../../p_work/libgcc/config/unwind-dw2-fde-darwin.c:271

[Bug fortran/55362] [4.6/4.7/4.8 Regression] ICE with size() on character pointer

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-11-17
      Known to work|                            |4.5.3
     Ever Confirmed|0                           |1
      Known to fail|                            |4.6.3, 4.7.2, 4.8.0

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2012-11-17 10:39:09 UTC ---
Marked as NEW.

[Bug fortran/55362] [4.6/4.7/4.8 Regression] ICE with size() on character pointer

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.6.4

[Bug fortran/55362] [4.6/4.7/4.8 Regression] ICE with size() on character pointer

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |ice-on-invalid-code
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-11 14:46:03 UTC ---
Untested patch. However, I think we need to do more. I think it won't cover the
DIM= argument and other intrinsics are presumably also affected.


--- a/gcc/fortran/check.c
+++ b/gcc/fortran/check.c
@@ -3593,4 +3593,11 @@ gfc_try
 gfc_check_size (gfc_expr *array, gfc_expr *dim, gfc_expr *kind)
 {
+  if (array->ts.type == BT_PROCEDURE)
+    {
+      gfc_error ("'%s' argument of '%s' intrinsic at %L may not be a
procedure",
+                gfc_current_intrinsic_arg[0]->name, gfc_current_intrinsic,
+                &array->where);
+      return FAILURE;
+    }
   if (array_check (array, 0) == FAILURE)
     return FAILURE;

[Bug fortran/55362] [4.6/4.7/4.8 Regression] ICE with size() on character pointer

[pault at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pault at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |pault at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Paul Thomas <pault at gcc dot gnu.org> 2013-01-12 16:11:23 UTC ---
Applying Tobias' fix to array_check seems to do the job.  As to his question
about the DIM arg; this and probably many more need such a check.  I am
surprised that it is not picked up in resolution. ifort gives

[pault@localhost pr55789]$ ifort ../pr55362/p*.f90../pr55362/pr55362.f90(3):
error #6423: This name has already been used as an external function name.  
[ERROR_MSG]
  write(*,*) 'message: ', size(Error_Msg),Error_Msg()
-------------------------------^
../pr55362/pr55362.f90(3): error #6361: An array-valued argument is required in
this context.   [SIZE]
  write(*,*) 'message: ', size(Error_Msg),Error_Msg()
-------------------------------^
compilation aborted for ../pr55362/pr55362.f90 (code 1)

[Bug fortran/55362] [4.6/4.7/4.8 Regression] ICE with size() on character pointer

[pault at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

--- Comment #4 from Paul Thomas <pault at gcc dot gnu.org> 2013-02-09 09:49:52 UTC ---
Author: pault
Date: Sat Feb  9 09:49:49 2013
New Revision: 195915

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195915
Log:
2013-02-09  Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/55362
    * check.c (array_check): It is an error if a procedure is
    passed.

2013-02-09  Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/55362
    * gfortran.dg/intrinsic_size_4.f90 : New test.


Added:
    trunk/gcc/testsuite/gfortran.dg/intrinsic_size_4.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/check.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/55362] [4.6/4.7 Regression] ICE with size() on character pointer

[pault at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

Paul Thomas <pault at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.6/4.7/4.8 Regression]    |[4.6/4.7 Regression] ICE
                   |ICE with size() on          |with size() on character
                   |character pointer           |pointer

--- Comment #5 from Paul Thomas <pault at gcc dot gnu.org> 2013-02-09 09:55:35 UTC ---
I'll deal with 4.6 and 4.7 tomorrow

Paul

[Bug fortran/55362] [4.6/4.7 Regression] ICE with size() on character pointer

[mikael at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

Mikael Morin <mikael at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mikael at gcc dot gnu.org

--- Comment #6 from Mikael Morin <mikael at gcc dot gnu.org> 2013-03-02 17:25:25 UTC ---
(In reply to comment #5)
> I'll deal with 4.6 and 4.7 tomorrow
> 
Friendly reminder... :-)

[Bug fortran/55362] [4.6/4.7 Regression] ICE with size() on character pointer

[paul.richard.thomas at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

--- Comment #7 from paul.richard.thomas at gmail dot com <paul.richard.thomas at gmail dot com> 2013-03-03 18:09:08 UTC ---
Thanks Mikael,

I have been in the middle of one of my "no gfortran periods".  I am
back in France next week and will get to this on Tuesday or Wednesday.

Cheers

Paul

On 2 March 2013 18:25, mikael at gcc dot gnu.org
<gcc-bugzilla@gcc.gnu.org> wrote:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362
>
> Mikael Morin <mikael at gcc dot gnu.org> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |mikael at gcc dot gnu.org
>
> --- Comment #6 from Mikael Morin <mikael at gcc dot gnu.org> 2013-03-02 17:25:25 UTC ---
> (In reply to comment #5)
>> I'll deal with 4.6 and 4.7 tomorrow
>>
> Friendly reminder... :-)
>
> --
> Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are on the CC list for the bug.
> You are the assignee for the bug.



--
The knack of flying is learning how to throw yourself at the ground and miss.
       --Hitchhikers Guide to the Galaxy

[Bug fortran/55362] [4.6/4.7 Regression] ICE with size() on character pointer

[pault at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

--- Comment #8 from Paul Thomas <pault at gcc dot gnu.org> 2013-03-10 18:34:35 UTC ---
Author: pault
Date: Sun Mar 10 18:34:24 2013
New Revision: 196582

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196582
Log:
2013-03-10  Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/55362
    * check.c (array_check): It is an error if a procedure is
    passed.

2013-03-10  Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/55362
    * gfortran.dg/intrinsic_size_4.f90 : New test.


Added:
    branches/gcc-4_7-branch/gcc/testsuite/gfortran.dg/intrinsic_size_4.f90
Modified:
    branches/gcc-4_7-branch/gcc/fortran/ChangeLog
    branches/gcc-4_7-branch/gcc/fortran/check.c
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog

[Bug fortran/55362] [4.6/4.7 Regression] ICE with size() on character pointer

[pault at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

--- Comment #9 from Paul Thomas <pault at gcc dot gnu.org> 2013-03-10 20:14:57 UTC ---
Author: pault
Date: Sun Mar 10 20:14:48 2013
New Revision: 196583

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196583
Log:
2013-03-10  Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/55362
    * check.c (array_check): It is an error if a procedure is
    passed.

2013-03-10  Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/55362
    * gfortran.dg/intrinsic_size_4.f90 : New test.


Added:
    branches/gcc-4_6-branch/gcc/testsuite/gfortran.dg/intrinsic_size_4.f90
Modified:
    branches/gcc-4_6-branch/gcc/fortran/ChangeLog
    branches/gcc-4_6-branch/gcc/fortran/check.c
    branches/gcc-4_6-branch/gcc/testsuite/ChangeLog

[Bug fortran/55362] [4.6/4.7 Regression] ICE with size() on character pointer

[pault at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

--- Comment #10 from Paul Thomas <pault at gcc dot gnu.org> 2013-03-10 21:02:52 UTC ---
Author: pault
Date: Sun Mar 10 21:02:44 2013
New Revision: 196584

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196584
Log:
2013-03-10  Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/55362
    * check.c (array_check): It is an error if a procedure is
    passed.

2013-03-10  Paul Thomas  <pault@gcc.gnu.org>

    PR fortran/55362
    * gfortran.dg/intrinsic_size_4.f90 : New test.


Modified:
    branches/gcc-4_6-branch/gcc/fortran/check.c

[Bug fortran/55362] [4.6/4.7 Regression] ICE with size() on character pointer

[izamyatin at gmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

Igor Zamyatin <izamyatin at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |izamyatin at gmail dot com

--- Comment #11 from Igor Zamyatin <izamyatin at gmail dot com> 2013-03-11 06:20:02 UTC ---
r196583 seems to break 4_6 branch bootstrap with

/export/gnu/import/git/gcc-test/bld/./prev-gcc/xgcc
-B/export/gnu/import/git/gcc-test/bld/./prev-gcc/
-B/usr/local/i686-pc-linux-gnu/bin/ -B/usr/local/i686-pc-linux-gnu/bin/
-B/usr/local/i686-pc-linux-gnu/lib/ -isystem
/usr/local/i686-pc-linux-gnu/include -isystem
/usr/local/i686-pc-linux-gnu/sys-include    -c  -DIN_GCC_FRONTEND -g -O2
-fomit-frame-pointer -gtoggle -DIN_GCC   -W -Wall -Wwrite-strings -Wcast-qual
-Wstrict-prototypes -Wmissing-prototypes -Wmissing-format-attribute -pedantic
-Wno-long-long -Wno-variadic-macros -Wno-overlength-strings
-Wold-style-definition -Wc++-compat   -DHAVE_CONFIG_H -I. -Ifortran
-I../../src-4.6/gcc -I../../src-4.6/gcc/fortran -I../../src-4.6/gcc/../include
-I../../src-4.6/gcc/../libcpp/include  -I../../src-4.6/gcc/../libdecnumber
-I../../src-4.6/gcc/../libdecnumber/bid -I../libdecnumber   
../../src-4.6/gcc/fortran/check.c -o fortran/check.o
../../src-4.6/gcc/fortran/check.c: In function 'array_check':
../../src-4.6/gcc/fortran/check.c:268:50: error: expected statement before ')'
token
make[6]: *** [fortran/check.o] Error 1

[Bug fortran/55362] [4.6/4.7 Regression] ICE with size() on character pointer

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

--- Comment #12 from Tobias Burnus <burnus at gcc dot gnu.org> 2013-03-11 08:30:42 UTC ---
(In reply to comment #11)
> r196583 seems to break 4_6 branch bootstrap with [...]

I believe that this has been fixed by Rev. 196584 (comment 10), which happened
45 minutes after Rev. 196583.

[Bug fortran/55362] [4.6/4.7 Regression] ICE with size() on character pointer

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55362

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2013-03-11 17:42:56 UTC ---
I have regstrapped 4.6.4 at revision 196596 configured with

--prefix=/opt/gcc/gcc4.6p --enable-languages=c,c++,lto,fortran
--with-gmp=/opt/mp --with-system-zlib --enable-lto

without unexpected failure for gfortran. Closing as fixed. Paul, thanks for the
fix.