From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8772 invoked by alias); 18 Nov 2012 09:30:37 -0000 Received: (qmail 8740 invoked by uid 48); 18 Nov 2012 09:30:23 -0000 From: "ebotcazou at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug other/55376] [asan] libsanitizer/README.gcc must contain the exact steps to do code changes and to port code from upstream Date: Sun, 18 Nov 2012 09:30:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: other X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: ebotcazou at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Status Last reconfirmed CC Ever Confirmed Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg01633.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55376 Eric Botcazou changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Last reconfirmed| |2012-11-18 CC| |ebotcazou at gcc dot | |gnu.org Ever Confirmed|0 |1 --- Comment #2 from Eric Botcazou 2012-11-18 09:30:22 UTC --- > Few things to cover: > > - The changes need to be approved by one of the maintainers (or is it obvious)? Yes, it's how GCC works. > - Except for *really* trivial changes all patches should go through the > upstream tree first. That's not acceptable. We don't want to have to go through LLVM to fix issues in GCC, especially for the platforms that LLVM doesn't support, i.e. most of them. > - What is the testing procedure when updating from upstream? (e.g. how do we > avoid regressions on the platforms to which the maintainers have no access?) Introducing such regressions is acceptable, provided that they can be quickly fixed by the target maintainers. Hence the "not acceptable" above.