public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "konstantin.s.serebryany at gmail dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug other/55376] [asan] libsanitizer/README.gcc must contain the exact steps to do code changes and to port code from upstream Date: Sun, 18 Nov 2012 18:47:00 -0000 [thread overview] Message-ID: <bug-55376-4-zs7KDi1sla@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-55376-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55376 --- Comment #3 from Konstantin Serebryany <konstantin.s.serebryany at gmail dot com> 2012-11-18 18:47:19 UTC --- >> Are all upstream changes considered reviewed and automatically approved for gcc repo? all upstream changes are pre- or post- reviewed, so my answer here is "yes". >> That's not acceptable. We don't want to have to go through LLVM to fix issues in GCC, especially for the platforms that LLVM doesn't support, i.e. most of them. I've got your point, but please understand mine: if the trees go too much out of sync we (the asan team) will lose control over one of the copies (gcc). It will mean that some one else (not us) will have to work on asan in gcc. Maybe that's not bad, but I don't want it. Syncing the trees in the presence of difference in the comment headers make the syncing task a tiny bit more challenging. I hope that at some point when we get enough contributions to libsanitizer from the GCC community, we will be able to unify the headers by saying "This is part of LLVM and GCC projects". WDYT? As I understood from previous e-mails, there are libraries with similar problems in the gcc tree. What are the solutions there? >> Introducing such regressions is acceptable, provided that they can be quickly fixed by the target maintainers. It's great that such regressions is acceptable, but if there is an infrastructure that allows us to know about possible regressions before the commit (aka try bots), I'd like to know.
next prev parent reply other threads:[~2012-11-18 18:47 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-11-18 4:07 [Bug other/55376] New: " konstantin.s.serebryany at gmail dot com 2012-11-18 5:18 ` [Bug other/55376] " xinliangli at gmail dot com 2012-11-18 9:30 ` ebotcazou at gcc dot gnu.org 2012-11-18 18:47 ` konstantin.s.serebryany at gmail dot com [this message] 2012-11-19 22:58 ` ebotcazou at gcc dot gnu.org 2012-11-20 5:41 ` konstantin.s.serebryany at gmail dot com 2012-11-20 7:23 ` ebotcazou at gcc dot gnu.org 2012-11-20 10:17 ` manu at gcc dot gnu.org 2012-11-21 4:24 ` konstantin.s.serebryany at gmail dot com 2012-11-23 10:57 ` [Bug sanitizer/55376] " konstantin.s.serebryany at gmail dot com 2012-11-23 12:45 ` konstantin.s.serebryany at gmail dot com 2012-11-23 12:57 ` konstantin.s.serebryany at gmail dot com
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-55376-4-zs7KDi1sla@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).