[Bug bootstrap/55398] New: r193595 breaks bootstrap with clang compilers

[Bug bootstrap/55398] New: r193595 breaks bootstrap with clang compilers

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

             Bug #: 55398
           Summary: r193595 breaks bootstrap with clang compilers
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: howarth@nitro.med.uc.edu


The r193595 causes both Apple clang 4.1 and llvm 3.2 clang svn to fail to
bootstrap gcc trunk with the failure...

clang++ -c   -g -DIN_GCC   -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -I.
-I. -I../../gcc-4.8-20121119/gcc -I../../gcc-4.8-20121119/gcc/.
-I../../gcc-4.8-20121119/gcc/../include
-I../../gcc-4.8-20121119/gcc/../libcpp/include -I/sw/include -I/sw/include 
-I../../gcc-4.8-20121119/gcc/../libdecnumber
-I../../gcc-4.8-20121119/gcc/../libdecnumber/dpd -I../libdecnumber
-I../../gcc-4.8-20121119/gcc/../libbacktrace -DCLOOG_INT_GMP -I/sw/include
-I/sw/include -I/sw/include ../../gcc-4.8-20121119/gcc/tree-data-ref.c -o
tree-data-ref.o
clang: warning: treating 'c' input as 'c++' when in C++ mode, this behavior is
deprecated
../../gcc-4.8-20121119/gcc/tree-data-ref.c:1599:31: error: second argument to
'va_arg' is of non-POD type 'affine_fn' (aka 'vec<tree>') [-Wnon-pod-varargs]
    ret->fns[i] = va_arg (ap, affine_fn);
                  ~~~~~~~~~~~~^~~~~~~~~~
/usr/bin/../lib/clang/4.1/include/stdarg.h:35:50: note: expanded from macro
'va_arg'
#define va_arg(ap, type)    __builtin_va_arg(ap, type)
                                                 ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:1665:34: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
          *overlaps_a = conflict_fn (1, affine_fn_cst (integer_zero_node));
                                        ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:1666:34: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
          *overlaps_b = conflict_fn (1, affine_fn_cst (integer_zero_node));
                                        ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:1812:37: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
      *overlaps_a = conflict_fn (1, affine_fn_cst (integer_zero_node));
                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:1813:37: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
      *overlaps_b = conflict_fn (1, affine_fn_cst (integer_zero_node));
                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:1858:39: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
                      *overlaps_a = conflict_fn (1, affine_fn_cst
(integer_zero_node));
                                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:1862:39: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
                      *overlaps_b = conflict_fn (1, affine_fn_cst (tmp));
                                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:1938:39: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
                      *overlaps_a = conflict_fn (1, affine_fn_cst
(integer_zero_node));
                                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:1941:39: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
                      *overlaps_b = conflict_fn (1, affine_fn_cst (tmp));
                                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:2203:37: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
      *overlaps_a = conflict_fn (2, ova1, ova2);
                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:2203:43: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
      *overlaps_a = conflict_fn (2, ova1, ova2);
                                          ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:2204:37: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
      *overlaps_b = conflict_fn (1, ovb);
                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:2208:37: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
      *overlaps_a = conflict_fn (1, affine_fn_cst (integer_zero_node));
                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:2209:37: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
      *overlaps_b = conflict_fn (1, affine_fn_cst (integer_zero_node));
                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:2404:37: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
      *overlaps_a = conflict_fn (1, affine_fn_cst (integer_zero_node));
                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:2405:37: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
      *overlaps_b = conflict_fn (1, affine_fn_cst (integer_zero_node));
                                    ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:2462:34: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
          *overlaps_a = conflict_fn (1, ova);
                                        ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:2463:34: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
          *overlaps_b = conflict_fn (1, ovb);
                                        ^
../../gcc-4.8-20121119/gcc/tree-data-ref.c:2604:11: error: cannot pass object
of non-POD type 'affine_fn' (aka 'vec<tree>') through variadic function; call
will abort at runtime [-Wnon-pod-varargs]
                               affine_fn_univar (build_int_cst (NULL_TREE, x1),
                               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[3]: *** [tree-data-ref.o] Error 1
make[2]: *** [all-stage1-gcc] Error 2
make[1]: *** [stage1-bubble] Error 2
make: *** [all] Error 2

[Bug bootstrap/55398] r193595 breaks bootstrap with clang compilers

[howarth at nitro dot med.uc.edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

--- Comment #1 from Jack Howarth <howarth at nitro dot med.uc.edu> 2012-11-19 21:41:04 UTC ---
This was with...

 ../gcc-4.8-20121119/configure --prefix=/sw --prefix=/sw/lib/gcc4.8
--mandir=/sw/share/man --infodir=/sw/lib/gcc4.8/info
--enable-languages=c,c++,fortran,lto,objc,obj-c++,java --with-gmp=/sw
--with-libiconv-prefix=/sw --with-isl=/sw --with-cloog=/sw --with-mpc=/sw
--with-system-zlib --enable-checking=yes --x-includes=/usr/X11R6/include
--x-libraries=/usr/X11R6/lib --program-suffix=-fsf-4.8
--disable-cloog-version-check --disable-isl-version-check

I can bootstrap on x86_64-apple-darwin12 using FSF gcc 4.7.2 but not with Xcode
4.5.2's llvm-gcc compilers which fail from a different bug...

llvm-g++-4.2   -g -DIN_GCC   -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wwrite-strings -Wcast-qual
-Wmissing-format-attribute -pedantic -Wno-long-long -Wno-variadic-macros
-Wno-overlength-strings -fno-common  -DHAVE_CONFIG_H -DGENERATOR_FILE  -o
build/genautomata \
        build/genautomata.o build/rtl.o build/read-rtl.o build/ggc-none.o
build/vec.o build/min-insn-modes.o build/gensupport.o build/print-rtl.o
build/read-md.o build/errors.o
../build-x86_64-apple-darwin12.2.0/libiberty/libiberty.a -lm
build/genautomata ../../gcc-4.8-20121119/gcc/config/i386/i386.md \
      insn-conditions.md > tmp-automata.c
genautomata(20280) malloc: *** error for object 0xd108c512bc664: pointer being
freed was not allocated
*** set a breakpoint in malloc_error_break to debug
/bin/sh: line 1: 20280 Abort trap: 6           build/genautomata
../../gcc-4.8-20121119/gcc/config/i386/i386.md insn-conditions.md >
tmp-automata.c
make[3]: *** [s-automata] Error 134
make[2]: *** [all-stage1-gcc] Error 2
make[1]: *** [stage1-bubble] Error 2
make: *** [all] Error 2

[Bug bootstrap/55398] r193595 breaks bootstrap with clang compilers

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-19 21:43:46 UTC ---
The llvm-gcc failure is recorded as PR 55387.

[Bug bootstrap/55398] [4.8 Regression] var_arg usage with non-POD causes clang to fail to build gcc

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0
            Summary|r193595 breaks bootstrap    |[4.8 Regression] var_arg
                   |with clang compilers        |usage with non-POD causes
                   |                            |clang to fail to build gcc

[Bug bootstrap/55398] [4.8 Regression] var_arg usage with non-POD causes clang to fail to build gcc

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pinskia at gcc dot gnu.org

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-20 00:03:31 UTC ---
*** Bug 55404 has been marked as a duplicate of this bug. ***

[Bug bootstrap/55398] [4.8 Regression] var_arg usage with non-POD

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |build, ice-on-valid-code
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-11-20
            Summary|[4.8 Regression] var_arg    |[4.8 Regression] var_arg
                   |usage with non-POD causes   |usage with non-POD
                   |clang to fail to build gcc  |
     Ever Confirmed|0                           |1
           Severity|normal                      |blocker

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-20 00:06:24 UTC ---
We also have the same issue with compiling GCC with GCC 4.4.5 and then running
the testsuite at -O3.  This is done for cross compilers all the time.  In fact
I noticed it while I was trying to run the testsuite for AARCH64.

[Bug middle-end/55398] [4.8 Regression] var_arg usage with non-POD

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|x86_64-apple-darwin12       |
          Component|bootstrap                   |middle-end
               Host|x86_64-apple-darwin12       |
              Build|x86_64-apple-darwin12       |

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-20 00:10:10 UTC ---
The target or the host no longer matters as I said I see the same issue on
x86_64-linux-gnu crossing to aarch64-thunder-elf.

[Bug middle-end/55398] [4.8 Regression] var_arg usage with non-POD

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> 2012-11-20 00:15:14 UTC ---
>From http://gcc.gnu.org/gcc-4.5/changes.html :
# Diagnostics that used to complain about passing non-POD types to ... or
jumping past the declaration of a non-POD variable now check for triviality
rather than PODness, as per C++0x.

[Bug middle-end/55398] [4.8 Regression] va_arg usage with non-POD

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

Diego Novillo <dnovillo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dnovillo at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |dnovillo at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #7 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-11-20 14:12:43 UTC ---
Fixing.

[Bug middle-end/55398] [4.8 Regression] va_arg usage with non-POD

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

--- Comment #8 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-11-20 16:26:24 UTC ---
Author: dnovillo
Date: Tue Nov 20 16:26:09 2012
New Revision: 193667

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193667
Log:
Convert vec<> into a POD.

This fixes PR 55398 by making vec<> a true POD.  I thought we could get
away with having private fields, but we can't.  We fail to pass vec<>
instances through varargs.

The patch makes every field public and mangles the field names in the
hope that no future patch will try to make use of them directly.  It's
horrible, but I could not think of anything better.

Tested with clang++ as the host compiler.

2012-11-20  Diego Novillo  <dnovillo@google.com>

    PR middle-end/55398
    * vec.h (class vec_prefix): Make every field public.
    Rename field alloc_ to alloc_PRIVATE_.
    Rename field num_ to num_PRIVATE_.
    Update all users.
    (class vec<T, A, vl_embed>): Make every field public.
    Rename field pfx_ to pfx_PRIVATE_.
    Rename field data_ to data_PRIVATE_.
    Update all users.
    (class vec<T, A, vl_ptr>): Make every field public.
    Rename field vec_ to vec_PRIVATE_.
    Update all users.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/vec.c
    trunk/gcc/vec.h

[Bug middle-end/55398] [4.8 Regression] va_arg usage with non-POD

[dnovillo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55398

Diego Novillo <dnovillo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Diego Novillo <dnovillo at gcc dot gnu.org> 2012-11-20 16:30:14 UTC ---
Fixed.