[Bug middle-end/55401] New: uninstrumented path in TM clones are still instrumented

[Bug middle-end/55401] New: uninstrumented path in TM clones are still instrumented

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55401

             Bug #: 55401
           Summary: uninstrumented path in TM clones are still
                    instrumented
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: aldyh@gcc.gnu.org


If a transaction appears in a TM clone, the uninstrumented path still gets
instrumented.  Example:

int george;
int ringo;

__attribute__((transaction_callable))
void q1()
{
  ringo=666;
  __transaction_atomic {
      george=999;
  }
}


Generated code:

  <bb 2>:
  _8 = 666;
  __builtin__ITM_WU4 (&ringo, _8);
  tm_state.5_11 = __builtin__ITM_beginTransaction (43);
  _12 = tm_state.5_11 & 2;
  if (_12 != 0)
    goto <bb 3>;
  else
    goto <bb 4>;

  <bb 3>:
  _13 = 999;
  __builtin__ITM_WU4 (&george, _13);
  __builtin__ITM_commitTransaction ();
  goto <bb 5>;

  <bb 4>:
  _15 = 999;
  __builtin__ITM_WU4 (&george, _15);
  __builtin__ITM_commitTransaction ();

  <bb 5>:
  return;

[Bug middle-end/55401] uninstrumented path in TM clones are still instrumented

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55401

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-11-19
                 CC|                            |aldyh at gcc dot gnu.org,
                   |                            |rth at gcc dot gnu.org
     Ever Confirmed|0                           |1

[Bug middle-end/55401] uninstrumented path in TM clones are still instrumented

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55401

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at gcc dot       |aldyh at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #1 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-11-29 01:10:51 UTC ---
Proposed patch.
http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02386.html

[Bug middle-end/55401] uninstrumented path in TM clones are still instrumented

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55401

--- Comment #2 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-12-03 16:11:33 UTC ---
Author: aldyh
Date: Mon Dec  3 16:11:21 2012
New Revision: 194099

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194099
Log:
    PR middle-end/55401
    * trans-mem.c (get_tm_region_blocks): Exclude uninstrumented
    blocks from vector if requested.
    (collect_bb2reg): Pass new argument to
    get_tm_region_blocks.
    (get_bb_regions_instrumented): Add INCLUDE_UNINSTRUMENTED_P
    argument, and pass it to expand_regions.
    (execute_tm_mark): Pass new argument to
    get_bb_regions_instrumented.
    (execute_tm_edges): Same.

Added:
    trunk/gcc/testsuite/gcc.dg/tm/pr55401.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/trans-mem.c

[Bug middle-end/55401] uninstrumented path in TM clones are still instrumented

[aldyh at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55401

Aldy Hernandez <aldyh at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Aldy Hernandez <aldyh at gcc dot gnu.org> 2012-12-04 00:24:57 UTC ---
fixed in trunk