public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/55415] New: Early SRA produces unaligned complex types
@ 2012-11-20 16:57 rth at gcc dot gnu.org
2012-11-20 17:09 ` [Bug tree-optimization/55415] " rth at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2012-11-20 16:57 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55415
Bug #: 55415
Summary: Early SRA produces unaligned complex types
Classification: Unclassified
Product: gcc
Version: unknown
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: tree-optimization
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: rth@gcc.gnu.org
While looking at PR55403 one has to wonder where the unaligned
complex long double type came from in the first place:
#0 copy_node_stat (node=0x7ffff1aeb9d8) at ../../git-master/gcc/tree.c:961
#1 0x0000000000e33162 in build_distinct_type_copy (type=0x7ffff1aeb9d8)
at ../../git-master/gcc/tree.c:5856
#2 0x0000000000e332d5 in build_variant_type_copy (type=0x7ffff1aeb9d8)
at ../../git-master/gcc/tree.c:5890
#3 0x0000000000e33119 in build_aligned_type (type=0x7ffff1aeb9d8, align=8)
at ../../git-master/gcc/tree.c:5842
#4 0x0000000000a39b7d in ipa_modify_call_arguments (cs=0x7ffff11493a8,
stmt=0x7ffff1147428, adjustments=...)
at ../../git-master/gcc/ipa-prop.c:2967
I'm still not quite sure why ipa_modify_call_arguments *ever* wants to
create misaligned types as function interfaces?
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55415] Early SRA produces unaligned complex types
2012-11-20 16:57 [Bug tree-optimization/55415] New: Early SRA produces unaligned complex types rth at gcc dot gnu.org
@ 2012-11-20 17:09 ` rth at gcc dot gnu.org
2012-11-20 20:34 ` jamborm at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rth at gcc dot gnu.org @ 2012-11-20 17:09 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55415
--- Comment #1 from Richard Henderson <rth at gcc dot gnu.org> 2012-11-20 17:08:15 UTC ---
The call to get_pointer_alignment_1 at ipa-prop.c:2959
does not do what the author intended. In particular we
really really need to notice the "false" return value
when the results are conservative, and do nothing.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55415] Early SRA produces unaligned complex types
2012-11-20 16:57 [Bug tree-optimization/55415] New: Early SRA produces unaligned complex types rth at gcc dot gnu.org
2012-11-20 17:09 ` [Bug tree-optimization/55415] " rth at gcc dot gnu.org
@ 2012-11-20 20:34 ` jamborm at gcc dot gnu.org
2012-11-23 18:02 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2012-11-20 20:34 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55415
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2012-11-20
AssignedTo|unassigned at gcc dot |jamborm at gcc dot gnu.org
|gnu.org |
Ever Confirmed|0 |1
--- Comment #2 from Martin Jambor <jamborm at gcc dot gnu.org> 2012-11-20 20:33:37 UTC ---
I'm looking into this.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55415] Early SRA produces unaligned complex types
2012-11-20 16:57 [Bug tree-optimization/55415] New: Early SRA produces unaligned complex types rth at gcc dot gnu.org
2012-11-20 17:09 ` [Bug tree-optimization/55415] " rth at gcc dot gnu.org
2012-11-20 20:34 ` jamborm at gcc dot gnu.org
@ 2012-11-23 18:02 ` jakub at gcc dot gnu.org
2012-11-27 20:46 ` jamborm at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-11-23 18:02 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55415
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-11-23 18:01:56 UTC ---
Possibly related to PR55448.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55415] Early SRA produces unaligned complex types
2012-11-20 16:57 [Bug tree-optimization/55415] New: Early SRA produces unaligned complex types rth at gcc dot gnu.org
` (2 preceding siblings ...)
2012-11-23 18:02 ` jakub at gcc dot gnu.org
@ 2012-11-27 20:46 ` jamborm at gcc dot gnu.org
2012-11-30 16:12 ` jamborm at gcc dot gnu.org
2012-12-03 13:28 ` jamborm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2012-11-27 20:46 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55415
--- Comment #4 from Martin Jambor <jamborm at gcc dot gnu.org> 2012-11-27 20:46:11 UTC ---
I have proposed a patch on the mailing list:
http://gcc.gnu.org/ml/gcc-patches/2012-11/msg02265.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55415] Early SRA produces unaligned complex types
2012-11-20 16:57 [Bug tree-optimization/55415] New: Early SRA produces unaligned complex types rth at gcc dot gnu.org
` (3 preceding siblings ...)
2012-11-27 20:46 ` jamborm at gcc dot gnu.org
@ 2012-11-30 16:12 ` jamborm at gcc dot gnu.org
2012-12-03 13:28 ` jamborm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2012-11-30 16:12 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55415
--- Comment #5 from Martin Jambor <jamborm at gcc dot gnu.org> 2012-11-30 16:11:43 UTC ---
Author: jamborm
Date: Fri Nov 30 16:11:33 2012
New Revision: 193998
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193998
Log:
2012-11-30 Martin Jambor <mjambor@suse.cz>
PR middle-end/52890
PR tree-optimization/55415
PR tree-optimization/54386
PR target/55448
* ipa-prop.c (ipa_modify_call_arguments): Be optimistic when
get_pointer_alignment_1 returns false and the base was not a
dereference.
* tree-sra.c (access_precludes_ipa_sra_p): New parameter req_align,
added check for required alignment. Update the user.
* testsuite/gcc.dg/ipa/ipa-sra-7.c: New test.
* testsuite/gcc.dg/ipa/ipa-sra-8.c: Likewise.
* testsuite/gcc.dg/ipa/ipa-sra-9.c: Likewise.
* testsuite/gcc.target/i386/pr55448.c: Likewise.
Added:
trunk/gcc/testsuite/gcc.dg/ipa/ipa-sra-7.c
trunk/gcc/testsuite/gcc.dg/ipa/ipa-sra-8.c
trunk/gcc/testsuite/gcc.dg/ipa/ipa-sra-9.c
trunk/gcc/testsuite/gcc.target/i386/pr55448.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/ipa-prop.c
trunk/gcc/testsuite/ChangeLog
trunk/gcc/tree-sra.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55415] Early SRA produces unaligned complex types
2012-11-20 16:57 [Bug tree-optimization/55415] New: Early SRA produces unaligned complex types rth at gcc dot gnu.org
` (4 preceding siblings ...)
2012-11-30 16:12 ` jamborm at gcc dot gnu.org
@ 2012-12-03 13:28 ` jamborm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2012-12-03 13:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55415
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |DUPLICATE
--- Comment #6 from Martin Jambor <jamborm at gcc dot gnu.org> 2012-12-03 13:27:50 UTC ---
Duplicate. A fixed one, fortunately.
*** This bug has been marked as a duplicate of bug 54386 ***
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-12-03 13:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-11-20 16:57 [Bug tree-optimization/55415] New: Early SRA produces unaligned complex types rth at gcc dot gnu.org
2012-11-20 17:09 ` [Bug tree-optimization/55415] " rth at gcc dot gnu.org
2012-11-20 20:34 ` jamborm at gcc dot gnu.org
2012-11-23 18:02 ` jakub at gcc dot gnu.org
2012-11-27 20:46 ` jamborm at gcc dot gnu.org
2012-11-30 16:12 ` jamborm at gcc dot gnu.org
2012-12-03 13:28 ` jamborm at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).