[Bug fortran/55534] -Wno-missing-include-dirs does not work with gfortran

["manu at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55534

Manuel López-Ibáñez <manu at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-09-09
                 CC|                            |manu at gcc dot gnu.org
         Depends on|                            |62226
     Ever confirmed|0                           |1

--- Comment #7 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
The ideal fix for this would adding a function like:

+bool
+gfc_warning_cmdline (int opt, const char *gmsgid, ...)
+{
+  va_list argp;
+  diagnostic_info diagnostic;
+  bool ret;
+
+  va_start (argp, gmsgid);
+  diagnostic_set_info (&diagnostic, gmsgid, &argp, UNKNOWN_LOCATION,
+                      DK_WARNING);
+  diagnostic.option_index = opt;
+  ret = report_diagnostic (&diagnostic);
+  va_end (argp);
+  return ret;
+}
+

in error.c. Then calling:

Index: gcc/fortran/scanner.c
===================================================================
--- gcc/fortran/scanner.c       (revision 214251)
+++ gcc/fortran/scanner.c       (working copy)
@@ -326,13 +326,13 @@ add_path_to_list (gfc_directorylist **li
       if (errno != ENOENT)
        gfc_warning_now ("Include directory \"%s\": %s", path,
                         xstrerror(errno));
       else
        {
-         /* FIXME:  Also support -Wmissing-include-dirs.  */
          if (warn)
-           gfc_warning_now ("Nonexistent include directory \"%s\"", path);
+           gfc_warning_cmdline (OPT_Wmissing_include_dirs,
+                                "Nonexistent include directory \"%s\"", path);
        }
       return;
     }
   else if (!S_ISDIR (st.st_mode))
     {

Then, NOT adding gfc_option.warn_missing_include_dirs, but instead fixing
62226, and simply adding:

Index: gcc/fortran/lang.opt
===================================================================
--- gcc/fortran/lang.opt        (revision 194167)
+++ gcc/fortran/lang.opt        (working copy)
@@ -254,6 +254,10 @@
 Fortran Warning
 Warn on intrinsics not part of the selected standard

+Wmissing-include-dirs
+Fortran Warning
+; Documented in C
+
 Wreal-q-constant
 Fortran Warning
 Warn about real-literal-constants with 'q' exponent-letter

This automatically will give you:

* Setting cpp_opts, even when using #pragma, -Werror= and complicated
combinations.

* Colors!

* Printing [-Wmissing-include-dirs] in the warning message.
>From gcc-bugs-return-461516-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org Tue Sep 09 21:47:35 2014
Return-Path: <gcc-bugs-return-461516-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Delivered-To: listarch-gcc-bugs@gcc.gnu.org
Received: (qmail 16520 invoked by alias); 9 Sep 2014 21:47:35 -0000
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
Delivered-To: mailing list gcc-bugs@gcc.gnu.org
Received: (qmail 16489 invoked by uid 48); 9 Sep 2014 21:47:31 -0000
From: "carrot at google dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/63156] web can't handle AUTOINC correctly
Date: Tue, 09 Sep 2014 21:47:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 5.0
X-Bugzilla-Keywords:
X-Bugzilla-Severity: normal
X-Bugzilla-Who: carrot at google dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: steven at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags:
X-Bugzilla-Changed-Fields:
Message-ID: <bug-63156-4-me4WZz2sj7@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-63156-4@http.gcc.gnu.org/bugzilla/>
References: <bug-63156-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-SW-Source: 2014-09/txt/msg01350.txt.bz2
Content-length: 684

https://gcc.gnu.org/bugzilla/show_bug.cgi?idc156

--- Comment #9 from Carrot <carrot at google dot com> ---
The original flag setting code is neither correct. Consider following
pre_modify expression:

(pre_modify (r1)                // def1, use1
            (plus (r1)          // use2
                  (r2)))        // use3

GCC will generate 4 df_ref information for this expression as noted, 1 def and
3 use. Current code only set DF_REF_READ_WRITE for def1, this causes web do
wrong renaming. The original flag setting code will set DF_REF_READ_WRITE for
all def/use in this expression, this is obviously wrong for r2.

I don't know if this has any relations to bug 32339.