public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/55541] [4.6/4.7/4.8 Regression] unable to see local variables due extra lexical block was generated
Date: Fri, 30 Nov 2012 13:04:00 -0000	[thread overview]
Message-ID: <bug-55541-4-VsNtJNZATw@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-55541-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55541

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at gcc dot gnu.org

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-11-30 13:03:40 UTC ---
I've tried to do:
--- gcc/cp/decl.c.jj    2012-11-19 14:41:16.000000000 +0100
+++ gcc/cp/decl.c    2012-11-30 12:24:42.255349700 +0100
@@ -13700,7 +13700,27 @@ finish_function (int flags)
     {
       /* Make it so that `main' always returns 0 by default.  */
       if (DECL_MAIN_P (current_function_decl))
-    finish_return_stmt (integer_zero_node);
+    {
+      /* If there is so far just a single statement, BIND_EXPR
+         with the whole main function body in it, push
+         return 0 stmt at the end of its body instead of after
+         the BIND_EXPR, so that variables declared in the function
+         scope are still in scope on the return stmt.  */
+      tree bind = NULL_TREE;
+      if (TREE_CODE (cur_stmt_list) == STATEMENT_LIST)
+        {
+          tree_stmt_iterator i = tsi_start (cur_stmt_list);
+          if (tsi_one_before_end_p (i)
+          && TREE_CODE (tsi_stmt (i)) == BIND_EXPR)
+        {
+          bind = tsi_stmt (i);
+          vec_safe_push (stmt_list_stack, BIND_EXPR_BODY (bind));
+        }
+        }
+      finish_return_stmt (integer_zero_node);
+      if (bind)
+        BIND_EXPR_BODY (bind) = stmt_list_stack->pop ();
+    }

       if (use_eh_spec_block (current_function_decl))
     finish_eh_spec_block (TYPE_RAISES_EXCEPTIONS

which makes sure that the return 0; has the right locus (for C99 similar change
would be needed), unfortunately it doesn't fix this.
Unlike C, the C++ FE creates an extra BLOCK around the BLOCK with BLOCK_VARS i
in this case, supposedly for the argument scope, so DECL_INITIAL
(current_function_decl) is in C the block with i var, but in C++ a block whose
BLOCK_SUBBLOCK is block with i var.  While the return stmt with the above patch
still has correct block, it seems to be actually completely ignored in the end,
because what matters actually is epilogue_location (in 4.7 and earlier
epilogue_locator).  cfgexpand.c and expand_function_end now set
epilogue_location to the input_location, when outside of particular stmt
expansion, which doesn't have a block, and I assume that DECL_INITIAL is then
used.  So the question is, can the C++ FE (when?) get rid of the outermost
BLOCK and change DECL_INITIAL (perhaps during genericization or so) to the real
function body scope instead.


  parent reply	other threads:[~2012-11-30 13:04 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-30  2:55 [Bug c++/55541] New: " chihin.ko at oracle dot com
2012-11-30  9:05 ` [Bug debug/55541] " paolo.carlini at oracle dot com
2012-11-30  9:22 ` [Bug debug/55541] [4.6/4.7/4.8 Regression] " rguenth at gcc dot gnu.org
2012-11-30 10:35 ` jakub at gcc dot gnu.org
2012-11-30 13:04 ` jakub at gcc dot gnu.org [this message]
2012-11-30 19:15 ` jason at gcc dot gnu.org
2012-12-05 16:24 ` jason at gcc dot gnu.org
2012-12-06 15:07 ` jakub at gcc dot gnu.org
2012-12-06 16:18 ` rguenth at gcc dot gnu.org
2013-04-12 15:15 ` [Bug debug/55541] [4.7/4.8/4.9 " jakub at gcc dot gnu.org
2014-06-12 13:42 ` [Bug debug/55541] [4.7/4.8/4.9/4.10 " rguenth at gcc dot gnu.org
2014-12-19 13:35 ` [Bug debug/55541] [4.8/4.9/5 " jakub at gcc dot gnu.org
2015-02-05 14:52 ` jakub at gcc dot gnu.org
2015-02-05 16:26 ` jakub at gcc dot gnu.org
2015-02-05 17:56 ` jakub at gcc dot gnu.org
2015-02-12 18:27 ` [Bug debug/55541] [4.8/4.9 " jakub at gcc dot gnu.org
2015-06-23  8:16 ` rguenth at gcc dot gnu.org
2015-06-26 20:04 ` [Bug debug/55541] [4.9 " jakub at gcc dot gnu.org
2015-06-26 20:34 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-55541-4-VsNtJNZATw@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).