[Bug sanitizer/55587] New: Testsuite test c-c++-common/asn/memcmp-1.c fails to link on targets without libasan/libsanitizer

[Bug sanitizer/55587] New: Testsuite test c-c++-common/asn/memcmp-1.c fails to link on targets without libasan/libsanitizer

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55587

             Bug #: 55587
           Summary: Testsuite test c-c++-common/asn/memcmp-1.c fails to
                    link on targets without libasan/libsanitizer
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: sanitizer
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: ktietz@gcc.gnu.org
                CC: dodji@gcc.gnu.org, dvyukov@gcc.gnu.org,
                    jakub@gcc.gnu.org, kcc@gcc.gnu.org
            Target: i686-*-mingw32 i686-*-cygwin


Due missing dependency library this test fails for none-linux targets.

[Bug testsuite/55587] [ASAN] Testsuite test c-c++-common/asan/memcmp-1.c fails to link on targets without libasan/libsanitizer

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55587

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-12-04
          Component|sanitizer                   |testsuite
            Summary|Testsuite test              |[ASAN] Testsuite test
                   |c-c++-common/asn/memcmp-1.c |c-c++-common/asan/memcmp-1.
                   |fails to link on targets    |c fails to link on targets
                   |without                     |without
                   |libasan/libsanitizer        |libasan/libsanitizer
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> 2012-12-04 09:33:22 UTC ---
Confirmed.  The testsuite misses something like dg-require asan.

[Bug testsuite/55587] [ASAN] Testsuite test c-c++-common/asan/memcmp-1.c fails to link on targets without libasan/libsanitizer

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55587

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-12-04 09:40:44 UTC ---
asan.exp starts with
if ![check_effective_target_faddress_sanitizer] {
  return
}
but that just checks whether -fsanitize=address works, not whether libasan has
been built.  That further check is in asan_init, guess we could return 0/1 from
asan_init on whether it found libasan and if it hasn't, don't call
gcc-dg-runtest.

[Bug testsuite/55587] [ASAN] Testsuite test c-c++-common/asan/memcmp-1.c fails to link on targets without libasan/libsanitizer

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55587

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-12-04 11:55:42 UTC ---
Created attachment 28875
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28875
gcc48-pr55587.patch

Does this patch work for you?  Worked for me in a quick testing (both with
libsanitizer around and without).

[Bug testsuite/55587] [ASAN] Testsuite test c-c++-common/asan/memcmp-1.c fails to link on targets without libasan/libsanitizer

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55587

--- Comment #4 from Kai Tietz <ktietz at gcc dot gnu.org> 2012-12-04 12:10:12 UTC ---
(In reply to comment #3)
> Created attachment 28875 [details]
> gcc48-pr55587.patch
> 
> Does this patch work for you?  Worked for me in a quick testing (both with
> libsanitizer around and without).

Yes, it works for me.  Thanks

[Bug testsuite/55587] [ASAN] Testsuite test c-c++-common/asan/memcmp-1.c fails to link on targets without libasan/libsanitizer

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55587

--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-12-04 13:21:31 UTC ---
Author: jakub
Date: Tue Dec  4 13:21:11 2012
New Revision: 194134

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194134
Log:
    PR testsuite/55587
    * lib/asan-dg.exp (asan_init): Return 1 if libasan has been found,
    0 if not.
    * g++.dg/asan/asan.exp: Don't run gcc-dg-runtest if [asan_init]
    returned 0.
    * gcc.dg/asan/asan.exp: Likewise.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/g++.dg/asan/asan.exp
    trunk/gcc/testsuite/gcc.dg/asan/asan.exp
    trunk/gcc/testsuite/lib/asan-dg.exp

[Bug testsuite/55587] [ASAN] Testsuite test c-c++-common/asan/memcmp-1.c fails to link on targets without libasan/libsanitizer

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55587

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-12-04 13:26:32 UTC ---
Fixed.

[Bug testsuite/55587] [ASAN] Testsuite test c-c++-common/asan/memcmp-1.c fails to link on targets without libasan/libsanitizer

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55587

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This patch is broken for testing the already installed GCC.