public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "egallager at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/55610] cc1 is calling munmap() on part of itself on darwin
Date: Mon, 20 Dec 2021 04:05:50 +0000 [thread overview]
Message-ID: <bug-55610-4-8nI1OMtQos@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-55610-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55610
--- Comment #12 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to CVS Commits from comment #11)
> The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:
>
> https://gcc.gnu.org/g:22a982409323feb203401d345488a5a9c18e6733
>
> commit r12-5759-g22a982409323feb203401d345488a5a9c18e6733
> Author: Iain Sandoe <iain@sandoe.co.uk>
> Date: Sat Nov 13 12:39:09 2021 +0000
>
> Darwin: Rewrite host PCH support [PR 55610].
>
> We need to revise the PCH memory allocation scheme to enable
> support for PIE on aarch64. The rewrite uses a similar scheme
> to the one used on Linux.
>
> We attempt to identify VM segments for each arch/OS version that
> are always available to the compiler (note this is not general,
> it only needs to work for the cc1* exes).
>
> If we cannot find the preferred segment we fall back to allowing
> the kernel to supply one - this is more likely to fail when the
> PCH read-in occurs (but that is trapped).
>
> In doing this we obviate the need to unmap any part of the
> compiler __DATA segment - thus fixing PR 55610.
>
> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
>
> gcc/ChangeLog:
>
> PR target/55610
> * config/host-darwin.c (TRY_EMPTY_VM_SPACE,
> SAFE_ALLOC_SIZE): New.
> (darwin_gt_pch_get_address): Rewrite to use nominated
> memory segments rather than part of the compiler __DATA
> segment.
> (darwin_gt_pch_use_address): Likewise.
So, ok to close this as FIXED now?
next prev parent reply other threads:[~2021-12-20 4:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 15:19 [Bug target/55610] New: " howarth at nitro dot med.uc.edu
2012-12-06 15:25 ` [Bug target/55610] " howarth at nitro dot med.uc.edu
2012-12-06 15:28 ` howarth at nitro dot med.uc.edu
2012-12-06 23:58 ` mrs at gcc dot gnu.org
2012-12-07 17:35 ` howarth at nitro dot med.uc.edu
2012-12-07 18:03 ` howarth at nitro dot med.uc.edu
2021-11-11 15:49 ` egallager at gcc dot gnu.org
2021-11-11 15:55 ` iains at gcc dot gnu.org
2021-12-02 19:45 ` cvs-commit at gcc dot gnu.org
2021-12-20 4:05 ` egallager at gcc dot gnu.org [this message]
2023-05-16 19:18 ` iains at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-55610-4-8nI1OMtQos@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).