[Bug c++/55632] New: trunk/gcc/cp/decl.c:10614: strange line of code

[Bug c++/55632] New: trunk/gcc/cp/decl.c:10614: strange line of code

[dcb314 at hotmail dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55632

             Bug #: 55632
           Summary: trunk/gcc/cp/decl.c:10614: strange line of code
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dcb314@hotmail.com


The line of code in question is

    /* Record presence of `static'.  */
    publicp = (ctype != NULL_TREE
           || storage_class == sc_extern
           || storage_class != sc_static);

This might be better as 

    /* Record presence of `static'.  */
    publicp = (ctype != NULL_TREE
           || storage_class != sc_static);

But then the code and the comment don't match up.
Suggest code rework.

[Bug c++/55632] trunk/gcc/cp/decl.c:10614: strange line of code

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55632

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2013-02-26
         AssignedTo|unassigned at gcc dot       |paolo.carlini at oracle dot
                   |gnu.org                     |com
     Ever Confirmed|0                           |1

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2013-02-26 10:32:20 UTC ---
Let's resolve this.

[Bug c++/55632] trunk/gcc/cp/decl.c:10614: strange line of code

[paolo at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55632

--- Comment #2 from paolo at gcc dot gnu.org <paolo at gcc dot gnu.org> 2013-02-26 14:04:59 UTC ---
Author: paolo
Date: Tue Feb 26 14:04:47 2013
New Revision: 196284

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196284
Log:
2013-02-26  David Binderman  <dcb314@hotmail.com>

    PR c++/55632
    * decl.c (grokdeclarator): Tidy publicp assignment.

Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl.c

[Bug c++/55632] trunk/gcc/cp/decl.c:10614: strange line of code

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55632

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.8.0

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> 2013-02-26 14:05:44 UTC ---
Done.