public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug fortran/55636] New: [4.8 Regression] Fortran name mangling collides with user namespace
@ 2012-12-10 0:39 dje at gcc dot gnu.org
2012-12-10 0:43 ` [Bug fortran/55636] " dje at gcc dot gnu.org
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: dje at gcc dot gnu.org @ 2012-12-10 0:39 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55636
Bug #: 55636
Summary: [4.8 Regression] Fortran name mangling collides with
user namespace
Classification: Unclassified
Product: gcc
Version: 4.8.0
Status: UNCONFIRMED
Severity: critical
Priority: P3
Component: fortran
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: dje@gcc.gnu.org
As reported in early October, a patch added name mangling to some additional
symbols. The mangling is wrong for a number of reasons:
1) It conflicts with naming used in some systems (AIX)
2) It does not obey NO_DOT_IN_LABEL
3) It does not use identifiers reserved to the system
A proposal to use "_F" prefix instead of "." was proposed and discussed, but
there has been no progress.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/55636] [4.8 Regression] Fortran name mangling collides with user namespace
2012-12-10 0:39 [Bug fortran/55636] New: [4.8 Regression] Fortran name mangling collides with user namespace dje at gcc dot gnu.org
@ 2012-12-10 0:43 ` dje at gcc dot gnu.org
2012-12-10 8:13 ` burnus at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: dje at gcc dot gnu.org @ 2012-12-10 0:43 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55636
David Edelsohn <dje at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |assemble-failure, build,
| |link-failure
CC| |burnus at gcc dot gnu.org,
| |janus at gcc dot gnu.org
Target Milestone|--- |4.8.0
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/55636] [4.8 Regression] Fortran name mangling collides with user namespace
2012-12-10 0:39 [Bug fortran/55636] New: [4.8 Regression] Fortran name mangling collides with user namespace dje at gcc dot gnu.org
2012-12-10 0:43 ` [Bug fortran/55636] " dje at gcc dot gnu.org
@ 2012-12-10 8:13 ` burnus at gcc dot gnu.org
2012-12-10 8:38 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-12-10 8:13 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55636
--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-10 08:12:39 UTC ---
See thread starting at http://gcc.gnu.org/ml/fortran/2012-10/msg00006.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/55636] [4.8 Regression] Fortran name mangling collides with user namespace
2012-12-10 0:39 [Bug fortran/55636] New: [4.8 Regression] Fortran name mangling collides with user namespace dje at gcc dot gnu.org
2012-12-10 0:43 ` [Bug fortran/55636] " dje at gcc dot gnu.org
2012-12-10 8:13 ` burnus at gcc dot gnu.org
@ 2012-12-10 8:38 ` rguenth at gcc dot gnu.org
2012-12-10 8:51 ` janus at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: rguenth at gcc dot gnu.org @ 2012-12-10 8:38 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55636
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Status|UNCONFIRMED |NEW
Last reconfirmed| |2012-12-10
Ever Confirmed|0 |1
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> 2012-12-10 08:38:08 UTC ---
P1 as it is a build failure.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/55636] [4.8 Regression] Fortran name mangling collides with user namespace
2012-12-10 0:39 [Bug fortran/55636] New: [4.8 Regression] Fortran name mangling collides with user namespace dje at gcc dot gnu.org
` (2 preceding siblings ...)
2012-12-10 8:38 ` rguenth at gcc dot gnu.org
@ 2012-12-10 8:51 ` janus at gcc dot gnu.org
2012-12-10 9:39 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: janus at gcc dot gnu.org @ 2012-12-10 8:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55636
--- Comment #3 from janus at gcc dot gnu.org 2012-12-10 08:51:19 UTC ---
A patch was posted here:
http://gcc.gnu.org/ml/fortran/2012-10/msg00028.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/55636] [4.8 Regression] Fortran name mangling collides with user namespace
2012-12-10 0:39 [Bug fortran/55636] New: [4.8 Regression] Fortran name mangling collides with user namespace dje at gcc dot gnu.org
` (3 preceding siblings ...)
2012-12-10 8:51 ` janus at gcc dot gnu.org
@ 2012-12-10 9:39 ` jakub at gcc dot gnu.org
2012-12-11 11:22 ` janus at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: jakub at gcc dot gnu.org @ 2012-12-10 9:39 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55636
--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2012-12-10 09:39:31 UTC ---
It could use something similar to what tree-emutls.c uses:
+#if !defined (NO_DOT_IN_LABEL)
+# define GFC_STRING_LENGTH_SEPARATOR "."
+#elif !defined (NO_DOLLAR_IN_LABEL)
+# define GFC_STRING_LENGTH_SEPARATOR "$"
+#else
+# define GFC_STRING_LENGTH_SEPARATOR "_"
+#endif
- if (sym->module)
+ if (sym->attr.save || sym->ns->proc_name->attr.flavor == FL_MODULE)
+ {
+ if (sym->module)
+ name = gfc_get_string ("_F" GFC_STRING_LENGTH_SEPARATOR
"%s_MOD_%s", sym->module, sym->name);
+ else
+ name = gfc_get_string ("_F" GFC_STRING_LENGTH_SEPARATOR "%s",
sym->name);
+ }
+ else if (sym->module)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/55636] [4.8 Regression] Fortran name mangling collides with user namespace
2012-12-10 0:39 [Bug fortran/55636] New: [4.8 Regression] Fortran name mangling collides with user namespace dje at gcc dot gnu.org
` (4 preceding siblings ...)
2012-12-10 9:39 ` jakub at gcc dot gnu.org
@ 2012-12-11 11:22 ` janus at gcc dot gnu.org
2012-12-19 9:21 ` burnus at gcc dot gnu.org
2012-12-19 9:28 ` burnus at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: janus at gcc dot gnu.org @ 2012-12-11 11:22 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55636
--- Comment #5 from janus at gcc dot gnu.org 2012-12-11 11:22:15 UTC ---
For completeness: The regression was apparently introduced by the following
revision ...
http://gcc.gnu.org/viewcvs?view=revision&revision=187472
Btw, how is it a build failure?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/55636] [4.8 Regression] Fortran name mangling collides with user namespace
2012-12-10 0:39 [Bug fortran/55636] New: [4.8 Regression] Fortran name mangling collides with user namespace dje at gcc dot gnu.org
` (5 preceding siblings ...)
2012-12-11 11:22 ` janus at gcc dot gnu.org
@ 2012-12-19 9:21 ` burnus at gcc dot gnu.org
2012-12-19 9:28 ` burnus at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-12-19 9:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55636
--- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-19 09:21:21 UTC ---
Author: burnus
Date: Wed Dec 19 09:21:17 2012
New Revision: 194604
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194604
Log:
2012-12-19 Tobias Burnus <burnus@net-b.de>
Jakub Jelinek <jakub@redhat.com>
Janus Weil <janus@gcc.gnu.org>
PR fortran/55636
PR fortran/55733
* gfortran.h (GFC_PREFIX): Define.
* trans-decl.c (gfc_create_string_length): For VAR_DECLs that
will be TREE_STATIC, use GFC_PREFIX to mangle the names. Handle
-fno-automatic
(gfc_trans_deferred_vars): Don't free variables SAVEd via
-fno-automatic.
2012-12-19 Tobias Burnus <burnus@net-b.de>
PR fortran/55733
* gfortran.dg/save_5.f90: New.
Added:
trunk/gcc/testsuite/gfortran.dg/save_5.f90
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/gfortran.h
trunk/gcc/fortran/trans-decl.c
trunk/gcc/testsuite/ChangeLog
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug fortran/55636] [4.8 Regression] Fortran name mangling collides with user namespace
2012-12-10 0:39 [Bug fortran/55636] New: [4.8 Regression] Fortran name mangling collides with user namespace dje at gcc dot gnu.org
` (6 preceding siblings ...)
2012-12-19 9:21 ` burnus at gcc dot gnu.org
@ 2012-12-19 9:28 ` burnus at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: burnus at gcc dot gnu.org @ 2012-12-19 9:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55636
Tobias Burnus <burnus at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #7 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-19 09:28:12 UTC ---
FIXED on the trunk (4.8).
The mangling now uses:
#if !defined (NO_DOT_IN_LABEL)
# define GFC_PREFIX(x) "_F." x
#elif !defined (NO_DOLLAR_IN_LABEL)
# define GFC_PREFIX(x) "_F$" x
#else
# define GFC_PREFIX(x) "_F_" x
#endif
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-12-19 9:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-10 0:39 [Bug fortran/55636] New: [4.8 Regression] Fortran name mangling collides with user namespace dje at gcc dot gnu.org
2012-12-10 0:43 ` [Bug fortran/55636] " dje at gcc dot gnu.org
2012-12-10 8:13 ` burnus at gcc dot gnu.org
2012-12-10 8:38 ` rguenth at gcc dot gnu.org
2012-12-10 8:51 ` janus at gcc dot gnu.org
2012-12-10 9:39 ` jakub at gcc dot gnu.org
2012-12-11 11:22 ` janus at gcc dot gnu.org
2012-12-19 9:21 ` burnus at gcc dot gnu.org
2012-12-19 9:28 ` burnus at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).