[Bug middle-end/55642] New: [4.8 Regression] Invalid thumb code generated ("thumb conditional instruction should be in IT block")

[Bug middle-end/55642] New: [4.8 Regression] Invalid thumb code generated ("thumb conditional instruction should be in IT block")

[Bernhard.Rosenkranzer at linaro dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55642

             Bug #: 55642
           Summary: [4.8 Regression] Invalid thumb code generated ("thumb
                    conditional instruction should be in IT block")
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: Bernhard.Rosenkranzer@linaro.org


Created attachment 28914
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28914
Test case (not yet reduced)

Building the attached preprocessed code with -std=gnu++11 -O2 -mthumb
-mcpu=cortex-a9 results in errors from the assembler:

[bero@localhost grouper-4.2.1-gcc-4.8 (master)]$
/opt/android-toolchain-trunk/bin/arm-linux-androideabi-g++ -std=gnu++11 -o
ARMAsmParser.o -O2 -mthumb  -mcpu=cortex-a9 -c ARMAsmParser.i 
/tmp/ccKYPdeC.s: Assembler messages:
/tmp/ccKYPdeC.s:7949: Error: thumb conditional instruction should be in IT
block -- `subne r2,r2,r3,asr#31'
/tmp/ccKYPdeC.s:21058: Error: thumb conditional instruction should be in IT
block -- `subne r2,r2,r3,asr#31'

[Bug target/55642] [4.8 Regression] Invalid thumb code generated ("thumb conditional instruction should be in IT block")

[pinskia at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55642

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |assemble-failure
   Target Milestone|---                         |4.8.0

[Bug target/55642] [4.8 Regression] Invalid thumb code generated ("thumb conditional instruction should be in IT block")

[kyrylo.tkachov at arm dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55642

--- Comment #1 from Kyrill Tkachov <kyrylo.tkachov at arm dot com> 2012-12-11 10:25:10 UTC ---
Created attachment 28924
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=28924
Reduced testcase

[Bug target/55642] [4.8 Regression] Invalid thumb code generated ("thumb conditional instruction should be in IT block")

[kyrylo.tkachov at arm dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55642

Kyrill Tkachov <kyrylo.tkachov at arm dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyrylo.tkachov at arm dot
                   |                            |com

--- Comment #2 from Kyrill Tkachov <kyrylo.tkachov at arm dot com> 2012-12-11 10:28:11 UTC ---
Regression introduced with r193724.

The abssi2 patterns in thumb2.md output two instructions but the enclosing it
block thinks it's only one and therefore has the wrong number of t's (it
instead of itt).

Currently testing a patch to fix this.

Thanks,
Kyrill

[Bug target/55642] [4.8 Regression] Invalid thumb code generated ("thumb conditional instruction should be in IT block")

[ktkachov at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55642

--- Comment #3 from ktkachov at gcc dot gnu.org 2012-12-11 14:17:33 UTC ---
Author: ktkachov
Date: Tue Dec 11 14:17:28 2012
New Revision: 194398

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194398
Log:
gcc/ChangeLog

2012-12-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

    PR target/55642
    * config/arm/thumb2.md (*thumb2_abssi2):
    Set ce_count attribute to 2.
    (*thumb2_neg_abssi2): Likewise.


gcc/testsuite/ChangeLog

2012-12-11  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
    PR target/55642
    * gcc.target/arm/pr55642.c: New testcase.

Added:
    trunk/gcc/testsuite/gcc.target/arm/pr55642.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/thumb2.md
    trunk/gcc/testsuite/ChangeLog

[Bug target/55642] [4.8 Regression] Invalid thumb code generated ("thumb conditional instruction should be in IT block")

[kyrylo.tkachov at arm dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55642

--- Comment #4 from Kyrill Tkachov <kyrylo.tkachov at arm dot com> 2012-12-11 14:20:57 UTC ---
Should be fixed in trunk now

[Bug target/55642] [4.8 Regression] Invalid thumb code generated ("thumb conditional instruction should be in IT block")

[kyrylo.tkachov at arm dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55642

--- Comment #5 from Kyrill Tkachov <kyrylo.tkachov at arm dot com> 2012-12-11 14:29:59 UTC ---
(In reply to comment #4)
> Should be fixed in trunk now

Can you please check that it works for you now?
http://gcc.gnu.org/viewcvs?view=revision&revision=194398

Thanks,
Kyrill

[Bug target/55642] [4.8 Regression] Invalid thumb code generated ("thumb conditional instruction should be in IT block")

[ktkachov at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55642

ktkachov at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
                 CC|                            |ktkachov at gcc dot gnu.org
         Resolution|                            |FIXED

--- Comment #6 from ktkachov at gcc dot gnu.org 2012-12-18 14:45:31 UTC ---
Fixed.