public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "hubicka at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/55683] [4.8 Regression] ICE in inline_call, at ipa-inline-transform.c:270
Date: Tue, 18 Dec 2012 17:16:00 -0000	[thread overview]
Message-ID: <bug-55683-4-4djNyfvYI7@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-55683-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55683

--- Comment #11 from Jan Hubicka <hubicka at gcc dot gnu.org> 2012-12-18 17:15:51 UTC ---
Created attachment 29001
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29001
proposed patch

OK,
we know the argument is constant
 <addr_expr 0x7ffff7585700
    type <pointer_type 0x7ffff75741f8
        type <record_type 0x7ffff7560f18 C sizes-gimplified addressable
needs-constructing type_1 type_5 BLK
            size <integer_cst 0x7ffff73f7e40 constant 128>
            unit size <integer_cst 0x7ffff73f7e60 constant 16>
            align 64 symtab 0 alias set 4 canonical type 0x7ffff7560f18 fields
<field_decl 0x7ffff755ca18 c2> context <translation_unit_decl 0x7ffff7410170
D.1>
            full-name "struct C"
            needs-constructor X() X(constX&) this=(X&) n_parents=0
use_template=0 interface-unknown
            pointer_to_this <pointer_type 0x7ffff75741f8> chain <type_decl
0x7ffff755aac8 C>>
        public unsigned DI
        size <integer_cst 0x7ffff73f7dc0 constant 64>
        unit size <integer_cst 0x7ffff73f7de0 constant 8>
        align 64 symtab 0 alias set -1 canonical type 0x7ffff75741f8>
    constant
    arg 0 <var_decl 0x7ffff755cda8 c type <record_type 0x7ffff7560f18 C>
        addressable used static tree_1 tree_3 decl_5 decl_6 BLK file t.C line
25 col 12 size <integer_cst 0x7ffff73f7e40 128> unit size <integer_cst
0x7ffff73f7e60 16>
        align 128 context <function_decl 0x7ffff7576900 bar>>>

ipa_get_indirect_edge_target used when we estimate effect of inlining goes into
path looking up the binfo based on constant

  if (TREE_CODE (t) != TREE_BINFO)
    { 
      tree binfo;
      binfo = gimple_extract_devirt_binfo_from_cst (t);
      if (!binfo)
        return NULL_TREE;
      binfo = get_binfo_at_offset (binfo, anc_offset, otr_type);
      if (!binfo)
        return NULL_TREE;
      return gimple_get_virt_method_for_binfo (token, binfo);
    }

this code is missing in try_make_edge_direct_virtual_call that is actually
responsible for devirtualizing.  I am testing the attached patch.

If I read this right, we should get the problem every time we devirtualize
based on static object.  I am surprised this do not trigger in
testsuite/bootstrap.

Honza


  parent reply	other threads:[~2012-12-18 17:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-14  8:56 [Bug tree-optimization/55683] New: " rguenth at gcc dot gnu.org
2012-12-14  8:57 ` [Bug tree-optimization/55683] " rguenth at gcc dot gnu.org
2012-12-14  8:59 ` rguenth at gcc dot gnu.org
2012-12-14  9:57 ` jakub at gcc dot gnu.org
2012-12-14 10:26 ` rguenth at gcc dot gnu.org
2012-12-14 10:31 ` jakub at gcc dot gnu.org
2012-12-14 10:43 ` rguenth at gcc dot gnu.org
2012-12-14 12:14 ` jamborm at gcc dot gnu.org
2012-12-16 11:58 ` rguenth at gcc dot gnu.org
2012-12-18 12:47 ` rguenth at gcc dot gnu.org
2012-12-18 13:40 ` hubicka at ucw dot cz
2012-12-18 16:40 ` hubicka at gcc dot gnu.org
2012-12-18 17:16 ` hubicka at gcc dot gnu.org [this message]
2012-12-19 11:42 ` hubicka at gcc dot gnu.org
2012-12-19 11:47 ` hubicka at gcc dot gnu.org
2012-12-19 15:28 ` rguenth at gcc dot gnu.org
2013-01-10 16:59 ` jamborm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-55683-4-4djNyfvYI7@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).