[Bug target/55701] New: Inline some instances of memset for ARM

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug target/55701] New: Inline some instances of memset for ARM
@ 2012-12-15  1:11 josh.m.conner at gmail dot com
  2014-06-10  7:34 ` [Bug target/55701] " ramana at gcc dot gnu.org
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: josh.m.conner at gmail dot com @ 2012-12-15  1:11 UTC (permalink / raw)
  To: gcc-bugs

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55701

             Bug #: 55701
           Summary: Inline some instances of memset for ARM
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: josh.m.conner@gmail.com

memset() is almost never inlined on ARM, even at -O3.  If the target is known
to be 4-byte aligned or greater, it will be inlined for 1, 2, or 4 byte
lengths.  If the target alignment is unknown, it will be inlined only for a
single byte.

I don't see this problem with similar builtins (memcpy, memmove, and memclear
(memset with a target value of zero)) - they all inline small cases.

It probably makes sense for memset to be inlined up to at least 16 bytes or so
in all cases.

When aligned, memcpy and memmove use a ldmia/stmia (load multiple/store
multiple) sequence to create fairly compact inline code.  We could consider
doing the same sort of optimization with memset, using stmia only.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/55701] Inline some instances of memset for ARM
  2012-12-15  1:11 [Bug target/55701] New: Inline some instances of memset for ARM josh.m.conner at gmail dot com
@ 2014-06-10  7:34 ` ramana at gcc dot gnu.org
  2014-07-21 12:24 ` amker at gcc dot gnu.org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ramana at gcc dot gnu.org @ 2014-06-10  7:34 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55701

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |amker at gcc dot gnu.org

--- Comment #2 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
https://gcc.gnu.org/ml/gcc-patches/2014-05/msg00182.html

Bin might have a patch that fixes this under review.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/55701] Inline some instances of memset for ARM
  2012-12-15  1:11 [Bug target/55701] New: Inline some instances of memset for ARM josh.m.conner at gmail dot com
  2014-06-10  7:34 ` [Bug target/55701] " ramana at gcc dot gnu.org
@ 2014-07-21 12:24 ` amker at gcc dot gnu.org
  2014-07-23 16:02 ` amker at gcc dot gnu.org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: amker at gcc dot gnu.org @ 2014-07-21 12:24 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55701

--- Comment #3 from amker at gcc dot gnu.org ---
Author: amker
Date: Mon Jul 21 12:24:06 2014
New Revision: 212893

URL: https://gcc.gnu.org/viewcvs?rev=212893&root=gcc&view=rev
Log:
    PR target/55701
    * config/arm/arm.md (setmem): New pattern.
    * config/arm/arm-protos.h (struct tune_params): New fields.
    (arm_gen_setmem): New prototype.
    * config/arm/arm.c (arm_slowmul_tune): Initialize new fields.
    (arm_fastmul_tune, arm_strongarm_tune, arm_xscale_tune): Ditto.
    (arm_9e_tune, arm_v6t2_tune, arm_cortex_tune): Ditto.
    (arm_cortex_a8_tune, arm_cortex_a7_tune): Ditto.
    (arm_cortex_a15_tune, arm_cortex_a53_tune): Ditto.
    (arm_cortex_a57_tune, arm_cortex_a5_tune): Ditto.
    (arm_cortex_a9_tune, arm_cortex_a12_tune): Ditto.
    (arm_v7m_tune, arm_v6m_tune, arm_fa726te_tune): Ditto.
    (arm_const_inline_cost): New function.
    (arm_block_set_max_insns): New function.
    (arm_block_set_non_vect_profit_p): New function.
    (arm_block_set_vect_profit_p): New function.
    (arm_block_set_unaligned_vect): New function.
    (arm_block_set_aligned_vect): New function.
    (arm_block_set_unaligned_non_vect): New function.
    (arm_block_set_aligned_non_vect): New function.
    (arm_block_set_vect, arm_gen_setmem): New functions.

    * gcc.target/arm/memset-inline-1.c: New test.
    * gcc.target/arm/memset-inline-2.c: New test.
    * gcc.target/arm/memset-inline-3.c: New test.
    * gcc.target/arm/memset-inline-4.c: New test.
    * gcc.target/arm/memset-inline-5.c: New test.
    * gcc.target/arm/memset-inline-6.c: New test.
    * gcc.target/arm/memset-inline-7.c: New test.
    * gcc.target/arm/memset-inline-8.c: New test.
    * gcc.target/arm/memset-inline-9.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-1.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-2.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-3.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-4.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-5.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-6.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-7.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-8.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-9.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm-protos.h
    trunk/gcc/config/arm/arm.c
    trunk/gcc/config/arm/arm.md
    trunk/gcc/testsuite/ChangeLog


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/55701] Inline some instances of memset for ARM
  2012-12-15  1:11 [Bug target/55701] New: Inline some instances of memset for ARM josh.m.conner at gmail dot com
  2014-06-10  7:34 ` [Bug target/55701] " ramana at gcc dot gnu.org
  2014-07-21 12:24 ` amker at gcc dot gnu.org
@ 2014-07-23 16:02 ` amker at gcc dot gnu.org
  2014-07-24 11:05 ` ramana at gcc dot gnu.org
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: amker at gcc dot gnu.org @ 2014-07-23 16:02 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55701

--- Comment #4 from amker at gcc dot gnu.org ---
Author: amker
Date: Wed Jul 23 16:02:15 2014
New Revision: 212948

URL: https://gcc.gnu.org/viewcvs?rev=212948&root=gcc&view=rev
Log:

    Revert r212893:
    PR target/55701
    * config/arm/arm.md (setmem): New pattern.
    * config/arm/arm-protos.h (struct tune_params): New fields.
    (arm_gen_setmem): New prototype.
    * config/arm/arm.c (arm_slowmul_tune): Initialize new fields.
    (arm_fastmul_tune, arm_strongarm_tune, arm_xscale_tune): Ditto.
    (arm_9e_tune, arm_v6t2_tune, arm_cortex_tune): Ditto.
    (arm_cortex_a8_tune, arm_cortex_a7_tune): Ditto.
    (arm_cortex_a15_tune, arm_cortex_a53_tune): Ditto.
    (arm_cortex_a57_tune, arm_cortex_a5_tune): Ditto.
    (arm_cortex_a9_tune, arm_cortex_a12_tune): Ditto.
    (arm_v7m_tune, arm_v6m_tune, arm_fa726te_tune): Ditto.
    (arm_const_inline_cost): New function.
    (arm_block_set_max_insns): New function.
    (arm_block_set_non_vect_profit_p): New function.
    (arm_block_set_vect_profit_p): New function.
    (arm_block_set_unaligned_vect): New function.
    (arm_block_set_aligned_vect): New function.
    (arm_block_set_unaligned_non_vect): New function.
    (arm_block_set_aligned_non_vect): New function.
    (arm_block_set_vect, arm_gen_setmem): New functions.

    PR target/55701
    * gcc.target/arm/memset-inline-1.c: New test.
    * gcc.target/arm/memset-inline-2.c: New test.
    * gcc.target/arm/memset-inline-3.c: New test.
    * gcc.target/arm/memset-inline-4.c: New test.
    * gcc.target/arm/memset-inline-5.c: New test.
    * gcc.target/arm/memset-inline-6.c: New test.
    * gcc.target/arm/memset-inline-7.c: New test.
    * gcc.target/arm/memset-inline-8.c: New test.
    * gcc.target/arm/memset-inline-9.c: New test.

    Revert r212892:
    * config/arm/arm.c (output_move_neon): Handle REG explicitly.


Removed:
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-1.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-2.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-3.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-4.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-5.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-6.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-7.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-8.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-9.c
Modified:
    trunk/gcc/config/arm/arm-protos.h
    trunk/gcc/config/arm/arm.c
    trunk/gcc/config/arm/arm.md


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/55701] Inline some instances of memset for ARM
  2012-12-15  1:11 [Bug target/55701] New: Inline some instances of memset for ARM josh.m.conner at gmail dot com
                   ` (2 preceding siblings ...)
  2014-07-23 16:02 ` amker at gcc dot gnu.org
@ 2014-07-24 11:05 ` ramana at gcc dot gnu.org
  2014-09-05  3:46 ` amker at gcc dot gnu.org
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: ramana at gcc dot gnu.org @ 2014-07-24 11:05 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55701

Ramana Radhakrishnan <ramana at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from Ramana Radhakrishnan <ramana at gcc dot gnu.org> ---
Changing state to assigned.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/55701] Inline some instances of memset for ARM
  2012-12-15  1:11 [Bug target/55701] New: Inline some instances of memset for ARM josh.m.conner at gmail dot com
                   ` (3 preceding siblings ...)
  2014-07-24 11:05 ` ramana at gcc dot gnu.org
@ 2014-09-05  3:46 ` amker at gcc dot gnu.org
  2015-02-16  6:02 ` amker at gcc dot gnu.org
  2015-02-17 11:09 ` rearnsha at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: amker at gcc dot gnu.org @ 2014-09-05  3:46 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55701

--- Comment #6 from amker at gcc dot gnu.org ---
Author: amker
Date: Fri Sep  5 03:45:57 2014
New Revision: 214937

URL: https://gcc.gnu.org/viewcvs?rev=214937&root=gcc&view=rev
Log:

    PR target/55701
    * config/arm/arm.md (setmem): New pattern.
    * config/arm/arm-protos.h (struct tune_params): New fields.
    (arm_gen_setmem): New prototype.
    * config/arm/arm.c (arm_slowmul_tune): Initialize new fields.
    (arm_fastmul_tune, arm_strongarm_tune, arm_xscale_tune): Ditto.
    (arm_9e_tune, arm_v6t2_tune, arm_cortex_tune): Ditto.
    (arm_cortex_a8_tune, arm_cortex_a7_tune): Ditto.
    (arm_cortex_a15_tune, arm_cortex_a53_tune): Ditto.
    (arm_cortex_a57_tune, arm_cortex_a5_tune): Ditto.
    (arm_cortex_a9_tune, arm_cortex_a12_tune): Ditto.
    (arm_v7m_tune, arm_v6m_tune, arm_fa726te_tune): Ditto.
    (arm_const_inline_cost): New function.
    (arm_block_set_max_insns): New function.
    (arm_block_set_non_vect_profit_p): New function.
    (arm_block_set_vect_profit_p): New function.
    (arm_block_set_unaligned_vect): New function.
    (arm_block_set_aligned_vect): New function.
    (arm_block_set_unaligned_non_vect): New function.
    (arm_block_set_aligned_non_vect): New function.
    (arm_block_set_vect, arm_gen_setmem): New functions.

    testsuite
    * gcc.target/arm/memset-inline-1.c: New test.
    * gcc.target/arm/memset-inline-2.c: New test.
    * gcc.target/arm/memset-inline-3.c: New test.
    * gcc.target/arm/memset-inline-4.c: New test.
    * gcc.target/arm/memset-inline-5.c: New test.
    * gcc.target/arm/memset-inline-6.c: New test.
    * gcc.target/arm/memset-inline-7.c: New test.
    * gcc.target/arm/memset-inline-8.c: New test.
    * gcc.target/arm/memset-inline-9.c: New test.
    * gcc.target/arm/memset-inline-10.c: New test.


Added:
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-1.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-10.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-2.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-3.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-4.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-5.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-6.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-7.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-8.c
    trunk/gcc/testsuite/gcc.target/arm/memset-inline-9.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/arm/arm-protos.h
    trunk/gcc/config/arm/arm.c
    trunk/gcc/config/arm/arm.md
    trunk/gcc/testsuite/ChangeLog


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/55701] Inline some instances of memset for ARM
  2012-12-15  1:11 [Bug target/55701] New: Inline some instances of memset for ARM josh.m.conner at gmail dot com
                   ` (4 preceding siblings ...)
  2014-09-05  3:46 ` amker at gcc dot gnu.org
@ 2015-02-16  6:02 ` amker at gcc dot gnu.org
  2015-02-17 11:09 ` rearnsha at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: amker at gcc dot gnu.org @ 2015-02-16  6:02 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55701

amker at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #7 from amker at gcc dot gnu.org ---
I suppose this is fixed?


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug target/55701] Inline some instances of memset for ARM
  2012-12-15  1:11 [Bug target/55701] New: Inline some instances of memset for ARM josh.m.conner at gmail dot com
                   ` (5 preceding siblings ...)
  2015-02-16  6:02 ` amker at gcc dot gnu.org
@ 2015-02-17 11:09 ` rearnsha at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: rearnsha at gcc dot gnu.org @ 2015-02-17 11:09 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55701

Richard Earnshaw <rearnsha at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |5.0


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-02-17 11:09 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-15  1:11 [Bug target/55701] New: Inline some instances of memset for ARM josh.m.conner at gmail dot com
2014-06-10  7:34 ` [Bug target/55701] " ramana at gcc dot gnu.org
2014-07-21 12:24 ` amker at gcc dot gnu.org
2014-07-23 16:02 ` amker at gcc dot gnu.org
2014-07-24 11:05 ` ramana at gcc dot gnu.org
2014-09-05  3:46 ` amker at gcc dot gnu.org
2015-02-16  6:02 ` amker at gcc dot gnu.org
2015-02-17 11:09 ` rearnsha at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).