[Bug c++/55728] New: std::bad_function_call has misleading what() result

[Bug c++/55728] New: std::bad_function_call has misleading what() result

[joerg.richter@pdv-fs.de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55728

             Bug #: 55728
           Summary: std::bad_function_call has misleading what() result
    Classification: Unclassified
           Product: gcc
           Version: 4.7.2
            Status: UNCONFIRMED
          Severity: minor
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: joerg.richter@pdv-fs.de


cat t.cc << EOF
#include <functional>
#include <iostream>

int main()
{
  try
  {
    std::function<void()>()();
  }
  catch( std::exception const& e )
  {
    std::cout << e.what() << std::endl;
  }
}
EOF

g++ -std=c++11 -o t t.cc
t

# gives me "std::exception"

Not wrong, but "std::bad_function_call" would have saved me some debug time.

[Bug libstdc++/55728] std::bad_function_call has misleading what() result

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55728

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-12-18
          Component|c++                         |libstdc++
     Ever Confirmed|0                           |1

[Bug libstdc++/55728] std::bad_function_call has misleading what() result

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55728

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2013-01-02 14:18:24 UTC ---
Maybe for consistency with bad_weak_ptr it should return "bad_function_call"
without the std:: qualification  (see Bug 55847)

[Bug libstdc++/55728] std::bad_function_call has misleading what() result

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55728

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paolo.carlini at oracle dot
                   |                            |com, redi at gcc dot
                   |                            |gnu.org

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2013-01-03 16:29:06 UTC ---
Jon, these two issues seem both straightforward to fix, right?

[Bug libstdc++/55728] std::bad_function_call has misleading what() result

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55728

--- Comment #3 from Jonathan Wakely <redi at gcc dot gnu.org> 2013-01-03 16:35:46 UTC ---
Yes, I would have done it already but was taking a break from writing any code
over xmas!

This one needs a new export from the lib, but that's OK, I bumped the version
to 6.0.18 recently anyway.

[Bug libstdc++/55728] std::bad_function_call has misleading what() result

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55728

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> 2013-01-03 16:59:38 UTC ---
Eh, eh, indeed. Are you willing to take care of it over the next couple of
weeks? Otherwise let me know, I can, but not now, I'm trying to catch up about
too many things at once.

[Bug libstdc++/55728] std::bad_function_call has misleading what() result

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55728

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |redi at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #5 from Jonathan Wakely <redi at gcc dot gnu.org> 2013-01-03 18:42:10 UTC ---
Sure, I think I've already done the work in a git branch so I'll revisit it
asap.

[Bug libstdc++/55728] std::bad_function_call has misleading what() result

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55728

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|paolo.carlini at oracle dot |
                   |com, redi at gcc dot        |
                   |gnu.org                     |

--- Comment #6 from Paolo Carlini <paolo.carlini at oracle dot com> 2013-01-03 19:04:23 UTC ---
Ah, thanks!

[Bug libstdc++/55728] std::bad_function_call has misleading what() result

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55728

--- Comment #7 from Jonathan Wakely <redi at gcc dot gnu.org> 2013-01-07 00:50:25 UTC ---
Author: redi
Date: Mon Jan  7 00:50:16 2013
New Revision: 194958

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194958
Log:
    PR libstdc++/55847
    * src/c++11/shared_ptr.cc (bad_weak_ptr::what()): Correct string.
    * testsuite/20_util/shared_ptr/cons/weak_ptr_expired.cc: Verify
    string.

    PR libstdc++/55728
    * include/std/functional (bad_function_call::what()): Declare.
    * src/c++11/functional.cc (bad_function_call::what()): Define.
    * config/abi/pre/gnu.ver (bad_function_call::what()): Export.
    * testsuite/20_util/bad_function_call/what.cc: New.

Added:
    trunk/libstdc++-v3/testsuite/20_util/bad_function_call/what.cc
      - copied, changed from r194957,
trunk/libstdc++-v3/testsuite/20_util/shared_ptr/cons/weak_ptr_expired.cc
Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/config/abi/pre/gnu.ver
    trunk/libstdc++-v3/include/std/functional
    trunk/libstdc++-v3/src/c++11/functional.cc
    trunk/libstdc++-v3/src/c++11/shared_ptr.cc
    trunk/libstdc++-v3/testsuite/20_util/shared_ptr/cons/weak_ptr_expired.cc

[Bug libstdc++/55728] std::bad_function_call has misleading what() result

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55728

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |4.8.0

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> 2013-01-07 00:53:26 UTC ---
fixed for 4.8