[Bug fortran/55733] New: -fno-automatic: Fails for scalar allocatables

[Bug fortran/55733] New: -fno-automatic: Fails for scalar allocatables

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55733

             Bug #: 55733
           Summary: -fno-automatic: Fails for scalar allocatables
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Keywords: wrong-code
          Severity: normal
          Priority: P3
         Component: fortran
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: burnus@gcc.gnu.org
                CC: janus@gcc.gnu.org


-fno-automatic implies SAVE. However, it doesn't work for scalar allocatables:


subroutine foo(i)
  integer :: i
  integer, allocatable :: j
  if (i == 1) j = 42
  if (.not. allocated (j)) call abort ()
  if (j /= 42) call abort ()
end

call foo(1)
call foo(2)
end

[Bug fortran/55733] -fno-automatic: Fails for scalar allocatables

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55733

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-18 15:20:40 UTC ---
*** Bug 55732 has been marked as a duplicate of this bug. ***

[Bug fortran/55733] -fno-automatic: Fails for scalar allocatables

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55733

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-18 15:24:16 UTC ---
The following test case also fails; I think the problem is the string
components which isn't marked as TREE_STATIC:

! { dg-do run }
! { dg-options "-fno-automatic" }
!
subroutine foo()
  logical, save :: first = .false.
  character(len=:), allocatable :: str(:)
  if (first) then
    if (allocated (str)) call abort ()
    str = ["ABCDEF", "ABCDEF" ]
  end if
  if (.not. allocated (str)) call abort ()
  if (len (str) /= 6) call abort ()
  if (any (str(:)(1:6) /= "ABCDEF")) call abort ()
end subroutine foo

call foo()
call foo()
end

[Bug fortran/55733] -fno-automatic: Fails for scalar allocatables

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55733

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-18 15:59:28 UTC ---
Maybe for BLOCK DATA something similar has to be done. Cf. PR 55735.

[Bug fortran/55733] -fno-automatic: Fails for scalar allocatables

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55733

--- Comment #4 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-19 09:21:20 UTC ---
Author: burnus
Date: Wed Dec 19 09:21:17 2012
New Revision: 194604

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194604
Log:
2012-12-19  Tobias Burnus  <burnus@net-b.de>
            Jakub Jelinek  <jakub@redhat.com>
            Janus Weil  <janus@gcc.gnu.org>

        PR fortran/55636
        PR fortran/55733
        * gfortran.h (GFC_PREFIX): Define.
        * trans-decl.c (gfc_create_string_length): For VAR_DECLs that
        will be TREE_STATIC, use GFC_PREFIX to mangle the names. Handle
        -fno-automatic
        (gfc_trans_deferred_vars): Don't free variables SAVEd via
        -fno-automatic.

2012-12-19  Tobias Burnus  <burnus@net-b.de>

        PR fortran/55733
        * gfortran.dg/save_5.f90: New.


Added:
    trunk/gcc/testsuite/gfortran.dg/save_5.f90
Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/gfortran.h
    trunk/gcc/fortran/trans-decl.c
    trunk/gcc/testsuite/ChangeLog

[Bug fortran/55733] -fno-automatic: Fails for scalar allocatables

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55733

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #5 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-19 09:26:46 UTC ---
FIXED on the trunk (4.8).

[Bug fortran/55733] -fno-automatic: Fails for scalar allocatables

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55733

--- Comment #6 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-19 23:05:54 UTC ---
Author: burnus
Date: Wed Dec 19 23:05:49 2012
New Revision: 194621

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194621
Log:
2012-12-19  Tobias Burnus  <burnus@net-b.de>

        PR fortran/55733
        * trans-decl.c (gfc_create_string_length): Avoid setting
        TREE_STATIC for automatic variables with -fno-automatic.


Modified:
    trunk/gcc/fortran/ChangeLog
    trunk/gcc/fortran/trans-decl.c