From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8592 invoked by alias); 19 Dec 2012 15:08:17 -0000 Received: (qmail 8403 invoked by uid 55); 19 Dec 2012 15:07:55 -0000 From: "tejohnson at google dot com" To: gcc-bugs@gcc.gnu.org Subject: [Bug gcov-profile/55734] [4.8 Regression] gcov-io.c uses builtins not available in non-GCC compilers Date: Wed, 19 Dec 2012 15:08:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: gcov-profile X-Bugzilla-Keywords: build X-Bugzilla-Severity: blocker X-Bugzilla-Who: tejohnson at google dot com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 4.8.0 X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-bugs-owner@gcc.gnu.org X-SW-Source: 2012-12/txt/msg01885.txt.bz2 http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55734 --- Comment #16 from Teresa Johnson 2012-12-19 15:07:54 UTC --- On Wed, Dec 19, 2012 at 5:07 AM, rguenth at gcc dot gnu.org wrote: > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55734 > > --- Comment #15 from Richard Biener 2012-12-19 13:07:01 UTC --- > (In reply to comment #14) >> (In reply to comment #10) >> > Ah yes, now I remember. Yes, there is a problem with libgcov.a. I >> > wasn't seeing it because I was only building cc1. You are correct >> > Teresa, that is the reason for the gymnastics in my original patch. >> > >> > houston:/build/trunkboot/gcc$ nm libgcov.a |grep popc >> > U popcount_hwi >> > >> > I will let you and Richard sort it out :). >> >> libgcov should be built by stage1 gcc already and thus has the builtins >> available. > > To be more explicit - use #if IN_LIBGCOV to guard __builtin_popcountll vs. > popcount_hwi. Ah, yes, this fact escaped me and makes things much simpler. Running the regression tests right now, will send patch as soon as they finish... Thanks, Teresa > > -- > Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email > ------- You are receiving this mail because: ------- > You are on the CC list for the bug. -- Teresa Johnson | Software Engineer | tejohnson@google.com | 408-460-2413