public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc Date: Thu, 20 Dec 2012 12:59:00 -0000 [thread overview] Message-ID: <bug-55741-4-CXHw0WGMII@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-55741-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741 --- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-12-20 12:59:08 UTC --- (In reply to comment #5) > (In reply to comment #4) > > The point of http://gcc.gnu.org/viewcvs?view=revision&revision=193769 was that > > std::this_thread::sleep_for() is always available, even without > > --enable-libstdcxx-time=yes, so the default configuration needs to bootstrap. > > Well, patch has one issue about used type. Sleep expects 'unsigned long' as > argument. Ah thanks, I didn't know what type DWORD is. > Rest of suggested patch works. Great, thanks. So if I change the type to unsigned long and commit it, can I say you tested it? I don't like committing changes I can't test myself! Or if you want to commit it then it's pre-approved by me. > The reason I mentioned --enable > option is that nanosleep isn't detected proper by configure test in case that > nanosleep is a function provided by POSIX-library pthread. This is the same on all platforms. I would like to revisit that for GCC 4.9 but for 4.8 I just want std::this_thread::sleep_for() to work, even if it uses a low resolution sleep function. The __sleep_for function is in the .so and takes units of seconds and nanoseconds, so if we enable nanosleep automatically in 4.9 then code compiled with 4.8 and linked to libstdc++.so from 4.9 will get the nanosleep-capable version of __sleep_for() without needing to be recompiled.
next prev parent reply other threads:[~2012-12-20 12:59 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-12-19 15:22 [Bug bootstrap/55741] New: " rainer@emrich-ebersheim.de 2012-12-19 15:51 ` [Bug libstdc++/55741] " redi at gcc dot gnu.org 2012-12-19 20:36 ` redi at gcc dot gnu.org 2012-12-20 8:33 ` ktietz at gcc dot gnu.org 2012-12-20 11:46 ` redi at gcc dot gnu.org 2012-12-20 12:12 ` ktietz at gcc dot gnu.org 2012-12-20 12:59 ` redi at gcc dot gnu.org [this message] 2012-12-20 13:05 ` ktietz at gcc dot gnu.org 2012-12-20 14:19 ` redi at gcc dot gnu.org 2012-12-20 14:37 ` redi at gcc dot gnu.org 2012-12-20 14:38 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-55741-4-CXHw0WGMII@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).