[Bug bootstrap/55741] New: [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[Bug bootstrap/55741] New: [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[rainer@emrich-ebersheim.de]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

             Bug #: 55741
           Summary: [4.8 Regression] bootstrap fails in
                    libstdc++-v3/src/c++11/thread.cc
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: bootstrap
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: rainer@emrich-ebersheim.de


Bootstrap fails in libstdc++-v3/src/c++11/thread.cc: #  error "No sleep
function known for this target" 

Making all in c++11
make[3]: Entering directory
`/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/x86_64-w64-mingw32/libstdc++-v3/src/c++11'
/bin/sh ../../libtool --tag CXX --tag disable-shared   --mode=compile
/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/./gcc/xgcc -shared-libgcc
-B/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/./gcc -nostdinc++
-L/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/x86_64-w64-mingw32/libstdc++-v3/src
-L/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/x86_64-w64-mingw32/libstdc++-v3/src/.libs
-L/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/lib
-L/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/mingw/lib
-isystem
/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/include
-isystem
/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/mingw/include
-B/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/bin/
-B/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/lib/
-isystem
/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/include
-isystem
/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/sys-include
   -I/SCRATCH/tmp.NRXIamkeKl/src/gcc-4.8.0/libstdc++-v3/../libgcc
-I/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/x86_64-w64-mingw32/libstdc++-v3/include/x86_64-w64-mingw32
-I/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/x86_64-w64-mingw32/libstdc++-v3/include
-I/SCRATCH/tmp.NRXIamkeKl/src/gcc-4.8.0/libstdc++-v3/libsupc++  -std=gnu++11
-prefer-pic -D_GLIBCXX_SHARED -fno-implicit-templates -Wall -Wextra
-Wwrite-strings -Wcast-qual -Wabi  -fdiagnostics-show-location=once  
-ffunction-sections -fdata-sections  -frandom-seed=thread.lo -g -O2  -c -o
thread.lo ../../../../../../src/gcc-4.8.0/libstdc++-v3/src/c++11/thread.cc
libtool: compile:  /SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/./gcc/xgcc
-shared-libgcc -B/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/./gcc -nostdinc++
-L/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/x86_64-w64-mingw32/libstdc++-v3/src
-L/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/x86_64-w64-mingw32/libstdc++-v3/src/.libs
-L/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/lib
-L/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/mingw/lib
-isystem
/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/include
-isystem
/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/mingw/include
-B/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/bin/
-B/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/lib/
-isystem
/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/include
-isystem
/opt/devel/gnu/gcc/MINGW_NT/x86_64-w64-mingw32/mingw-w64-runtime-trunk-svn/gcc-4.8.0/x86_64-w64-mingw32/sys-include
-I/SCRATCH/tmp.NRXIamkeKl/src/gcc-4.8.0/libstdc++-v3/../libgcc
-I/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/x86_64-w64-mingw32/libstdc++-v3/include/x86_64-w64-mingw32
-I/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/x86_64-w64-mingw32/libstdc++-v3/include
-I/SCRATCH/tmp.NRXIamkeKl/src/gcc-4.8.0/libstdc++-v3/libsupc++ -std=gnu++11
-D_GLIBCXX_SHARED -fno-implicit-templates -Wall -Wextra -Wwrite-strings
-Wcast-qual -Wabi -fdiagnostics-show-location=once -ffunction-sections
-fdata-sections -frandom-seed=thread.lo -g -O2 -c
../../../../../../src/gcc-4.8.0/libstdc++-v3/src/c++11/thread.cc -o thread.o
../../../../../../src/gcc-4.8.0/libstdc++-v3/src/c++11/thread.cc:65:4: error:
#error "No sleep function known for this target"
 #  error "No sleep function known for this target"
    ^
../../../../../../src/gcc-4.8.0/libstdc++-v3/src/c++11/thread.cc:164:3:
warning: unused parameter '__s' [-Wunused-parameter]
   __sleep_for(chrono::seconds __s, chrono::nanoseconds __ns)
   ^
../../../../../../src/gcc-4.8.0/libstdc++-v3/src/c++11/thread.cc:164:3:
warning: unused parameter '__ns' [-Wunused-parameter]
make[3]: *** [thread.lo] Error 1
make[3]: Leaving directory
`/SCRATCH/tmp.NRXIamkeKl/gcc-4.8.0/gcc-4.8.0/x86_64-w64-mingw32/libstdc++-v3/src/c++11'

[Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2012-12-19
          Component|bootstrap                   |libstdc++
     Ever Confirmed|0                           |1

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-12-19 15:51:25 UTC ---
I've been expecting this error ... someone needs to provide an implementation
of __sleep_for that works on mingw, maybe using the Sleep() function or
whatever alternative to ::sleep() and ::usleep() exists on that platform.

[Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

--- Comment #2 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-12-19 20:35:46 UTC ---
Created attachment 29009
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29009
check for and use Sleep()

Does this patch work?

[Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

Kai Tietz <ktietz at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktietz at gcc dot gnu.org

--- Comment #3 from Kai Tietz <ktietz at gcc dot gnu.org> 2012-12-20 08:33:06 UTC ---
Well, this is caused by the issue that configure doesn't detect nanosleep/sleep
without using libwinthread.a library.  To solve this issue please use option
'--enable-libstdcxx-time=yes', that should solve your issue.
As this option is only valid for mingw-targets, if threading-model is 'posix',
the check in aclocal.m4 needs some extensions.

[Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-12-20 11:45:56 UTC ---
The point of http://gcc.gnu.org/viewcvs?view=revision&revision=193769 was that
std::this_thread::sleep_for() is always available, even without
--enable-libstdcxx-time=yes, so the default configuration needs to bootstrap.

[Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

--- Comment #5 from Kai Tietz <ktietz at gcc dot gnu.org> 2012-12-20 12:11:43 UTC ---
(In reply to comment #4)
> The point of http://gcc.gnu.org/viewcvs?view=revision&revision=193769 was that
> std::this_thread::sleep_for() is always available, even without
> --enable-libstdcxx-time=yes, so the default configuration needs to bootstrap.

Well, patch has one issue about used type.  Sleep expects 'unsigned long' as
argument.  Rest of suggested patch works.  The reason I mentioned --enable
option is that nanosleep isn't detected proper by configure test in case that
nanosleep is a function provided by POSIX-library pthread.
Nevertheless the hole thread-layer of cxx is one mingw just available together
with POSIX-library - and libwinpthread provides a cancel-able variant of
nanosleep.

[Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

--- Comment #6 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-12-20 12:59:08 UTC ---
(In reply to comment #5)
> (In reply to comment #4)
> > The point of http://gcc.gnu.org/viewcvs?view=revision&revision=193769 was that
> > std::this_thread::sleep_for() is always available, even without
> > --enable-libstdcxx-time=yes, so the default configuration needs to bootstrap.
> 
> Well, patch has one issue about used type.  Sleep expects 'unsigned long' as
> argument. 

Ah thanks, I didn't know what type DWORD is.

> Rest of suggested patch works.

Great, thanks. So if I change the type to unsigned long and commit it, can I
say you tested it?  I don't like committing changes I can't test myself!  Or if
you want to commit it then it's pre-approved by me.

>  The reason I mentioned --enable
> option is that nanosleep isn't detected proper by configure test in case that
> nanosleep is a function provided by POSIX-library pthread.

This is the same on all platforms. I would like to revisit that for GCC 4.9 but
for 4.8 I just want std::this_thread::sleep_for() to work, even if it uses a
low resolution sleep function.  The __sleep_for function is in the .so and
takes units of seconds and nanoseconds, so if we enable nanosleep automatically
in 4.9 then code compiled with 4.8 and linked to libstdc++.so from 4.9 will get
the nanosleep-capable version of __sleep_for() without needing to be
recompiled.

[Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[ktietz at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

--- Comment #7 from Kai Tietz <ktietz at gcc dot gnu.org> 2012-12-20 13:05:35 UTC ---
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > The point of http://gcc.gnu.org/viewcvs?view=revision&revision=193769 was that
> > > std::this_thread::sleep_for() is always available, even without
> > > --enable-libstdcxx-time=yes, so the default configuration needs to bootstrap.
> > 
> > Well, patch has one issue about used type.  Sleep expects 'unsigned long' as
> > argument. 
> 
> Ah thanks, I didn't know what type DWORD is.
> 
> > Rest of suggested patch works.
> 
> Great, thanks. So if I change the type to unsigned long and commit it, can I
> say you tested it?  I don't like committing changes I can't test myself!  Or if
> you want to commit it then it's pre-approved by me.

It is tested by me, if you change Sleep's argument to 'unsigned long' type.  It
is approved by me.  Thanks.

> >  The reason I mentioned --enable
> > option is that nanosleep isn't detected proper by configure test in case that
> > nanosleep is a function provided by POSIX-library pthread.
> 
> This is the same on all platforms. I would like to revisit that for GCC 4.9 but
> for 4.8 I just want std::this_thread::sleep_for() to work, even if it uses a
> low resolution sleep function.  The __sleep_for function is in the .so and
> takes units of seconds and nanoseconds, so if we enable nanosleep automatically
> in 4.9 then code compiled with 4.8 and linked to libstdc++.so from 4.9 will get
> the nanosleep-capable version of __sleep_for() without needing to be
> recompiled.

Ok, looking forward to 4.9

[Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |redi at gcc dot gnu.org
                   |gnu.org                     |
   Target Milestone|---                         |4.8.0

[Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

--- Comment #8 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-12-20 14:37:03 UTC ---
Author: redi
Date: Thu Dec 20 14:36:56 2012
New Revision: 194635

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194635
Log:
    PR libstdc++/55741
    * acinclude.m4 (GLIBCXX_ENABLE_LIBSTDCXX_TIME): Check for Sleep.
    * config.h.in: Regenerate.
    * configure: Regenerate.
    * src/c++11/thread.cc (__sleep_for): Use Sleep if available.

Modified:
    trunk/libstdc++-v3/ChangeLog
    trunk/libstdc++-v3/acinclude.m4
    trunk/libstdc++-v3/config.h.in
    trunk/libstdc++-v3/configure
    trunk/libstdc++-v3/src/c++11/thread.cc

[Bug libstdc++/55741] [4.8 Regression] bootstrap fails in libstdc++-v3/src/c++11/thread.cc

[redi at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55741

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Jonathan Wakely <redi at gcc dot gnu.org> 2012-12-20 14:37:49 UTC ---
should be fixed