public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/55755] New: Invalid VIEW_CONVERT_EXPR produced by SRA
@ 2012-12-20 14:22 jamborm at gcc dot gnu.org
2012-12-20 14:28 ` [Bug tree-optimization/55755] " jamborm at gcc dot gnu.org
` (5 more replies)
0 siblings, 6 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2012-12-20 14:22 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55755
Bug #: 55755
Summary: Invalid VIEW_CONVERT_EXPR produced by SRA
Classification: Unclassified
Product: gcc
Version: 4.8.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: tree-optimization
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: jamborm@gcc.gnu.org
Sigh. Even after all those years I can still occasionally come up with
an ICEing SRA testcase (it's basically a slightly modified
/home/mjambor/gcc/mine/src/gcc/testsuite/gcc.dg/torture/pr47228.c).
To be run with -O only, fails on x86_64-linux trunk, 4.7, and 4.6
(when checking is enabled):
/* { dg-do run } */
/* { dg-require-effective-target int32plus } */
struct S4
{
unsigned f0:24;
} __attribute__((__packed__));
struct S4 g_10 = {
6210831
};
struct S5
{
int i;
struct S4 l_8[2];
} __attribute__((__packed__));
int a, b;
struct S4 func_2 (int x)
{
struct S5 l = {
0,
{{0}, {0}}
};
l.i = a;
g_10 = l.l_8[1];
for (; x<2; x++) {
struct S4 tmp = {
11936567
};
l.l_8[x] = tmp;
}
b = l.i;
return g_10;
}
int main (void)
{
func_2 (0);
return 0;
}
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55755] Invalid VIEW_CONVERT_EXPR produced by SRA
2012-12-20 14:22 [Bug tree-optimization/55755] New: Invalid VIEW_CONVERT_EXPR produced by SRA jamborm at gcc dot gnu.org
@ 2012-12-20 14:28 ` jamborm at gcc dot gnu.org
2013-01-04 13:03 ` jamborm at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2012-12-20 14:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55755
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Last reconfirmed| |2012-12-20
AssignedTo|unassigned at gcc dot |jamborm at gcc dot gnu.org
|gnu.org |
Ever Confirmed|0 |1
--- Comment #1 from Martin Jambor <jamborm at gcc dot gnu.org> 2012-12-20 14:28:07 UTC ---
Obviously mine. The fix for release branches is probably going to be
add !access->grp_unscalarizable_region test to most to a few
access_has_children_p tests. The proper fix is to re-work
access_has_children_p to a predicate returning true if there are any
replacements in any of its children. But let me audit the
access_has_children_p tests first.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55755] Invalid VIEW_CONVERT_EXPR produced by SRA
2012-12-20 14:22 [Bug tree-optimization/55755] New: Invalid VIEW_CONVERT_EXPR produced by SRA jamborm at gcc dot gnu.org
2012-12-20 14:28 ` [Bug tree-optimization/55755] " jamborm at gcc dot gnu.org
@ 2013-01-04 13:03 ` jamborm at gcc dot gnu.org
2013-01-04 13:21 ` jamborm at gcc dot gnu.org
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2013-01-04 13:03 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55755
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |http://gcc.gnu.org/ml/gcc-p
| |atches/2013-01/msg00132.htm
| |l
--- Comment #2 from Martin Jambor <jamborm at gcc dot gnu.org> 2013-01-04 13:02:51 UTC ---
Patch in the mailing list:
http://gcc.gnu.org/ml/gcc-patches/2013-01/msg00132.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55755] Invalid VIEW_CONVERT_EXPR produced by SRA
2012-12-20 14:22 [Bug tree-optimization/55755] New: Invalid VIEW_CONVERT_EXPR produced by SRA jamborm at gcc dot gnu.org
2012-12-20 14:28 ` [Bug tree-optimization/55755] " jamborm at gcc dot gnu.org
2013-01-04 13:03 ` jamborm at gcc dot gnu.org
@ 2013-01-04 13:21 ` jamborm at gcc dot gnu.org
2013-01-24 14:54 ` jamborm at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2013-01-04 13:21 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55755
--- Comment #3 from Martin Jambor <jamborm at gcc dot gnu.org> 2013-01-04 13:20:50 UTC ---
Author: jamborm
Date: Fri Jan 4 13:20:38 2013
New Revision: 194905
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194905
Log:
2013-01-04 Martin Jambor <mjambor@suse.cz>
PR tree-optimization/55755
* tree-sra.c (sra_modify_assign): Do not check that an access has no
children when trying to avoid producing a VIEW_CONVERT_EXPR.
testsuite/
* gcc.dg/torture/pr55755.c: New test.
* gcc.dg/tree-ssa/sra-13.c: Likewise.
* gcc.dg/tree-ssa/pr45144.c: Update.
Added:
trunk/gcc/testsuite/gcc.dg/torture/pr55755.c
trunk/gcc/testsuite/gcc.dg/tree-ssa/sra-13.c
Modified:
trunk/gcc/ChangeLog
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/gcc.dg/tree-ssa/pr45144.c
trunk/gcc/tree-sra.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55755] Invalid VIEW_CONVERT_EXPR produced by SRA
2012-12-20 14:22 [Bug tree-optimization/55755] New: Invalid VIEW_CONVERT_EXPR produced by SRA jamborm at gcc dot gnu.org
` (2 preceding siblings ...)
2013-01-04 13:21 ` jamborm at gcc dot gnu.org
@ 2013-01-24 14:54 ` jamborm at gcc dot gnu.org
2013-01-24 15:41 ` jamborm at gcc dot gnu.org
2013-01-24 15:53 ` jamborm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2013-01-24 14:54 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55755
--- Comment #4 from Martin Jambor <jamborm at gcc dot gnu.org> 2013-01-24 14:54:02 UTC ---
Author: jamborm
Date: Thu Jan 24 14:53:56 2013
New Revision: 195425
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195425
Log:
2013-01-24 Martin Jambor <mjambor@suse.cz>
Backport from mainline
2013-01-04 Martin Jambor <mjambor@suse.cz>
PR tree-optimization/55755
* tree-sra.c (sra_modify_assign): Do not check that an access has no
children when trying to avoid producing a VIEW_CONVERT_EXPR.
testsuite/
* gcc.dg/torture/pr55755.c: New test.
* gcc.dg/tree-ssa/sra-13.c: Likewise.
* gcc.dg/tree-ssa/pr45144.c: Update.
Added:
branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/torture/pr55755.c
branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/tree-ssa/sra-13.c
Modified:
branches/gcc-4_7-branch/gcc/ChangeLog
branches/gcc-4_7-branch/gcc/testsuite/ChangeLog
branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/tree-ssa/pr45144.c
branches/gcc-4_7-branch/gcc/tree-sra.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55755] Invalid VIEW_CONVERT_EXPR produced by SRA
2012-12-20 14:22 [Bug tree-optimization/55755] New: Invalid VIEW_CONVERT_EXPR produced by SRA jamborm at gcc dot gnu.org
` (3 preceding siblings ...)
2013-01-24 14:54 ` jamborm at gcc dot gnu.org
@ 2013-01-24 15:41 ` jamborm at gcc dot gnu.org
2013-01-24 15:53 ` jamborm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2013-01-24 15:41 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55755
--- Comment #5 from Martin Jambor <jamborm at gcc dot gnu.org> 2013-01-24 15:41:19 UTC ---
Author: jamborm
Date: Thu Jan 24 15:41:04 2013
New Revision: 195429
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195429
Log:
2013-01-24 Martin Jambor <mjambor@suse.cz>
Backport from mainline
2013-01-04 Martin Jambor <mjambor@suse.cz>
PR tree-optimization/55755
* tree-sra.c (sra_modify_assign): Do not check that an access has no
children when trying to avoid producing a VIEW_CONVERT_EXPR.
testsuite/
* gcc.dg/torture/pr55755.c: New test.
* gcc.dg/tree-ssa/sra-13.c: Likewise.
* gcc.dg/tree-ssa/pr45144.c: Update.
Added:
branches/gcc-4_6-branch/gcc/testsuite/gcc.dg/torture/pr55755.c
branches/gcc-4_6-branch/gcc/testsuite/gcc.dg/tree-ssa/sra-13.c
Modified:
branches/gcc-4_6-branch/gcc/ChangeLog
branches/gcc-4_6-branch/gcc/testsuite/ChangeLog
branches/gcc-4_6-branch/gcc/testsuite/gcc.dg/tree-ssa/pr45144.c
branches/gcc-4_6-branch/gcc/tree-sra.c
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Bug tree-optimization/55755] Invalid VIEW_CONVERT_EXPR produced by SRA
2012-12-20 14:22 [Bug tree-optimization/55755] New: Invalid VIEW_CONVERT_EXPR produced by SRA jamborm at gcc dot gnu.org
` (4 preceding siblings ...)
2013-01-24 15:41 ` jamborm at gcc dot gnu.org
@ 2013-01-24 15:53 ` jamborm at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: jamborm at gcc dot gnu.org @ 2013-01-24 15:53 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55755
Martin Jambor <jamborm at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #6 from Martin Jambor <jamborm at gcc dot gnu.org> 2013-01-24 15:52:56 UTC ---
Finally fixed everywhere.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-01-24 15:53 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-12-20 14:22 [Bug tree-optimization/55755] New: Invalid VIEW_CONVERT_EXPR produced by SRA jamborm at gcc dot gnu.org
2012-12-20 14:28 ` [Bug tree-optimization/55755] " jamborm at gcc dot gnu.org
2013-01-04 13:03 ` jamborm at gcc dot gnu.org
2013-01-04 13:21 ` jamborm at gcc dot gnu.org
2013-01-24 14:54 ` jamborm at gcc dot gnu.org
2013-01-24 15:41 ` jamborm at gcc dot gnu.org
2013-01-24 15:53 ` jamborm at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).