public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug bootstrap/55792] [4.8 Regression] Bad memory access with profiledbootstrap and LTO
Date: Mon, 14 Jan 2013 13:51:00 -0000	[thread overview]
Message-ID: <bug-55792-4-ER0fAsfqbC@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-55792-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55792

--- Comment #36 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-14 13:50:49 UTC ---
Or more conservative, dropping less locations:

Index: gcc/tree-inline.c
===================================================================
--- gcc/tree-inline.c   (revision 195144)
+++ gcc/tree-inline.c   (working copy)
@@ -5190,7 +5190,7 @@ tree_function_versioning (tree old_decl,
        replace_info = (*tree_map)[i];
        if (replace_info->replace_p)
          {
-           tree op = replace_info->new_tree;
+           tree op = unshare_expr_without_location (replace_info->new_tree);
            if (!replace_info->old_tree)
              {
                int i = replace_info->parm_num;
@@ -5199,18 +5199,10 @@ tree_function_versioning (tree old_decl,
                  i --;
                replace_info->old_tree = parm;
              }
-
-
-           STRIP_NOPS (op);
-
-           if (TREE_CODE (op) == VIEW_CONVERT_EXPR)
-             op = TREE_OPERAND (op, 0);
-
            gcc_assert (TREE_CODE (replace_info->old_tree) == PARM_DECL);
+
            init = setup_one_parameter (&id, replace_info->old_tree,
-                                       replace_info->new_tree, id.src_fn,
-                                       NULL,
-                                       &vars);
+                                       op, id.src_fn, NULL, &vars);
            if (init)
              init_stmts.safe_push (init);
          }


  parent reply	other threads:[~2013-01-14 13:51 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-22 18:05 [Bug bootstrap/55792] New: " hjl.tools at gmail dot com
2012-12-22 18:43 ` [Bug bootstrap/55792] " hjl.tools at gmail dot com
2012-12-22 20:13 ` hjl.tools at gmail dot com
2013-01-03 19:03 ` hjl.tools at gmail dot com
2013-01-04 23:58 ` hjl.tools at gmail dot com
2013-01-05 16:47 ` hjl.tools at gmail dot com
2013-01-05 17:21 ` hjl.tools at gmail dot com
2013-01-07 10:13 ` rguenth at gcc dot gnu.org
2013-01-07 15:41 ` hjl.tools at gmail dot com
2013-01-07 16:02 ` rguenth at gcc dot gnu.org
2013-01-07 16:03 ` [Bug bootstrap/55792] [4.8 Regression] " rguenth at gcc dot gnu.org
2013-01-07 17:55 ` dnovillo at gcc dot gnu.org
2013-01-07 22:14 ` hjl.tools at gmail dot com
2013-01-07 23:30 ` hjl.tools at gmail dot com
2013-01-08  1:20 ` hjl.tools at gmail dot com
2013-01-08 10:17 ` rguenth at gcc dot gnu.org
2013-01-08 17:13 ` hjl.tools at gmail dot com
2013-01-09  0:23 ` hjl.tools at gmail dot com
2013-01-09  9:32 ` rguenth at gcc dot gnu.org
2013-01-09 16:11 ` hjl.tools at gmail dot com
2013-01-09 17:13 ` hjl.tools at gmail dot com
2013-01-09 18:22 ` rguenth at gcc dot gnu.org
2013-01-09 18:38 ` hjl.tools at gmail dot com
2013-01-09 22:52 ` hjl.tools at gmail dot com
2013-01-10 11:30 ` rguenth at gcc dot gnu.org
2013-01-10 12:16 ` rguenth at gcc dot gnu.org
2013-01-10 13:43 ` rguenth at gcc dot gnu.org
2013-01-10 14:08 ` rguenth at gcc dot gnu.org
2013-01-10 14:12 ` rguenth at gcc dot gnu.org
2013-01-10 15:29 ` rguenth at gcc dot gnu.org
2013-01-10 15:35 ` rguenth at gcc dot gnu.org
2013-01-10 17:03 ` hjl.tools at gmail dot com
2013-01-10 19:36 ` hjl.tools at gmail dot com
2013-01-11 17:37 ` hubicka at ucw dot cz
2013-01-14 13:43 ` rguenth at gcc dot gnu.org
2013-01-14 13:50 ` rguenth at gcc dot gnu.org
2013-01-14 13:51 ` rguenth at gcc dot gnu.org [this message]
2013-01-15 14:32 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-55792-4-ER0fAsfqbC@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).