public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/55797] [4.8 Regression] ICE: verify_cgraph_node failed: edge has no corresponding call_stmt Date: Tue, 08 Jan 2013 14:25:00 -0000 [thread overview] Message-ID: <bug-55797-4-0oNPLqPPhT@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-55797-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55797 --- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-08 14:24:59 UTC --- Solution to put off recursive inlining through iteration: Index: ipa-inline.c =================================================================== --- ipa-inline.c (revision 195014) +++ ipa-inline.c (working copy) @@ -1951,7 +1951,9 @@ early_inline_small_functions (struct cgr if (!can_early_inline_edge_p (e)) continue; - if (cgraph_edge_recursive_p (e)) + if (cgraph_edge_recursive_p (e) + || !DECL_STRUCT_FUNCTION + (callee->symbol.decl)->always_inline_functions_inlined) { if (dump_file) fprintf (dump_file, " Not inlining: recursive call.\n"); as we process functions in DFS order any not already processed function is in a callgraph cycle. This doesn't fix the overzealeous inlining via the iteration for the testcase though as we still grow in calls quadratically (we never hit a direct recursive call when inlining the recursive sub-callgraph). That is, early inlining completely misses the graph topology hints (never inline a SCC entry edge, etc.)
next prev parent reply other threads:[~2013-01-08 14:25 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-12-23 11:04 [Bug middle-end/55797] New: " zsojka at seznam dot cz 2012-12-26 22:20 ` [Bug middle-end/55797] " pinskia at gcc dot gnu.org 2012-12-30 10:54 ` mpolacek at gcc dot gnu.org 2012-12-30 12:16 ` mpolacek at gcc dot gnu.org 2013-01-07 15:44 ` rguenth at gcc dot gnu.org 2013-01-08 13:51 ` rguenth at gcc dot gnu.org 2013-01-08 14:25 ` rguenth at gcc dot gnu.org [this message] 2013-01-23 13:29 ` hubicka at gcc dot gnu.org 2013-01-23 13:38 ` hubicka at gcc dot gnu.org 2013-01-23 13:49 ` jakub at gcc dot gnu.org 2013-01-23 13:57 ` hubicka at gcc dot gnu.org 2013-01-23 14:00 ` hubicka at gcc dot gnu.org 2013-01-23 14:20 ` hubicka at gcc dot gnu.org 2013-02-08 11:30 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-55797-4-0oNPLqPPhT@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).