From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-411531-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 5156 invoked by alias); 8 Jan 2013 13:51:45 -0000
Received: (qmail 5021 invoked by uid 48); 8 Jan 2013 13:51:00 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/55797] [4.8 Regression] ICE: verify_cgraph_node failed: edge has no corresponding call_stmt
Date: Tue, 08 Jan 2013 13:51:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: NEW
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.0
X-Bugzilla-Changed-Fields:
Message-ID: <bug-55797-4-48i5cWAkao@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-55797-4@http.gcc.gnu.org/bugzilla/>
References: <bug-55797-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2013-01/txt/msg00650.txt.bz2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55797

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-08 13:50:58 UTC ---
Eh, we do totally crazy (recursive) inlining here ...

struct section_info
{
  intrusive_ptr < section_info > parent;
};

struct file_info
{
  intrusive_ptr < file_info > parent;
  intrusive_ptr < section_info > switched_section;
};

so the simple

void
start_file (void)
{
  intrusive_ptr < file_info > parent;
}

creates and destroys the graph of file_info / section_info nodes
with the edges represented by intrusive_ptr's.

void start_file() ()
{
...
  <bb 2>:
  _5 = parent.px;
  if (_5 != 0B)
    goto <bb 3>;
  else
    goto <bb 1041> (<L3>);

  <bb 3>:
  _6 = &_5->switched_section;
  _7 = _6->px;
  if (_7 != 0B)
    goto <bb 4>;
  else
    goto <bb 6> (<L1>);

  <bb 4>:
  section_info::~section_info (_7);

  <bb 5>:
  operator delete (_7);
...
and 1000 calls follow.


I wonder why we need such high early-inlin-insns number and for lower we hit:

      else if ((n = num_calls (callee)) != 0
               && growth * (n + 1) > PARAM_VALUE (PARAM_EARLY_INLINING_INSNS))
        {
          if (dump_file)
            fprintf (dump_file, "  will not early inline: %s/%i->%s/%i, "
                     "growth %i exceeds --param early-inlining-insns "
                     "divided by number of calls\n",
                     xstrdup (cgraph_node_name (e->caller)), e->caller->uid,
                     xstrdup (cgraph_node_name (callee)), callee->uid,
                     growth);
          want_inline = false;
        }

of which I cannot make very much sense.  Why should the number of calls
in callee(!) times the growth matter?  Shouldn't this be the number
of times the caller calls callee?  And why even that?  We've gone completely
away from the "consider only if all calls can be inlined" way of early
inline operation!