[Bug libquadmath/55821] New: Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[Bug libquadmath/55821] New: Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[gerald at pfeifer dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55821

             Bug #: 55821
           Summary: Release tarballs (unconditionally) install
                    libquadmath.info when libquadmath is not supported
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libquadmath
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: gerald@pfeifer.com


On platforms that do not support libquadmath, GCC release tarballs
still install libquadmath.info.

This was reported to me for sparc64-unknown-freebsd* and
powerpc-unknown-freebsd*, I am pretty sure it applies to
all platforms that do not support libquadmath.

This applies to releases only, not for our weekly snapshots,
since (only) the former contain pre-built .info files.

Actual outcome: libquadmath.info is installed unconditionally.

Desired outcome: libquadmath.info is only installed where libquadmath
is support (as correctly done already by our weekls snapshots, though
not our releases).

[Bug libquadmath/55821] Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[burnus at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55821

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |burnus at gcc dot gnu.org

--- Comment #1 from Tobias Burnus <burnus at gcc dot gnu.org> 2012-12-28 10:21:13 UTC ---
Let me try to understand:

* The release tar balls contain the pre-build .info files of all front ends and
libraries.

* Building the source and running "make install" installs the compilers
including the .info of all build FEs/libraries but also unconditionally
libquadmath's .info file (if it is present), even on systems where libquadmath
itself has not been build.


Currently, libquadmath is always configured (unless --disable-libquadmath has
been used) and the configure script checks whether __float128 is available.
Only if it is, the library is build. It uses BUILD_LIBQUADMATH for that
purpose.

It seems as if libquadmath/Makefile.am has to be modified. However, that might
be not as simple, if one believes the comment:

...
endif BUILD_LIBQUADMATH

# Unconditionally override this target, so that automake's definition
# does not wrongly interfere.
libquadmath.info: $(STAMP_BUILD_INFO)

[Bug libquadmath/55821] Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[schwab@linux-m68k.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55821

--- Comment #2 from Andreas Schwab <schwab@linux-m68k.org> 2012-12-28 10:58:39 UTC ---
That override is only needed so that libquadmath.info is built in the build
directory instead of the source directory.  If you want to suppress installing
the info file don't set info_TEXINFOS.

[Bug libquadmath/55821] Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55821

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2014-10-08
                 CC|                            |fxcoudert at gcc dot gnu.org
     Ever confirmed|0                           |1

--- Comment #3 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Would this work? Gerald, can you try it?


Index: Makefile.am
===================================================================
--- Makefile.am    (revision 215645)
+++ Makefile.am    (working copy)
@@ -158,6 +158,8 @@ libquadmath.info: $(STAMP_BUILD_INFO)
 # the relative path from the current `Makefile.am' to `texinfo.tex'.
 TEXINFO_TEX   = ../gcc/doc/include/texinfo.tex

+if BUILD_LIBQUADMATH
+
 # Defines info, dvi, pdf and html targets
 MAKEINFOFLAGS = -I $(srcdir)/../gcc/doc/include
 info_TEXINFOS = libquadmath.texi
@@ -165,3 +167,5 @@ libquadmath_TEXINFOS = libquadmath-vers.

 libquadmath-vers.texi:
     echo "@set BUGURL $(REPORT_BUGS_TEXI)" > $@
+
+endif BUILD_LIBQUADMATH

[Bug libquadmath/55821] Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55821

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |https://gcc.gnu.org/ml/gcc-
                   |                            |patches/2014-10/msg00736.ht
                   |                            |ml

--- Comment #4 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Updated patch proposed:
https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00736.html

[Bug libquadmath/55821] Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55821

--- Comment #5 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Author: fxcoudert
Date: Thu Oct  9 07:40:39 2014
New Revision: 216027

URL: https://gcc.gnu.org/viewcvs?rev=216027&root=gcc&view=rev
Log:
    PR libquadmath/55821
    * Makefile.am: Conditionally define info_TEXINFOS and
    libquadmath_TEXINFOS.
    * Makefile.in: Regenerate.

Modified:
    trunk/libquadmath/ChangeLog
    trunk/libquadmath/Makefile.am
    trunk/libquadmath/Makefile.in

[Bug libquadmath/55821] Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55821

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |5.0

--- Comment #6 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Fixed on trunk

[Bug libquadmath/55821] Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[sandra at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55821

Sandra Loosemore <sandra at codesourcery dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandra at codesourcery dot com

--- Comment #7 from Sandra Loosemore <sandra at codesourcery dot com> ---
Trying to build an arm-none-linux-gnueabi cross from mainline head, I'm getting
this error now:

/scratch/sandra/arm-fsf/src/gcc-mainline/libquadmath/libquadmath.texi:369:
@include `libquadmath-vers.texi': No such file or directory.
/scratch/sandra/arm-fsf/src/gcc-mainline/libquadmath/libquadmath.texi:374:
warning: undefined flag: BUGURL.

Reverting the patch from r216027 makes it work again.

I don't see anything named BUILD_LIBQUADMATH coming out of configure, but in
config.log I do see:

BUILD_LIBQUADMATH_FALSE=''
BUILD_LIBQUADMATH_TRUE='#'

Are you sure that this patch was actually tested with a clean build directory
where libquadmath-vers.texi was not already present from a previous build?

[Bug libquadmath/55821] Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[sandra at codesourcery dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55821

--- Comment #9 from Sandra Loosemore <sandra at codesourcery dot com> ---
Yes, that patch (with regenerated Makefile.in) did the trick.  Thanks.

config.log says my configure line is:

$ /scratch/sandra/arm-fsf/src/gcc-mainline/libquadmath/configure --srcdir=/scr
atch/sandra/arm-fsf/src/gcc-mainline/libquadmath --cache-file=./config.cache
--e
nable-multilib --with-cross-host=i686-pc-linux-gnu --enable-threads
--disable-li
bmudflap --disable-libstdcxx-pch --with-gnu-as --with-gnu-ld --enable-shared
--e
nable-lto --enable-symvers=gnu --enable-__cxa_atexit --with-glibc-version=2.19
-
-disable-nls --prefix=/scratch/sandra/arm-fsf/install
--with-sysroot=/scratch/sa
ndra/arm-fsf/install/arm-none-linux-gnueabi/libc
--with-host-libstdcxx=-static-l
ibgcc -Wl,-Bstatic,-lstdc++,-Bdynamic -lm --enable-libgomp --enable-libitm
--ena
ble-libatomic --disable-libssp --enable-poison-system-directories
--with-build-t
ime-tools=/scratch/sandra/arm-fsf/install/arm-none-linux-gnueabi/bin
--enable-la
nguages=c,c++,fortran,lto --program-transform-name=s&^&arm-none-linux-gnueabi-& 
--disable-option-checking --with-target-subdir=arm-none-linux-gnueabi
--build=i6
86-pc-linux-gnu --host=arm-none-linux-gnueabi --target=arm-none-linux-gnueabi

[Bug libquadmath/55821] Release tarballs (unconditionally) install libquadmath.info when libquadmath is not supported

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55821

--- Comment #10 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
Author: fxcoudert
Date: Tue Oct 21 08:59:17 2014
New Revision: 216503

URL: https://gcc.gnu.org/viewcvs?rev=216503&root=gcc&view=rev
Log:
    PR libquadmath/55821
    * Makefile.am: Unconditionally define libquadmath_TEXINFOS.
    * Makefile.in: Regenerate.

Modified:
    trunk/libquadmath/ChangeLog
    trunk/libquadmath/Makefile.am
    trunk/libquadmath/Makefile.in