* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
@ 2013-01-05 16:37 ` danglin at gcc dot gnu.org
2013-01-05 18:59 ` danglin at gcc dot gnu.org
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: danglin at gcc dot gnu.org @ 2013-01-05 16:37 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
John David Anglin <danglin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|FAIL: |[4.8 Regression] FAIL:
|libgomp.fortran/omp_parse3. |libgomp.fortran/omp_parse3.
|f90 -O0 (test for excess |f90 -O0 (test for excess
|errors) |errors)
--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> 2013-01-05 16:37:02 UTC ---
Revision 194745 was OK.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
2013-01-05 16:37 ` [Bug driver/55884] [4.8 Regression] " danglin at gcc dot gnu.org
@ 2013-01-05 18:59 ` danglin at gcc dot gnu.org
2013-01-07 10:06 ` rguenth at gcc dot gnu.org
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: danglin at gcc dot gnu.org @ 2013-01-05 18:59 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
--- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> 2013-01-05 18:59:12 UTC ---
(In reply to comment #1)
> Revision 194745 was OK.
Correction: 194549 was OK.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
2013-01-05 16:37 ` [Bug driver/55884] [4.8 Regression] " danglin at gcc dot gnu.org
2013-01-05 18:59 ` danglin at gcc dot gnu.org
@ 2013-01-07 10:06 ` rguenth at gcc dot gnu.org
2013-01-07 12:51 ` jakub at gcc dot gnu.org
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-01-07 10:06 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.8.0
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
` (2 preceding siblings ...)
2013-01-07 10:06 ` rguenth at gcc dot gnu.org
@ 2013-01-07 12:51 ` jakub at gcc dot gnu.org
2013-01-07 16:09 ` dave.anglin at bell dot net
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-01-07 12:51 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |burnus at gcc dot gnu.org,
| |jakub at gcc dot gnu.org
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-07 12:50:56 UTC ---
Guess related to -fintrinsic-module-path.
In some spots it still has the right argument:
-fintrinsic-modules-path /test/gnu/gcc/objdir/hppa2.0w-hp-hpux11.11/./libgomp
but in other spots that argument is gone:
-fintrinsic-modules-path -B ...
thus -B is taken as -fintrinsic-modules-path argument and the original -B
argument is considered another source file.
Can you try perhaps:
--- libgomp/testsuite/libgomp.fortran/fortran.exp 2012-12-20
11:38:48.663282599 +0100
+++ libgomp/testsuite/libgomp.fortran/fortran.exp 2013-01-07
13:45:51.557361907 +0100
@@ -14,7 +14,7 @@ set quadmath_library_path "../libquadmat
dg-init
if { $blddir != "" } {
- lappend ALWAYS_CFLAGS "additional_flags=-fintrinsic-modules-path
${blddir}"
+ lappend ALWAYS_CFLAGS "additional_flags=-fintrinsic-modules-path${blddir}"
# Look for a static libgfortran first.
if [file exists "${blddir}/${lang_library_path}/libgfortran.a"] {
set lang_test_file "${lang_library_path}/libgfortran.a"
? Though, I'd say using Joined Separate for such named option is just wrong,
it is fine for single letter options like -B, -A, -D, -U etc., but for options
of this kind I think it would be much better if it was
fintrinsic-modules-path
Fortran RejectNegative Separate
Specify where to find the compiled intrinsic modules
fintrinsic-modules-path=
Fortran RejectNegative Joined
Specify where to find the compiled intrinsic modules
instead and handle OPT_fintrinsic_modules_path_ the same as
OPT_fintrinsic_modules_path. But given that the option has been added already
back in 2007, it is probably too late for that.
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
` (3 preceding siblings ...)
2013-01-07 12:51 ` jakub at gcc dot gnu.org
@ 2013-01-07 16:09 ` dave.anglin at bell dot net
2013-01-08 3:34 ` dave.anglin at bell dot net
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dave.anglin at bell dot net @ 2013-01-07 16:09 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
--- Comment #4 from dave.anglin at bell dot net 2013-01-07 16:09:14 UTC ---
On 1/7/2013 7:50 AM, jakub at gcc dot gnu.org wrote:
> Guess related to -fintrinsic-module-path.
Have being doing a regression search and it seems to be
pointing to this change. Seem to have to do a full bootstrap
to test. Sometimes test is unresolved.
Will try you your suggestion.
Dave
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
` (4 preceding siblings ...)
2013-01-07 16:09 ` dave.anglin at bell dot net
@ 2013-01-08 3:34 ` dave.anglin at bell dot net
2013-01-08 8:13 ` jakub at gcc dot gnu.org
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dave.anglin at bell dot net @ 2013-01-08 3:34 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
--- Comment #5 from dave.anglin at bell dot net 2013-01-08 03:34:15 UTC ---
With the patch, the tests are unresolved with r194997:
UNSUPPORTED: libgomp.fortran/omp_parse3.f90 -O0
UNSUPPORTED: libgomp.fortran/omp_parse3.f90 -O1
UNSUPPORTED: libgomp.fortran/omp_parse3.f90 -O2
UNSUPPORTED: libgomp.fortran/omp_parse3.f90 -O3 -fomit-frame-pointer
UNSUPPORTED: libgomp.fortran/omp_parse3.f90 -O3 -fomit-frame-pointer -
funroll-loops
UNSUPPORTED: libgomp.fortran/omp_parse3.f90 -O3 -fomit-frame-pointer -
funroll-all-loops -finline-functions
UNSUPPORTED: libgomp.fortran/omp_parse3.f90 -O3 -g
UNSUPPORTED: libgomp.fortran/omp_parse3.f90 -Os
I'm fairly certain that the tests passed before the -fintrinsic-
modules-path was added to fortran.exp.
On 7-Jan-13, at 7:50 AM, jakub at gcc dot gnu.org wrote:
> Can you try perhaps:
> --- libgomp/testsuite/libgomp.fortran/fortran.exp 2012-12-20
> 11:38:48.663282599 +0100
> +++ libgomp/testsuite/libgomp.fortran/fortran.exp 2013-01-07
> 13:45:51.557361907 +0100
> @@ -14,7 +14,7 @@ set quadmath_library_path "../libquadmat
> dg-init
>
> if { $blddir != "" } {
> - lappend ALWAYS_CFLAGS "additional_flags=-fintrinsic-modules-path
> ${blddir}"
> + lappend ALWAYS_CFLAGS "additional_flags=-fintrinsic-modules-path
> ${blddir}"
> # Look for a static libgfortran first.
> if [file exists "${blddir}/${lang_library_path}/libgfortran.a"] {
> set lang_test_file "${lang_library_path}/libgfortran.a"
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
` (5 preceding siblings ...)
2013-01-08 3:34 ` dave.anglin at bell dot net
@ 2013-01-08 8:13 ` jakub at gcc dot gnu.org
2013-01-08 15:30 ` dave.anglin at bell dot net
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-01-08 8:13 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-08 08:13:02 UTC ---
On HP-UX or Linux? The test is guarded with
! { dg-require-effective-target tls_runtime }
does the OS have assembly/linker and runtime TLS support?
Can you attach libgomp.log ?
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
` (6 preceding siblings ...)
2013-01-08 8:13 ` jakub at gcc dot gnu.org
@ 2013-01-08 15:30 ` dave.anglin at bell dot net
2013-01-09 4:16 ` dave.anglin at bell dot net
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dave.anglin at bell dot net @ 2013-01-08 15:30 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
--- Comment #7 from dave.anglin at bell dot net 2013-01-08 15:29:49 UTC ---
On 1/8/2013 3:13 AM, jakub at gcc dot gnu.org wrote:
> On HP-UX or Linux? The test is guarded with
> ! { dg-require-effective-target tls_runtime }
> does the OS have assembly/linker and runtime TLS support?
HP-UX. HP-UX uses emutls. Ii looks to me as this should provide
runtime support but there are some regressions in TLS support at the
moment (PR 54908). Thought this was specific to C++ but maybe
it affects check_effective_target_tls_runtime.
Test is ok on Linux.
> Can you attach libgomp.log ?
Have to do another build...
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
` (7 preceding siblings ...)
2013-01-08 15:30 ` dave.anglin at bell dot net
@ 2013-01-09 4:16 ` dave.anglin at bell dot net
2013-01-09 4:46 ` dave.anglin at bell dot net
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dave.anglin at bell dot net @ 2013-01-09 4:16 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
--- Comment #8 from dave.anglin at bell dot net 2013-01-09 04:16:22 UTC ---
On 8-Jan-13, at 10:29 AM, dave.anglin at bell dot net wrote:
>> Can you attach libgomp.log ?
> Have to do another build...
This time I ran the full libgomp testsuite and I'm back to the same
driver
error. I'm thinking the -fintrinsic-modules-path option needs and '='
and
that the tls_runtime check fails when I just run the fortran tests.
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
` (8 preceding siblings ...)
2013-01-09 4:16 ` dave.anglin at bell dot net
@ 2013-01-09 4:46 ` dave.anglin at bell dot net
2013-01-13 21:27 ` dave.anglin at bell dot net
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: dave.anglin at bell dot net @ 2013-01-09 4:46 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
--- Comment #9 from dave.anglin at bell dot net 2013-01-09 04:46:36 UTC ---
On 8-Jan-13, at 11:15 PM, John David Anglin wrote:
> I'm thinking the -fintrinsic-modules-path option needs and '=' and
> that the tls_runtime check fails when I just run the fortran tests.
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
` (9 preceding siblings ...)
2013-01-09 4:46 ` dave.anglin at bell dot net
@ 2013-01-13 21:27 ` dave.anglin at bell dot net
2013-01-16 16:20 ` burnus at gcc dot gnu.org
2013-01-16 16:36 ` jakub at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: dave.anglin at bell dot net @ 2013-01-13 21:27 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
--- Comment #10 from dave.anglin at bell dot net 2013-01-13 21:27:19 UTC ---
> Can you try perhaps:
> --- libgomp/testsuite/libgomp.fortran/fortran.exp 2012-12-20
> 11:38:48.663282599 +0100
> +++ libgomp/testsuite/libgomp.fortran/fortran.exp 2013-01-07
> 13:45:51.557361907 +0100
> @@ -14,7 +14,7 @@ set quadmath_library_path "../libquadmat
> dg-init
>
> if { $blddir != "" } {
> - lappend ALWAYS_CFLAGS "additional_flags=-fintrinsic-modules-path
> ${blddir}"
> + lappend ALWAYS_CFLAGS "additional_flags=-fintrinsic-modules-path
> ${blddir}"
> # Look for a static libgfortran first.
> if [file exists "${blddir}/${lang_library_path}/libgfortran.a"] {
> set lang_test_file "${lang_library_path}/libgfortran.a"
>
> ? Though, I'd say using Joined Separate for such named option is
> just wrong,
> it is fine for single letter options like -B, -A, -D, -U etc., but
> for options
> of this kind I think it would be much better if it was
> fintrinsic-modules-path
> Fortran RejectNegative Separate
> Specify where to find the compiled intrinsic modules
>
> fintrinsic-modules-path=
> Fortran RejectNegative Joined
> Specify where to find the compiled intrinsic modules
>
> instead and handle OPT_fintrinsic_modules_path_ the same as
> OPT_fintrinsic_modules_path. But given that the option has been
> added already
> back in 2007, it is probably too late for that.
With the attached change, the fortran libgomp testsuite runs without
errors.
Using a space to separate the option and its value still doesn't
work. Joining
option and value results in an unrecognizable option and all tests fail.
--
John David Anglin dave.anglin@bell.net
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
` (10 preceding siblings ...)
2013-01-13 21:27 ` dave.anglin at bell dot net
@ 2013-01-16 16:20 ` burnus at gcc dot gnu.org
2013-01-16 16:36 ` jakub at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: burnus at gcc dot gnu.org @ 2013-01-16 16:20 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
--- Comment #11 from Tobias Burnus <burnus at gcc dot gnu.org> 2013-01-16 16:19:42 UTC ---
Author: burnus
Date: Wed Jan 16 16:19:32 2013
New Revision: 195242
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195242
Log:
gcc/fortran/
2013-01-16 Jakub Jelinek <jakub@redhat.com>
Tobias Burnus <burnus@net-b.de>
PR driver/55884
* lang.opt (fintrinsic-modules-path): Don't accept Joined.
(fintrinsic-modules-path=): New.
* options.c (gfc_handle_option, gfc_get_option_string,
gfc_get_option_string): Handle the latter.
libgomp/
2013-01-16 Jakub Jelinek <jakub@redhat.com>
Tobias Burnus <burnus@net-b.de>
PR driver/55884
* testsuite/libgomp.fortran/fortran.exp: Use
-fintrinsic-modules-path= instead of
-fintrinsic-modules-path.
Modified:
trunk/gcc/fortran/ChangeLog
trunk/gcc/fortran/lang.opt
trunk/gcc/fortran/options.c
trunk/libgomp/ChangeLog
trunk/libgomp/testsuite/libgomp.fortran/fortran.exp
^ permalink raw reply [flat|nested] 14+ messages in thread* [Bug driver/55884] [4.8 Regression] FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors)
2013-01-05 16:30 [Bug driver/55884] New: FAIL: libgomp.fortran/omp_parse3.f90 -O0 (test for excess errors) danglin at gcc dot gnu.org
` (11 preceding siblings ...)
2013-01-16 16:20 ` burnus at gcc dot gnu.org
@ 2013-01-16 16:36 ` jakub at gcc dot gnu.org
12 siblings, 0 replies; 14+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-01-16 16:36 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55884
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
--- Comment #12 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-16 16:35:30 UTC ---
Assuming fixed.
^ permalink raw reply [flat|nested] 14+ messages in thread