[Bug c/55890] New: calling a builtin func through a cast triggers an ICE

[Bug c/55890] New: calling a builtin func through a cast triggers an ICE

[vapier at gentoo dot org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

             Bug #: 55890
           Summary: calling a builtin func through a cast triggers an ICE
    Classification: Unclassified
           Product: gcc
           Version: 4.7.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: vapier@gentoo.org
            Target: x86_64-linux-gnu


$ cat test.i
extern void *memmove(void *, void *, long unsigned int);
typedef int (*_TEST_fun_) ();
static _TEST_fun_ i = (_TEST_fun_) memmove;
main() { i(); }

$ gcc-4.7.2 -O1 -c test.i
test.i: In function ‘main’:
test.i:4:1: internal compiler error: Segmentation fault
Please submit a full bug report,
with preprocessed source if appropriate.

[Bug tree-optimization/55890] [4.7/4.8 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
           Keywords|                            |ice-on-invalid-code
   Last reconfirmed|                            |2013-01-07
          Component|c                           |tree-optimization
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1
            Summary|calling a builtin func      |[4.7/4.8 Regression]
                   |through a cast triggers an  |calling a builtin func
                   |ICE                         |through a cast triggers an
                   |                            |ICE
   Target Milestone|---                         |4.7.3

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-07 09:53:24 UTC ---
Confirmed.  Of course the testcase is somewhat "invalid".  Since GCC 4.7
we preserve the original function type that is in effect for performing the
call but we are able to still propagate the actual function decl to the
call stmt.  Code inspecting arguments based on the fact the called function
is a builtin decl needs additional verification now ...

Mine.

[Bug tree-optimization/55890] [4.7/4.8 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-07 10:03:30 UTC ---
Created attachment 29094
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29094
prototype patch

For example fixed with something like the following.

Of course it's always going to produce some GIGO in builtins analyzing code
this way.  So the other fix would be to verify that for a builtin call
the number of actual arguments matches the ones required for the builtin
(though types also can differ ...).

Quite some amount of code to audit against these things - I suppose we might
decide to simply deal with this during next stage1 ...

[Bug tree-optimization/55890] [4.7/4.8 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-07 11:21:44 UTC ---
Other testcase:

extern void *memmove();
main() { memmove(); }

also fails with GCC 4.6, 4.5 but not 4.4 or older.

[Bug tree-optimization/55890] [4.7/4.8 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-07 12:07:14 UTC ---
Created attachment 29096
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29096
alternative patch

This verifies call arguments in gimple_call_builtin_p and adds a new overload
suitable for replacing

  if ((fndecl = gimple_call_fndecl (stmt))
      && DECL_BUILT_IN_CLASS (fndecl) == BUILT_IN_NORMAL)
   switch (DECL_FUNCTION_CODE (fndecl))
     ...

with

  if (gimple_call_builtin_p (stmt, BUILT_IN_NORMAL))
   switch (DECL_FUNCTION_CODE (gimple_call_fndecl (stmt)))
     ...

[Bug tree-optimization/55890] [4.7/4.8 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-07 15:34:48 UTC ---
Author: rguenth
Date: Mon Jan  7 15:34:43 2013
New Revision: 194975

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=194975
Log:
2013-01-07  Richard Biener  <rguenther@suse.de>

    PR middle-end/55890
    * gimple.h (gimple_call_builtin_p): New overload.
    * gimple.c (validate_call): New function.
    (gimple_call_builtin_p): Likewise.
    * tree-ssa-structalias.c (find_func_aliases_for_builtin_call):
    Use gimple_call_builtin_p.
    (find_func_clobbers): Likewise.
    * tree-ssa-strlen.c (adjust_last_stmt): Likewise.
    (strlen_optimize_stmt): Likewise.

    * gcc.dg/torture/pr55890-1.c: New testcase.
    * gcc.dg/torture/pr55890-2.c: Likewise.

Added:
    trunk/gcc/testsuite/gcc.dg/torture/pr55890-1.c
    trunk/gcc/testsuite/gcc.dg/torture/pr55890-2.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/gimple.c
    trunk/gcc/gimple.h
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-strlen.c
    trunk/gcc/tree-ssa-structalias.c

[Bug tree-optimization/55890] [4.7 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |4.8.0
            Summary|[4.7/4.8 Regression]        |[4.7 Regression] calling a
                   |calling a builtin func      |builtin func through a cast
                   |through a cast triggers an  |triggers an ICE
                   |ICE                         |

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-07 15:36:06 UTC ---
Fixed on trunk for the testcase(s) in question.

[Bug tree-optimization/55890] [4.7 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

[Bug tree-optimization/55890] [4.7 Regression] calling a builtin func through a cast triggers an ICE

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-08 08:38:58 UTC ---
Author: jakub
Date: Tue Jan  8 08:38:50 2013
New Revision: 195008

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195008
Log:
    PR middle-end/55890
    * tree-ssa-ccp.c (evaluate_stmt): Use gimple_call_builtin_p.

    * gcc.dg/torture/pr55890-3.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/torture/pr55890-3.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/tree-ssa-ccp.c

[Bug tree-optimization/55890] [4.7 Regression] calling a builtin func through a cast triggers an ICE

[vries at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

--- Comment #8 from vries at gcc dot gnu.org 2013-01-11 23:39:30 UTC ---
Author: vries
Date: Fri Jan 11 23:39:18 2013
New Revision: 195119

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195119
Log:
2013-01-12  Tom de Vries  <tom@codesourcery.com>

    PR middle-end/55890
    * calls.c (expand_call): Check if arg_nr is valid.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/calls.c

[Bug tree-optimization/55890] [4.7 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> 2013-02-04 12:04:41 UTC ---
Author: rguenth
Date: Mon Feb  4 12:04:35 2013
New Revision: 195708

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195708
Log:
2013-02-04  Richard Biener  <rguenther@suse.de>

    Backport from mainline
    2012-07-04  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/53844
    * tree-ssa-dse.c (dse_possible_dead_store_p): Properly handle
    the loop virtual PHI.

    * g++.dg/tree-ssa/pr53844.C: New testcase.

    2012-12-13  Richard Biener  <rguenther@suse.de>

    PR lto/55660
    * tree-streamer.c (record_common_node): Check that we are not
    recursively pre-loading nodes we want to skip.  Handle
    char_type_node appearing as part of va_list_type_node.

    * gcc.dg/lto/pr55660_0.c: New testcase.
    * gcc.dg/lto/pr55660_1.c: Likewise.

2013-02-04  Richard Biener  <rguenther@suse.de>

    PR middle-end/55890
    * gimple.h (gimple_call_builtin_class_p): New function.
    * gimple.c (validate_call): New function.
    (gimple_call_builtin_class_p): Likewise.
    * tree-ssa-structalias.c (find_func_aliases_for_builtin_call):
    Use gimple_call_builtin_class_p.
    (find_func_clobbers): Likewise.
    * tree-ssa-strlen.c (adjust_last_stmt): Likewise.
    (strlen_optimize_stmt): Likewise.

    * gcc.dg/torture/pr55890-1.c: New testcase.
    * gcc.dg/torture/pr55890-2.c: Likewise.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/g++.dg/tree-ssa/pr53844.C
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/lto/pr55660_0.c
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/lto/pr55660_1.c
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/torture/pr55890-1.c
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/torture/pr55890-2.c
Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/gimple.c
    branches/gcc-4_7-branch/gcc/gimple.h
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_7-branch/gcc/tree-ssa-dse.c
    branches/gcc-4_7-branch/gcc/tree-ssa-strlen.c
    branches/gcc-4_7-branch/gcc/tree-ssa-structalias.c
    branches/gcc-4_7-branch/gcc/tree-streamer.c

[Bug tree-optimization/55890] [4.7 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> 2013-02-04 12:08:17 UTC ---
Initial patch now backported, avoiding the C++ function overloading by
using gimple_call_builtin_class_p.

[Bug tree-optimization/55890] [4.7 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> 2013-02-04 15:49:29 UTC ---
Author: rguenth
Date: Mon Feb  4 15:49:18 2013
New Revision: 195718

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195718
Log:
2013-02-04  Richard Biener  <rguenther@suse.de>

    Backport from mainline
    2012-01-11  Richard Guenther  <rguenther@suse.de>

    PR tree-optimization/44061
    * tree-vrp.c (extract_range_basic): Compute zero as
    value-range for __builtin_constant_p of function parameters.

    * gcc.dg/pr44061.c: New testcase.

    2013-01-08  Jakub Jelinek  <jakub@redhat.com>

    PR middle-end/55890
    * tree-ssa-ccp.c (evaluate_stmt): Use gimple_call_builtin_class_p.

    * gcc.dg/torture/pr55890-3.c: New test.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/pr44061.c
    branches/gcc-4_7-branch/gcc/testsuite/gcc.dg/torture/pr55890-3.c
Modified:
    branches/gcc-4_7-branch/gcc/ChangeLog
    branches/gcc-4_7-branch/gcc/testsuite/ChangeLog
    branches/gcc-4_7-branch/gcc/tree-ssa-ccp.c
    branches/gcc-4_7-branch/gcc/tree-vrp.c

[Bug tree-optimization/55890] [4.7 Regression] calling a builtin func through a cast triggers an ICE

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55890

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Known to work|                            |4.7.3
         Resolution|                            |FIXED

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> 2013-02-04 15:50:53 UTC ---
Fixed.  The calls.c hunk doesn't apply anywhere and did not come with a
testcase.