* [Bug bootstrap/55961] [4.8 Regression] system.h includes gmp.h but system.h is included for build and not just target
2013-01-13 13:21 [Bug other/55961] New: gcc/system.h:639:17: fatal error: gmp.h: No such file or directory denis.onischenko at gmail dot com
@ 2013-01-13 18:56 ` pinskia at gcc dot gnu.org
2013-01-14 13:17 ` rguenth at gcc dot gnu.org
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: pinskia at gcc dot gnu.org @ 2013-01-13 18:56 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55961
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Keywords| |build
Last reconfirmed| |2013-01-13
Component|other |bootstrap
Ever Confirmed|0 |1
Summary|gcc/system.h:639:17: fatal |[4.8 Regression] system.h
|error: gmp.h: No such file |includes gmp.h but system.h
|or directory |is included for build and
| |not just target
Target Milestone|--- |4.8.0
Severity|normal |blocker
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> 2013-01-13 18:56:30 UTC ---
Basically a candian cross will fail if you don't have gmp.h installed on the
build machine.
system.h includes gmp.h but system.h is included for build and not just target
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug bootstrap/55961] [4.8 Regression] system.h includes gmp.h but system.h is included for build and not just target
2013-01-13 13:21 [Bug other/55961] New: gcc/system.h:639:17: fatal error: gmp.h: No such file or directory denis.onischenko at gmail dot com
2013-01-13 18:56 ` [Bug bootstrap/55961] [4.8 Regression] system.h includes gmp.h but system.h is included for build and not just target pinskia at gcc dot gnu.org
@ 2013-01-14 13:17 ` rguenth at gcc dot gnu.org
2013-01-14 16:06 ` joseph at codesourcery dot com
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-01-14 13:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55961
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rguenth at gcc dot gnu.org
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-14 13:16:40 UTC ---
Btw, previously we'd have #ifndef GENERATOR_FILE around gmp.h includes. I
didn't see the point of this, but if it's not really required there we
can re-instantiate it. Not sure if it's a good idea to change effective
system.h behavior though - system.h is included in configure tests. I
doubt we "properly" separate tests for build vs. host. Do we?
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug bootstrap/55961] [4.8 Regression] system.h includes gmp.h but system.h is included for build and not just target
2013-01-13 13:21 [Bug other/55961] New: gcc/system.h:639:17: fatal error: gmp.h: No such file or directory denis.onischenko at gmail dot com
2013-01-13 18:56 ` [Bug bootstrap/55961] [4.8 Regression] system.h includes gmp.h but system.h is included for build and not just target pinskia at gcc dot gnu.org
2013-01-14 13:17 ` rguenth at gcc dot gnu.org
@ 2013-01-14 16:06 ` joseph at codesourcery dot com
2013-01-15 13:05 ` rguenth at gcc dot gnu.org
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: joseph at codesourcery dot com @ 2013-01-14 16:06 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55961
--- Comment #3 from joseph at codesourcery dot com <joseph at codesourcery dot com> 2013-01-14 16:05:48 UTC ---
We run configure for the build system in a subdirectory, when build !=
host.
# auto-host.h is the file containing items generated by autoconf and is
# the first file included by config.h.
# If host=build, it is correct to have bconfig include auto-host.h
# as well. If host!=build, we are in error and need to do more
# work to find out the build config parameters.
if test x$host = x$build
then
build_auto=auto-host.h
else
# We create a subdir, then run autoconf in the subdir.
# To prevent recursion we set host and build for the new
# invocation of configure to the build for this invocation
# of configure.
[...]
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug bootstrap/55961] [4.8 Regression] system.h includes gmp.h but system.h is included for build and not just target
2013-01-13 13:21 [Bug other/55961] New: gcc/system.h:639:17: fatal error: gmp.h: No such file or directory denis.onischenko at gmail dot com
` (2 preceding siblings ...)
2013-01-14 16:06 ` joseph at codesourcery dot com
@ 2013-01-15 13:05 ` rguenth at gcc dot gnu.org
2013-01-15 15:54 ` rguenth at gcc dot gnu.org
2013-01-15 15:54 ` rguenth at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-01-15 13:05 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55961
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Status|NEW |ASSIGNED
AssignedTo|unassigned at gcc dot |rguenth at gcc dot gnu.org
|gnu.org |
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-15 13:05:23 UTC ---
Index: gcc/system.h
===================================================================
--- gcc/system.h (revision 195194)
+++ gcc/system.h (working copy)
@@ -636,7 +636,10 @@ extern int vsnprintf(char *, size_t, con
#include <dlfcn.h>
#endif
+/* Do not introduce a gmp.h dependency on the build system. */
+#ifndef GENERATOR_FILE
#include <gmp.h>
+#endif
/* Get libiberty declarations. */
#include "libiberty.h"
should restore previous behavior. I'm not sure if any configure check
for the build system includes system.h and does _not_ define GENERATOR_FILE.
So, does the build configury define GENERATOR_FILE?
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug bootstrap/55961] [4.8 Regression] system.h includes gmp.h but system.h is included for build and not just target
2013-01-13 13:21 [Bug other/55961] New: gcc/system.h:639:17: fatal error: gmp.h: No such file or directory denis.onischenko at gmail dot com
` (3 preceding siblings ...)
2013-01-15 13:05 ` rguenth at gcc dot gnu.org
@ 2013-01-15 15:54 ` rguenth at gcc dot gnu.org
2013-01-15 15:54 ` rguenth at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-01-15 15:54 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55961
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-15 15:54:10 UTC ---
Author: rguenth
Date: Tue Jan 15 15:54:05 2013
New Revision: 195205
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195205
Log:
2013-01-15 Richard Biener <rguenther@suse.de>
PR bootstrap/55961
* system.h: Do not include gmp.h for building host tools.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/system.h
^ permalink raw reply [flat|nested] 7+ messages in thread* [Bug bootstrap/55961] [4.8 Regression] system.h includes gmp.h but system.h is included for build and not just target
2013-01-13 13:21 [Bug other/55961] New: gcc/system.h:639:17: fatal error: gmp.h: No such file or directory denis.onischenko at gmail dot com
` (4 preceding siblings ...)
2013-01-15 15:54 ` rguenth at gcc dot gnu.org
@ 2013-01-15 15:54 ` rguenth at gcc dot gnu.org
5 siblings, 0 replies; 7+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-01-15 15:54 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55961
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-15 15:54:38 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 7+ messages in thread