public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "kcc at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug sanitizer/55975] asan does not work with 46 bit address space on PowerPC64 Date: Wed, 23 Jan 2013 13:50:00 -0000 [thread overview] Message-ID: <bug-55975-4-qz8N1RBnT6@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-55975-4@http.gcc.gnu.org/bugzilla/> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55975 --- Comment #34 from Kostya Serebryany <kcc at gcc dot gnu.org> 2013-01-23 13:50:31 UTC --- > Do you really want to make kHighMemEnd dynamic always? Shouldn't it be dynamic > only when needed (i.e. for configurations like ppc64 which now require it)? If we make this dynamic on PPC and constant elsewhere, we risk breaking PPC frequently because we typically don't test on PPC (we don't even have a bot!). We can easily introduce a change that will assume kHighMemEnd is a constant. > Otherwise it will slow down many of the inlines that use this heavily. Hopefully, not that bad. unless an application is malloc-bound, we don't enter asan-rt too often. If it is malloc-bound, we are in trouble anyway, because the allocator is very expensive in all other parts. > Furthermore, in configurations where kHighMemEnd is dynamic, also IMHO all > asan_mapping.h defines that are based on it should also be global variables > to avoid unnecessary runtime computations everywhere. > I mean kHighMemBeg, kHighShadowBeg, kHighShadowEnd, kShadowGapEnd. Hm... I would not change that w/o some proof (benchmarks results). When e.g. we access two of these variables, we will be doing two loads instead of one load and arithmetic. Not a clear choice.
next prev parent reply other threads:[~2013-01-23 13:50 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-14 19:15 [Bug sanitizer/55975] New: FAIL: c-c++-common/asan/global-overflow-1.c -O0 output pattern test schwab@linux-m68k.org 2013-01-15 6:12 ` [Bug sanitizer/55975] " kcc at gcc dot gnu.org 2013-01-15 20:00 ` schwab@linux-m68k.org 2013-01-16 10:01 ` kcc at gcc dot gnu.org 2013-01-16 10:14 ` kcc at gcc dot gnu.org 2013-01-16 10:38 ` jakub at gcc dot gnu.org 2013-01-16 11:47 ` [Bug sanitizer/55975] asan does not work with 46 bit address space on PowerPC64 kcc at gcc dot gnu.org 2013-01-16 11:51 ` jakub at gcc dot gnu.org 2013-01-16 11:54 ` kcc at gcc dot gnu.org 2013-01-16 19:12 ` schwab@linux-m68k.org 2013-01-17 8:30 ` kcc at gcc dot gnu.org 2013-01-17 23:24 ` schwab@linux-m68k.org 2013-01-17 23:52 ` schwab@linux-m68k.org 2013-01-18 8:20 ` jakub at gcc dot gnu.org 2013-01-18 8:26 ` kcc at gcc dot gnu.org 2013-01-18 11:41 ` kcc at gcc dot gnu.org 2013-01-18 12:30 ` kcc at gcc dot gnu.org 2013-01-18 13:03 ` jakub at gcc dot gnu.org 2013-01-18 13:21 ` schwab@linux-m68k.org 2013-01-18 13:26 ` schwab@linux-m68k.org 2013-01-18 13:52 ` jakub at gcc dot gnu.org 2013-01-18 15:34 ` kcc at gcc dot gnu.org 2013-01-18 15:41 ` jakub at gcc dot gnu.org 2013-01-18 15:46 ` kcc at gcc dot gnu.org 2013-01-21 9:11 ` kcc at gcc dot gnu.org 2013-01-23 12:22 ` kcc at gcc dot gnu.org 2013-01-23 12:26 ` jakub at gcc dot gnu.org 2013-01-23 12:52 ` kcc at gcc dot gnu.org 2013-01-23 13:06 ` jakub at gcc dot gnu.org 2013-01-23 13:19 ` kcc at gcc dot gnu.org 2013-01-23 13:30 ` jakub at gcc dot gnu.org 2013-01-23 13:32 ` kcc at gcc dot gnu.org 2013-01-23 13:34 ` jakub at gcc dot gnu.org 2013-01-23 13:41 ` jakub at gcc dot gnu.org 2013-01-23 13:50 ` kcc at gcc dot gnu.org [this message] 2013-01-23 16:26 ` wschmidt at gcc dot gnu.org 2013-01-24 7:19 ` kcc at gcc dot gnu.org 2013-01-24 13:31 ` wschmidt at gcc dot gnu.org 2013-01-24 13:47 ` kcc at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-55975-4-qz8N1RBnT6@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).