public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "mpolacek at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/56035] [4.8 Regression] ICE in verify_loop_structure, at cfgloop.c:1581 (loop n’s header does not belong directly to it !)
Date: Tue, 22 Jan 2013 10:22:00 -0000	[thread overview]
Message-ID: <bug-56035-4-3s0AfOmCeX@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-56035-4@http.gcc.gnu.org/bugzilla/>


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56035

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> 2013-01-22 10:22:21 UTC ---
The problem looks to be in fix_loop_structures:
      /* If there was no latch, schedule the loop for removal.  */
      if (!first_latch)
        loop->header = NULL;
      /* If there was a single latch and it belongs to the loop of the
         header, record it.  */
      else if (latch
               && latch->src->loop_father == loop)
        loop->latch = latch->src;
      /* Otherwise there are multiple latches which are eventually
         disambiguated below.  */
      else 
        loop->latch = NULL;
we have the first_latch and there's only one latch edge, so we should the the
else if branch.  But we don't, since latch->src->loop_father != loop.  It looks
like the loop_father info isn't correct at all, ->loop_father->num is always 0,
but if we defer re-computing the latches to after re-scanning the bodies of
loops and fixing the nesting, everything seems to be fine (and the final
assembly is the same as before r194582).

The CFG is quite weird though, e.g. EXIT has no predecessors at all.


  parent reply	other threads:[~2013-01-22 10:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-18 17:28 [Bug tree-optimization/56035] New: " antoine.balestrat at gmail dot com
2013-01-18 17:34 ` [Bug tree-optimization/56035] [4.8 Regression] " mpolacek at gcc dot gnu.org
2013-01-18 21:59 ` mpolacek at gcc dot gnu.org
2013-01-18 23:25 ` mpolacek at gcc dot gnu.org
2013-01-21 13:27 ` rguenth at gcc dot gnu.org
2013-01-22 10:22 ` mpolacek at gcc dot gnu.org [this message]
2013-01-22 11:39 ` jakub at gcc dot gnu.org
2013-01-22 13:25 ` mpolacek at gcc dot gnu.org
2013-01-25  8:52 ` mpolacek at gcc dot gnu.org
2013-01-25  8:53 ` mpolacek at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-56035-4-3s0AfOmCeX@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).