[Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053

             Bug #: 56053
           Summary: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: dominiq@lps.ens.fr
                CC: jakub@redhat.com, rguenther@suse.de


As reported in pr55679 comment #12, the tests
c-c++-common/asan/(global|stack)-overflow-1.c fail on x86_64-apple-darwin* with
optimization because the out of bound read is optimized out. Is the
optimization sound? If yes, why does not it occur for linux? If no, why does it
occur for darwin?

The tests pass with

/* { dg-options "-fno-builtin-memset -fno-tree-fre -fno-tree-pre" } */

[Bug tree-optimization/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053

Dominique d'Humieres <dominiq at lps dot ens.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-01-20
                 CC|                            |howarth at bromo dot
                   |                            |med.uc.edu
     Ever Confirmed|0                           |1

--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2013-01-20 16:52:14 UTC ---
I have forgotten to CC Jack Howarth.

[Bug tree-optimization/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-28 12:07:12 UTC ---
The optimization is sound without -fno-builtin-memset.  Otherwise not - why
would that not be in effect for darwin?  Can you attach preprocessed source
please?

[Bug tree-optimization/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 12:10:57 UTC ---
Just guessing, perhaps Darwin headers define memset using __builtin_memset?
So, perhaps we should ditch #include <string.h> and define the prototypes
ourselves, then it isn't dependent on the target headers.

[Bug tree-optimization/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053

--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2013-01-28 12:16:32 UTC ---
Created attachment 29293
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29293
preprocessed source for global-overflow-1.c

> Can you attach preprocessed source please?

Done for global-overflow-1.c.

[Bug tree-optimization/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-28 12:34:15 UTC ---
Seems to fortify by default and thus expose a builtin anyway.

[Bug testsuite/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 13:00:00 UTC ---
Created attachment 29295
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29295
gcc48-pr56053.patch

Untested fix.

[Bug testsuite/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[dominiq at lps dot ens.fr]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053

--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2013-01-28 14:06:35 UTC ---
> Created attachment 29295 [details]
> gcc48-pr56053.patch
>
> Untested fix.

On x86_64-apple-darwin10, with the patch
make -k check-gcc RUNTESTFLAGS="asan.exp --target_board=unix'{-m32,-m64}'"
gives

        === gcc Summary ===

# of expected passes        516
# of unsupported tests        76

and check-g++ gives

        === g++ Summary ===

# of expected passes        810
# of unsupported tests        138

So the patch fixes this PR at least on darwin.

[Bug testsuite/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 14:28:24 UTC ---
Author: jakub
Date: Mon Jan 28 14:28:16 2013
New Revision: 195505

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195505
Log:
    PR testsuite/56053
    * c-c++-common/asan/heap-overflow-1.c: Don't include stdlib.h and
    string.h.  Provide memset, malloc and free prototypes, adjust line
    numbers in dg-output.
    * c-c++-common/asan/stack-overflow-1.c: Don't include string.h.
    Provide memset prototype and adjust line numbers in dg-output.
    * c-c++-common/asan/global-overflow-1.c: Likewise.

Modified:
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/c-c++-common/asan/global-overflow-1.c
    trunk/gcc/testsuite/c-c++-common/asan/heap-overflow-1.c
    trunk/gcc/testsuite/c-c++-common/asan/stack-overflow-1.c

[Bug testsuite/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 14:31:35 UTC ---
Should be fixed now.