public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
@ 2013-01-20 16:47 dominiq at lps dot ens.fr
2013-01-20 16:52 ` [Bug tree-optimization/56053] " dominiq at lps dot ens.fr
` (8 more replies)
0 siblings, 9 replies; 10+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-01-20 16:47 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053
Bug #: 56053
Summary: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
Classification: Unclassified
Product: gcc
Version: 4.8.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: tree-optimization
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: dominiq@lps.ens.fr
CC: jakub@redhat.com, rguenther@suse.de
As reported in pr55679 comment #12, the tests
c-c++-common/asan/(global|stack)-overflow-1.c fail on x86_64-apple-darwin* with
optimization because the out of bound read is optimized out. Is the
optimization sound? If yes, why does not it occur for linux? If no, why does it
occur for darwin?
The tests pass with
/* { dg-options "-fno-builtin-memset -fno-tree-fre -fno-tree-pre" } */
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
2013-01-20 16:47 [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c dominiq at lps dot ens.fr
@ 2013-01-20 16:52 ` dominiq at lps dot ens.fr
2013-01-28 12:07 ` rguenth at gcc dot gnu.org
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-01-20 16:52 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053
Dominique d'Humieres <dominiq at lps dot ens.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2013-01-20
CC| |howarth at bromo dot
| |med.uc.edu
Ever Confirmed|0 |1
--- Comment #1 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2013-01-20 16:52:14 UTC ---
I have forgotten to CC Jack Howarth.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
2013-01-20 16:47 [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c dominiq at lps dot ens.fr
2013-01-20 16:52 ` [Bug tree-optimization/56053] " dominiq at lps dot ens.fr
@ 2013-01-28 12:07 ` rguenth at gcc dot gnu.org
2013-01-28 12:11 ` jakub at gcc dot gnu.org
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-01-28 12:07 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053
--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-28 12:07:12 UTC ---
The optimization is sound without -fno-builtin-memset. Otherwise not - why
would that not be in effect for darwin? Can you attach preprocessed source
please?
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
2013-01-20 16:47 [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c dominiq at lps dot ens.fr
2013-01-20 16:52 ` [Bug tree-optimization/56053] " dominiq at lps dot ens.fr
2013-01-28 12:07 ` rguenth at gcc dot gnu.org
@ 2013-01-28 12:11 ` jakub at gcc dot gnu.org
2013-01-28 12:17 ` dominiq at lps dot ens.fr
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-01-28 12:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 12:10:57 UTC ---
Just guessing, perhaps Darwin headers define memset using __builtin_memset?
So, perhaps we should ditch #include <string.h> and define the prototypes
ourselves, then it isn't dependent on the target headers.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
2013-01-20 16:47 [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c dominiq at lps dot ens.fr
` (2 preceding siblings ...)
2013-01-28 12:11 ` jakub at gcc dot gnu.org
@ 2013-01-28 12:17 ` dominiq at lps dot ens.fr
2013-01-28 12:34 ` rguenth at gcc dot gnu.org
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-01-28 12:17 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053
--- Comment #4 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2013-01-28 12:16:32 UTC ---
Created attachment 29293
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29293
preprocessed source for global-overflow-1.c
> Can you attach preprocessed source please?
Done for global-overflow-1.c.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug tree-optimization/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
2013-01-20 16:47 [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c dominiq at lps dot ens.fr
` (3 preceding siblings ...)
2013-01-28 12:17 ` dominiq at lps dot ens.fr
@ 2013-01-28 12:34 ` rguenth at gcc dot gnu.org
2013-01-28 13:00 ` [Bug testsuite/56053] " jakub at gcc dot gnu.org
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-01-28 12:34 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> 2013-01-28 12:34:15 UTC ---
Seems to fortify by default and thus expose a builtin anyway.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
2013-01-20 16:47 [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c dominiq at lps dot ens.fr
` (4 preceding siblings ...)
2013-01-28 12:34 ` rguenth at gcc dot gnu.org
@ 2013-01-28 13:00 ` jakub at gcc dot gnu.org
2013-01-28 14:07 ` dominiq at lps dot ens.fr
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-01-28 13:00 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|unassigned at gcc dot |jakub at gcc dot gnu.org
|gnu.org |
--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 13:00:00 UTC ---
Created attachment 29295
--> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29295
gcc48-pr56053.patch
Untested fix.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
2013-01-20 16:47 [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c dominiq at lps dot ens.fr
` (5 preceding siblings ...)
2013-01-28 13:00 ` [Bug testsuite/56053] " jakub at gcc dot gnu.org
@ 2013-01-28 14:07 ` dominiq at lps dot ens.fr
2013-01-28 14:28 ` jakub at gcc dot gnu.org
2013-01-28 14:32 ` jakub at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: dominiq at lps dot ens.fr @ 2013-01-28 14:07 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053
--- Comment #7 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2013-01-28 14:06:35 UTC ---
> Created attachment 29295 [details]
> gcc48-pr56053.patch
>
> Untested fix.
On x86_64-apple-darwin10, with the patch
make -k check-gcc RUNTESTFLAGS="asan.exp --target_board=unix'{-m32,-m64}'"
gives
=== gcc Summary ===
# of expected passes 516
# of unsupported tests 76
and check-g++ gives
=== g++ Summary ===
# of expected passes 810
# of unsupported tests 138
So the patch fixes this PR at least on darwin.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
2013-01-20 16:47 [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c dominiq at lps dot ens.fr
` (6 preceding siblings ...)
2013-01-28 14:07 ` dominiq at lps dot ens.fr
@ 2013-01-28 14:28 ` jakub at gcc dot gnu.org
2013-01-28 14:32 ` jakub at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-01-28 14:28 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053
--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 14:28:24 UTC ---
Author: jakub
Date: Mon Jan 28 14:28:16 2013
New Revision: 195505
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195505
Log:
PR testsuite/56053
* c-c++-common/asan/heap-overflow-1.c: Don't include stdlib.h and
string.h. Provide memset, malloc and free prototypes, adjust line
numbers in dg-output.
* c-c++-common/asan/stack-overflow-1.c: Don't include string.h.
Provide memset prototype and adjust line numbers in dg-output.
* c-c++-common/asan/global-overflow-1.c: Likewise.
Modified:
trunk/gcc/testsuite/ChangeLog
trunk/gcc/testsuite/c-c++-common/asan/global-overflow-1.c
trunk/gcc/testsuite/c-c++-common/asan/heap-overflow-1.c
trunk/gcc/testsuite/c-c++-common/asan/stack-overflow-1.c
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Bug testsuite/56053] FAIL: c-c++-common/asan/(global|stack)-overflow-1.c
2013-01-20 16:47 [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c dominiq at lps dot ens.fr
` (7 preceding siblings ...)
2013-01-28 14:28 ` jakub at gcc dot gnu.org
@ 2013-01-28 14:32 ` jakub at gcc dot gnu.org
8 siblings, 0 replies; 10+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-01-28 14:32 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56053
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 14:31:35 UTC ---
Should be fixed now.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-01-28 14:32 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-20 16:47 [Bug tree-optimization/56053] New: FAIL: c-c++-common/asan/(global|stack)-overflow-1.c dominiq at lps dot ens.fr
2013-01-20 16:52 ` [Bug tree-optimization/56053] " dominiq at lps dot ens.fr
2013-01-28 12:07 ` rguenth at gcc dot gnu.org
2013-01-28 12:11 ` jakub at gcc dot gnu.org
2013-01-28 12:17 ` dominiq at lps dot ens.fr
2013-01-28 12:34 ` rguenth at gcc dot gnu.org
2013-01-28 13:00 ` [Bug testsuite/56053] " jakub at gcc dot gnu.org
2013-01-28 14:07 ` dominiq at lps dot ens.fr
2013-01-28 14:28 ` jakub at gcc dot gnu.org
2013-01-28 14:32 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).