public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "tilman@code-monkey.de" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/56096] New: Bad code generated for conditional shift Date: Thu, 24 Jan 2013 06:47:00 -0000 [thread overview] Message-ID: <bug-56096-4@http.gcc.gnu.org/bugzilla/> (raw) http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56096 Bug #: 56096 Summary: Bad code generated for conditional shift Classification: Unclassified Product: gcc Version: 4.7.2 Status: UNCONFIRMED Severity: normal Priority: P3 Component: target AssignedTo: unassigned@gcc.gnu.org ReportedBy: tilman@code-monkey.de Compiling this snippet unsigned f1 (unsigned x, unsigned m) { x >>= ((m & 0x008080) ? 8 : 0); return x; } with gcc 4.7.2 gives this code for ARMv5: $ armv5tel-softfloat-linux-gnueabi-gcc -O2 -S -o- f.c [...] ldr r3, .L4 and r3, r1, r3 cmp r3, #0 movne r3, #8 @ XXX moveq r3, #0 @ XXX mov r0, r0, lsr r3 @ XXX bx lr [...] Those three mov instructions are clearly sub-optimal. Replacing the ternary operator with an if-statement gives the expected code sequence: unsigned f1 (unsigned x, unsigned m) { if (m & 0x008080) x >>= 8; return x; } -> ldr r3, .L6 and r3, r1, r3 cmp r3, #0 movne r0, r0, lsr #8 bx lr ie we saved two mov instructions.
next reply other threads:[~2013-01-24 6:47 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-01-24 6:47 tilman@code-monkey.de [this message] 2013-01-24 8:55 ` [Bug target/56096] " mikpe at it dot uu.se 2013-03-05 9:06 ` [Bug tree-optimization/56096] Sub-optimal " rearnsha at gcc dot gnu.org 2021-07-25 2:08 ` pinskia at gcc dot gnu.org 2023-08-05 3:49 ` pinskia at gcc dot gnu.org 2023-08-05 3:54 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-56096-4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).