public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/56096] New: Bad code generated for conditional shift
@ 2013-01-24  6:47 tilman@code-monkey.de
  2013-01-24  8:55 ` [Bug target/56096] " mikpe at it dot uu.se
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: tilman@code-monkey.de @ 2013-01-24  6:47 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56096

             Bug #: 56096
           Summary: Bad code generated for conditional shift
    Classification: Unclassified
           Product: gcc
           Version: 4.7.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: tilman@code-monkey.de


Compiling this snippet

unsigned f1 (unsigned x, unsigned m)
{
    x >>= ((m & 0x008080) ? 8 : 0);
    return x;
}

with gcc 4.7.2 gives this code for ARMv5:

$ armv5tel-softfloat-linux-gnueabi-gcc -O2 -S -o- f.c
[...]
    ldr    r3, .L4
    and    r3, r1, r3
    cmp    r3, #0
    movne    r3, #8           @ XXX
    moveq    r3, #0           @ XXX
    mov    r0, r0, lsr r3   @ XXX
    bx    lr
[...]

Those three mov instructions are clearly sub-optimal.

Replacing the ternary operator with an if-statement gives the expected code
sequence:

unsigned f1 (unsigned x, unsigned m)
{
    if (m & 0x008080)
        x >>= 8;

    return x;
}

-> 
    ldr    r3, .L6
    and    r3, r1, r3
    cmp    r3, #0
    movne    r0, r0, lsr #8
    bx    lr

ie we saved two mov instructions.


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-05  3:54 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-24  6:47 [Bug target/56096] New: Bad code generated for conditional shift tilman@code-monkey.de
2013-01-24  8:55 ` [Bug target/56096] " mikpe at it dot uu.se
2013-03-05  9:06 ` [Bug tree-optimization/56096] Sub-optimal " rearnsha at gcc dot gnu.org
2021-07-25  2:08 ` pinskia at gcc dot gnu.org
2023-08-05  3:49 ` pinskia at gcc dot gnu.org
2023-08-05  3:54 ` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).