[Bug rtl-optimization/56117] New: [4.8 Regression] ICE: in cselib_subst_to_values, at cselib.c:1853 with -O2 -fsched2-use-superblocks and __builtin_prefetch()

[Bug rtl-optimization/56117] New: [4.8 Regression] ICE: in cselib_subst_to_values, at cselib.c:1853 with -O2 -fsched2-use-superblocks and __builtin_prefetch()

[zsojka at seznam dot cz]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56117

             Bug #: 56117
           Summary: [4.8 Regression] ICE: in cselib_subst_to_values, at
                    cselib.c:1853 with -O2 -fsched2-use-superblocks and
                    __builtin_prefetch()
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: rtl-optimization
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: zsojka@seznam.cz


Created attachment 29278
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29278
reduced testcase

Compiler output:
$ gcc -O2 -fsched2-use-superblocks testcase.c         
testcase.c: In function 'foo':
testcase.c:4:1: internal compiler error: in cselib_subst_to_values, at
cselib.c:1853
 }
 ^
0x6d6874 cselib_subst_to_values(rtx_def*, machine_mode)
        /mnt/svn/gcc-trunk/gcc/cselib.c:1853
0x6d6cf9 cselib_subst_to_values_from_insn(rtx_def*, machine_mode, rtx_def*)
        /mnt/svn/gcc-trunk/gcc/cselib.c:1945
0x1149dbf add_insn_mem_dependence
        /mnt/svn/gcc-trunk/gcc/sched-deps.c:1739
0x1150266 sched_analyze_2
        /mnt/svn/gcc-trunk/gcc/sched-deps.c:2724
0x11510ee sched_analyze_insn
        /mnt/svn/gcc-trunk/gcc/sched-deps.c:2899
0x1153b09 deps_analyze_insn(deps_desc*, rtx_def*)
        /mnt/svn/gcc-trunk/gcc/sched-deps.c:3583
0x1154815 sched_analyze(deps_desc*, rtx_def*, rtx_def*)
        /mnt/svn/gcc-trunk/gcc/sched-deps.c:3732
0x11583ea schedule_ebb(rtx_def*, rtx_def*, bool)
        /mnt/svn/gcc-trunk/gcc/sched-ebb.c:514
0x1158e35 schedule_ebbs()
        /mnt/svn/gcc-trunk/gcc/sched-ebb.c:664
0x9cb7f4 rest_of_handle_sched2
        /mnt/svn/gcc-trunk/gcc/sched-rgn.c:3606
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.

Tested revisions:
r195477 - crash
r195313 - crash
r192654 - OK
4.7 r194763 - OK

[Bug rtl-optimization/56117] [4.8 Regression] ICE: in cselib_subst_to_values, at cselib.c:1853 with -O2 -fsched2-use-superblocks and __builtin_prefetch()

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56117

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |4.8.0

[Bug rtl-optimization/56117] [4.8 Regression] ICE: in cselib_subst_to_values, at cselib.c:1853 with -O2 -fsched2-use-superblocks and __builtin_prefetch()

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56117

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2013-01-28
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |vmakarov at gcc dot gnu.org
         AssignedTo|unassigned at gcc dot       |jakub at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 08:44:33 UTC ---
As expected, regressed with the
http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195211
change.

[Bug rtl-optimization/56117] [4.8 Regression] ICE: in cselib_subst_to_values, at cselib.c:1853 with -O2 -fsched2-use-superblocks and __builtin_prefetch()

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56117

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 08:51:39 UTC ---
Created attachment 29289
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29289
gcc48-pr56117.patch

Untested fix.  For MEMs, sched-deps.c is calling cselib_lookup_from_insn, but
for PREFETCH it wasn't doing that.  As this is before cselib_process_insn is
called, some REGs mentioned in the pattern might be never looked up yet at that
point.

[Bug rtl-optimization/56117] [4.8 Regression] ICE: in cselib_subst_to_values, at cselib.c:1853 with -O2 -fsched2-use-superblocks and __builtin_prefetch()

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56117

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 16:50:39 UTC ---
Author: jakub
Date: Mon Jan 28 16:50:22 2013
New Revision: 195513

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195513
Log:
    PR rtl-optimization/56117
    * sched-deps.c (sched_analyze_2) <case PREFETCH>: For use_cselib
    call cselib_lookup_from_insn on the MEM before calling
    add_insn_mem_dependence.

    * gcc.dg/pr56117.c: New test.

Added:
    trunk/gcc/testsuite/gcc.dg/pr56117.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/sched-deps.c
    trunk/gcc/testsuite/ChangeLog

[Bug rtl-optimization/56117] [4.8 Regression] ICE: in cselib_subst_to_values, at cselib.c:1853 with -O2 -fsched2-use-superblocks and __builtin_prefetch()

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56117

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-28 16:52:26 UTC ---
Fixed.