public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug debug/56154] New: [4.7/4.8 Regression] Bad .debug_loc generated for some code
@ 2013-01-30 15:53 jakub at gcc dot gnu.org
  2013-01-30 17:17 ` [Bug debug/56154] " jakub at gcc dot gnu.org
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-01-30 15:53 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56154

             Bug #: 56154
           Summary: [4.7/4.8 Regression] Bad .debug_loc generated for some
                    code
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: debug
        AssignedTo: jakub@gcc.gnu.org
        ReportedBy: jakub@gcc.gnu.org


Since http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=175076
without inline asm, but with inline asm even before, we can end up with
a .debug_loc location list which for the first function in .text starts with
0, 0 entry.

See https://bugzilla.redhat.com/show_bug.cgi?id=904252 for more details.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/56154] [4.7/4.8 Regression] Bad .debug_loc generated for some code
  2013-01-30 15:53 [Bug debug/56154] New: [4.7/4.8 Regression] Bad .debug_loc generated for some code jakub at gcc dot gnu.org
@ 2013-01-30 17:17 ` jakub at gcc dot gnu.org
  2013-01-30 17:22 ` jakub at gcc dot gnu.org
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-01-30 17:17 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56154

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-01-30 17:16:08 UTC ---
Created attachment 29308
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29308
gcc48-pr56154.patch

Untested fix, together with guality testcases that show the issue.  On x86_64,
without the dwarf2out.c change I see with:
make check-gcc \
RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} guality.exp=pr56154*.c'
Running target unix/-m32
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /usr/src/gcc/gcc/testsuite/config/default.exp as tool-and-target-specific
interface file.
Running /usr/src/gcc/gcc/testsuite/gcc.dg/guality/guality.exp ...
FAIL: gcc.dg/guality/pr56154-2.c  -O1  line pr56154-2.c:30 x == 28
FAIL: gcc.dg/guality/pr56154-2.c  -O2  line pr56154-2.c:30 x == 28
FAIL: gcc.dg/guality/pr56154-2.c  -O3 -fomit-frame-pointer  line pr56154-2.c:30
x == 28
FAIL: gcc.dg/guality/pr56154-2.c  -O3 -g  line pr56154-2.c:30 x == 28
FAIL: gcc.dg/guality/pr56154-3.c  -O1  line pr56154-3.c:22 x == 28
FAIL: gcc.dg/guality/pr56154-3.c  -O2  line pr56154-3.c:22 x == 28
FAIL: gcc.dg/guality/pr56154-3.c  -O3 -fomit-frame-pointer  line pr56154-3.c:22
x == 28
FAIL: gcc.dg/guality/pr56154-3.c  -O3 -g  line pr56154-3.c:22 x == 28

Running target unix/-m64
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for
target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /usr/src/gcc/gcc/testsuite/config/default.exp as tool-and-target-specific
interface file.
Running /usr/src/gcc/gcc/testsuite/gcc.dg/guality/guality.exp ...
FAIL: gcc.dg/guality/pr56154-1.c  -O1  line pr56154-1.c:17 x.a == 4
FAIL: gcc.dg/guality/pr56154-1.c  -O1  line pr56154-1.c:20 x.a == 6
FAIL: gcc.dg/guality/pr56154-1.c  -O2  line pr56154-1.c:17 x.a == 4
FAIL: gcc.dg/guality/pr56154-1.c  -O2  line pr56154-1.c:20 x.a == 6
FAIL: gcc.dg/guality/pr56154-1.c  -O3 -fomit-frame-pointer  line pr56154-1.c:17
x.a == 4
FAIL: gcc.dg/guality/pr56154-1.c  -O3 -fomit-frame-pointer  line pr56154-1.c:20
x.a == 6
FAIL: gcc.dg/guality/pr56154-1.c  -O3 -g  line pr56154-1.c:17 x.a == 4
FAIL: gcc.dg/guality/pr56154-1.c  -O3 -g  line pr56154-1.c:20 x.a == 6
FAIL: gcc.dg/guality/pr56154-1.c  -Os  line pr56154-1.c:17 x.a == 4
FAIL: gcc.dg/guality/pr56154-1.c  -Os  line pr56154-1.c:20 x.a == 6
FAIL: gcc.dg/guality/pr56154-2.c  -O1  line pr56154-2.c:30 x == 28
FAIL: gcc.dg/guality/pr56154-2.c  -O2  line pr56154-2.c:30 x == 28
FAIL: gcc.dg/guality/pr56154-2.c  -O3 -fomit-frame-pointer  line pr56154-2.c:30
x == 28
FAIL: gcc.dg/guality/pr56154-2.c  -O3 -g  line pr56154-2.c:30 x == 28
FAIL: gcc.dg/guality/pr56154-2.c  -Os  line pr56154-2.c:30 x == 28
FAIL: gcc.dg/guality/pr56154-3.c  -O1  line pr56154-3.c:22 x == 28
FAIL: gcc.dg/guality/pr56154-3.c  -O2  line pr56154-3.c:22 x == 28
FAIL: gcc.dg/guality/pr56154-3.c  -O3 -fomit-frame-pointer  line pr56154-3.c:22
x == 28
FAIL: gcc.dg/guality/pr56154-3.c  -O3 -g  line pr56154-3.c:22 x == 28
FAIL: gcc.dg/guality/pr56154-3.c  -Os  line pr56154-3.c:22 x == 28

while with it everything passes.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/56154] [4.7/4.8 Regression] Bad .debug_loc generated for some code
  2013-01-30 15:53 [Bug debug/56154] New: [4.7/4.8 Regression] Bad .debug_loc generated for some code jakub at gcc dot gnu.org
  2013-01-30 17:17 ` [Bug debug/56154] " jakub at gcc dot gnu.org
@ 2013-01-30 17:22 ` jakub at gcc dot gnu.org
  2013-02-07 14:49 ` jakub at gcc dot gnu.org
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-01-30 17:22 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56154

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2013-01-30
                 CC|                            |aoliva at gcc dot gnu.org
   Target Milestone|---                         |4.7.3
     Ever Confirmed|0                           |1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/56154] [4.7/4.8 Regression] Bad .debug_loc generated for some code
  2013-01-30 15:53 [Bug debug/56154] New: [4.7/4.8 Regression] Bad .debug_loc generated for some code jakub at gcc dot gnu.org
  2013-01-30 17:17 ` [Bug debug/56154] " jakub at gcc dot gnu.org
  2013-01-30 17:22 ` jakub at gcc dot gnu.org
@ 2013-02-07 14:49 ` jakub at gcc dot gnu.org
  2013-02-07 15:19 ` [Bug debug/56154] [4.7 " jakub at gcc dot gnu.org
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-02-07 14:49 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56154

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-02-07 14:48:51 UTC ---
Author: jakub
Date: Thu Feb  7 14:48:39 2013
New Revision: 195850

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195850
Log:
    PR debug/56154
    * dwarf2out.c (dwarf2_debug_hooks): Set end_function hook to
    dwarf2out_end_function.
    (in_first_function_p, maybe_at_text_label_p,
    first_loclabel_num_not_at_text_label): New variables.
    (dwarf2out_var_location): In the first function find out
    lowest loclabel_num N where .LVLN is known not to be equal
    to .Ltext0.
    (find_empty_loc_ranges_at_text_label, dwarf2out_end_function): New
    functions.

    * gcc.dg/guality/pr56154-1.c: New test.
    * gcc.dg/guality/pr56154-2.c: New test.
    * gcc.dg/guality/pr56154-3.c: New test.
    * gcc.dg/guality/pr56154-4.c: New test.
    * gcc.dg/guality/pr56154-aux.c: New file.

Added:
    trunk/gcc/testsuite/gcc.dg/guality/pr56154-1.c
    trunk/gcc/testsuite/gcc.dg/guality/pr56154-2.c
    trunk/gcc/testsuite/gcc.dg/guality/pr56154-3.c
    trunk/gcc/testsuite/gcc.dg/guality/pr56154-4.c
    trunk/gcc/testsuite/gcc.dg/guality/pr56154-aux.c
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/dwarf2out.c
    trunk/gcc/testsuite/ChangeLog


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/56154] [4.7 Regression] Bad .debug_loc generated for some code
  2013-01-30 15:53 [Bug debug/56154] New: [4.7/4.8 Regression] Bad .debug_loc generated for some code jakub at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2013-02-07 14:49 ` jakub at gcc dot gnu.org
@ 2013-02-07 15:19 ` jakub at gcc dot gnu.org
  2013-04-03  9:50 ` rguenth at gcc dot gnu.org
                   ` (2 subsequent siblings)
  6 siblings, 0 replies; 8+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-02-07 15:19 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56154

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[4.7/4.8 Regression] Bad    |[4.7 Regression] Bad
                   |.debug_loc generated for    |.debug_loc generated for
                   |some code                   |some code

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-02-07 15:18:55 UTC ---
Fixed on the trunk so far.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/56154] [4.7 Regression] Bad .debug_loc generated for some code
  2013-01-30 15:53 [Bug debug/56154] New: [4.7/4.8 Regression] Bad .debug_loc generated for some code jakub at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2013-02-07 15:19 ` [Bug debug/56154] [4.7 " jakub at gcc dot gnu.org
@ 2013-04-03  9:50 ` rguenth at gcc dot gnu.org
  2013-04-11  7:59 ` rguenth at gcc dot gnu.org
  2014-06-12 13:22 ` rguenth at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-04-03  9:50 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56154

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/56154] [4.7 Regression] Bad .debug_loc generated for some code
  2013-01-30 15:53 [Bug debug/56154] New: [4.7/4.8 Regression] Bad .debug_loc generated for some code jakub at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2013-04-03  9:50 ` rguenth at gcc dot gnu.org
@ 2013-04-11  7:59 ` rguenth at gcc dot gnu.org
  2014-06-12 13:22 ` rguenth at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-04-11  7:59 UTC (permalink / raw)
  To: gcc-bugs


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56154

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.7.3                       |4.7.4

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> 2013-04-11 07:59:32 UTC ---
GCC 4.7.3 is being released, adjusting target milestone.


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Bug debug/56154] [4.7 Regression] Bad .debug_loc generated for some code
  2013-01-30 15:53 [Bug debug/56154] New: [4.7/4.8 Regression] Bad .debug_loc generated for some code jakub at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2013-04-11  7:59 ` rguenth at gcc dot gnu.org
@ 2014-06-12 13:22 ` rguenth at gcc dot gnu.org
  6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2014-06-12 13:22 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56154

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|4.7.4                       |4.8.0
      Known to fail|                            |4.7.4

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed for 4.8.0?


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-06-12 13:22 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-30 15:53 [Bug debug/56154] New: [4.7/4.8 Regression] Bad .debug_loc generated for some code jakub at gcc dot gnu.org
2013-01-30 17:17 ` [Bug debug/56154] " jakub at gcc dot gnu.org
2013-01-30 17:22 ` jakub at gcc dot gnu.org
2013-02-07 14:49 ` jakub at gcc dot gnu.org
2013-02-07 15:19 ` [Bug debug/56154] [4.7 " jakub at gcc dot gnu.org
2013-04-03  9:50 ` rguenth at gcc dot gnu.org
2013-04-11  7:59 ` rguenth at gcc dot gnu.org
2014-06-12 13:22 ` rguenth at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).