From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-414377-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 28835 invoked by alias); 6 Feb 2013 14:56:24 -0000
Received: (qmail 28377 invoked by uid 48); 6 Feb 2013 14:55:28 -0000
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/56181] [4.8 Regression] ICE in verify_loop_structure, at cfgloop.c:1581 with -ftracer
Date: Wed, 06 Feb 2013 14:56:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Keywords: ice-checking
X-Bugzilla-Severity: normal
X-Bugzilla-Who: rguenth at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.0
X-Bugzilla-Changed-Fields:
Message-ID: <bug-56181-4-5XJARXsxq5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-56181-4@http.gcc.gnu.org/bugzilla/>
References: <bug-56181-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2013-02/txt/msg00542.txt.bz2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56181

--- Comment #10 from Richard Biener <rguenth at gcc dot gnu.org> 2013-02-06 14:55:25 UTC ---
(In reply to comment #9)
> Created attachment 29369 [details]
> updated patch
> 
> This works better.  Probably flow_loops_find should not handle loop removal
> though, and the IRA use is plain ugly (but it was before).

What I like about this idea is consolidating of fix_loop_structure and
flow_loops_find (and possibly parts of loop_optimizer_init).  What I like
less is that we allow even more leeway to passes to fixup after them.
That is, at least we should ICE when a loop marked for removal by a pass
is then re-discovered with exactly the same header.  And we should probably
dump info somewhere when we incrementally discover new loops.

Separately fixing the IRA oddness would be nice (use
loop_optimizer_init (AVOID_CFG_MANIPULATIONS) and current_loops instead of
ira_loops).