public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/56186] New: [4.8 regression] function return ABI change for 128-bit types on Win64
@ 2013-02-02 20:58 ebotcazou at gcc dot gnu.org
2013-02-04 9:52 ` [Bug target/56186] " rguenth at gcc dot gnu.org
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: ebotcazou at gcc dot gnu.org @ 2013-02-02 20:58 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56186
Bug #: 56186
Summary: [4.8 regression] function return ABI change for
128-bit types on Win64
Classification: Unclassified
Product: gcc
Version: 4.8.0
Status: UNCONFIRMED
Severity: major
Priority: P3
Component: target
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: ebotcazou@gcc.gnu.org
Target: x86_64-*-mingw
Some 128-bit wide types are returned differently with 4.8 than with 4.7 because
of the introduction of MAX_FIXED_MODE_SIZE in the x86 back-end. For example:
struct S {
long long int l1, l2;
};
struct S foo (void)
{
struct S s = { 0, 0 };
return s;
}
with 4.7.x:
movq %rcx, 16(%rbp)
movq $0, -16(%rbp)
movq $0, -8(%rbp)
movq 16(%rbp), %rax
movq -16(%rbp), %rdx
movq %rdx, (%rax)
movq -8(%rbp), %rdx
movq %rdx, 8(%rax)
movq 16(%rbp), %rax
addq $16, %rsp
popq %rbp
ret
with 4.8.0:
movq $0, -16(%rbp)
movq $0, -8(%rbp)
movq -16(%rbp), %rax
movq -8(%rbp), %rdx
movq %rax, -32(%rbp)
movq %rdx, -24(%rbp)
movdqa -32(%rbp), %xmm0
addq $32, %rsp
popq %rbp
ret
The implementation in function_value_ms_64 is too fragile and only looks at
modes instead of looking at types first.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/56186] [4.8 regression] function return ABI change for 128-bit types on Win64
2013-02-02 20:58 [Bug target/56186] New: [4.8 regression] function return ABI change for 128-bit types on Win64 ebotcazou at gcc dot gnu.org
@ 2013-02-04 9:52 ` rguenth at gcc dot gnu.org
2013-02-04 13:37 ` ktietz at gcc dot gnu.org
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-02-04 9:52 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56186
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Status|UNCONFIRMED |NEW
Keywords| |ABI
Last reconfirmed| |2013-02-04
Ever Confirmed|0 |1
Target Milestone|--- |4.8.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/56186] [4.8 regression] function return ABI change for 128-bit types on Win64
2013-02-02 20:58 [Bug target/56186] New: [4.8 regression] function return ABI change for 128-bit types on Win64 ebotcazou at gcc dot gnu.org
2013-02-04 9:52 ` [Bug target/56186] " rguenth at gcc dot gnu.org
@ 2013-02-04 13:37 ` ktietz at gcc dot gnu.org
2013-02-04 16:38 ` ktietz at gcc dot gnu.org
2013-02-04 16:40 ` ktietz at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: ktietz at gcc dot gnu.org @ 2013-02-04 13:37 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56186
Kai Tietz <ktietz at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/56186] [4.8 regression] function return ABI change for 128-bit types on Win64
2013-02-02 20:58 [Bug target/56186] New: [4.8 regression] function return ABI change for 128-bit types on Win64 ebotcazou at gcc dot gnu.org
2013-02-04 9:52 ` [Bug target/56186] " rguenth at gcc dot gnu.org
2013-02-04 13:37 ` ktietz at gcc dot gnu.org
@ 2013-02-04 16:38 ` ktietz at gcc dot gnu.org
2013-02-04 16:40 ` ktietz at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: ktietz at gcc dot gnu.org @ 2013-02-04 16:38 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56186
--- Comment #1 from Kai Tietz <ktietz at gcc dot gnu.org> 2013-02-04 16:37:51 UTC ---
Author: ktietz
Date: Mon Feb 4 16:37:44 2013
New Revision: 195721
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195721
Log:
PR target/56186
* config/i386/i386.c (function_value_ms_64): Add additional valtype
argument and improve checking of return-argument types for 16-byte
modes.
(ix86_function_value_1): Add additional valtype argument on call
of function_value_64.
(return_in_memory_ms_64): Sync 16-byte sized mode handling with
handling infunction_value_64 function.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/i386/i386.c
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Bug target/56186] [4.8 regression] function return ABI change for 128-bit types on Win64
2013-02-02 20:58 [Bug target/56186] New: [4.8 regression] function return ABI change for 128-bit types on Win64 ebotcazou at gcc dot gnu.org
` (2 preceding siblings ...)
2013-02-04 16:38 ` ktietz at gcc dot gnu.org
@ 2013-02-04 16:40 ` ktietz at gcc dot gnu.org
3 siblings, 0 replies; 5+ messages in thread
From: ktietz at gcc dot gnu.org @ 2013-02-04 16:40 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56186
Kai Tietz <ktietz at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #2 from Kai Tietz <ktietz at gcc dot gnu.org> 2013-02-04 16:39:48 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-04 16:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-02 20:58 [Bug target/56186] New: [4.8 regression] function return ABI change for 128-bit types on Win64 ebotcazou at gcc dot gnu.org
2013-02-04 9:52 ` [Bug target/56186] " rguenth at gcc dot gnu.org
2013-02-04 13:37 ` ktietz at gcc dot gnu.org
2013-02-04 16:38 ` ktietz at gcc dot gnu.org
2013-02-04 16:40 ` ktietz at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).