public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug bootstrap/56198] New: [4.8 Regression] Go profiledbootstrap error
@ 2013-02-04 7:42 jakub at gcc dot gnu.org
2013-02-04 7:43 ` [Bug bootstrap/56198] " jakub at gcc dot gnu.org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-02-04 7:42 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56198
Bug #: 56198
Summary: [4.8 Regression] Go profiledbootstrap error
Classification: Unclassified
Product: gcc
Version: 4.8.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: bootstrap
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: jakub@gcc.gnu.org
CC: ian@gcc.gnu.org
My --enable-checking=release profiledbootstrap failed on an maybe uninitialized
warning turned into -Werror in go/gofrontend/import-archive.cc.
Archive_file::read_header has:
off_t local_nested_off;
if (!this->interpret_header(&hdr, off, pname, size, &local_nested_off))
return false;
if (nested_off != NULL)
*nested_off = local_nested_off;
and the warning was complaining that local_nested_off might be uninitialized.
If Archive_file::interpret_header is what is called here, then *nested_off
might be indeed uninitialized even when the function returns true, in
particular for:
else if (hdr->ar_name[1] == ' ')
{
// This is the symbol table.
pname->clear();
}
else if (hdr->ar_name[1] == '/')
{
// This is the extended name table.
pname->assign(1, '/');
}
BTW, there seems to be also an inconsistency in that method, the first write
to
*nested_off in that method is not guarded by nested_off != NULL:
*nested_off = 0;
while the second one is:
if (nested_off != NULL)
*nested_off = y;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug bootstrap/56198] [4.8 Regression] Go profiledbootstrap error
2013-02-04 7:42 [Bug bootstrap/56198] New: [4.8 Regression] Go profiledbootstrap error jakub at gcc dot gnu.org
@ 2013-02-04 7:43 ` jakub at gcc dot gnu.org
2013-02-05 1:11 ` ian at gcc dot gnu.org
2013-02-05 1:13 ` ian at airs dot com
2 siblings, 0 replies; 4+ messages in thread
From: jakub at gcc dot gnu.org @ 2013-02-04 7:43 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56198
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.8.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug bootstrap/56198] [4.8 Regression] Go profiledbootstrap error
2013-02-04 7:42 [Bug bootstrap/56198] New: [4.8 Regression] Go profiledbootstrap error jakub at gcc dot gnu.org
2013-02-04 7:43 ` [Bug bootstrap/56198] " jakub at gcc dot gnu.org
@ 2013-02-05 1:11 ` ian at gcc dot gnu.org
2013-02-05 1:13 ` ian at airs dot com
2 siblings, 0 replies; 4+ messages in thread
From: ian at gcc dot gnu.org @ 2013-02-05 1:11 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56198
--- Comment #1 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> 2013-02-05 01:11:05 UTC ---
Author: ian
Date: Tue Feb 5 01:11:01 2013
New Revision: 195747
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195747
Log:
PR bootstrap/56198
compiler: Always initialize *nested_off in interpret_header.
Modified:
trunk/gcc/go/gofrontend/import-archive.cc
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug bootstrap/56198] [4.8 Regression] Go profiledbootstrap error
2013-02-04 7:42 [Bug bootstrap/56198] New: [4.8 Regression] Go profiledbootstrap error jakub at gcc dot gnu.org
2013-02-04 7:43 ` [Bug bootstrap/56198] " jakub at gcc dot gnu.org
2013-02-05 1:11 ` ian at gcc dot gnu.org
@ 2013-02-05 1:13 ` ian at airs dot com
2 siblings, 0 replies; 4+ messages in thread
From: ian at airs dot com @ 2013-02-05 1:13 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56198
Ian Lance Taylor <ian at airs dot com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |ian at airs dot com
Resolution| |FIXED
--- Comment #2 from Ian Lance Taylor <ian at airs dot com> 2013-02-05 01:12:45 UTC ---
Fixed. Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-02-05 1:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-04 7:42 [Bug bootstrap/56198] New: [4.8 Regression] Go profiledbootstrap error jakub at gcc dot gnu.org
2013-02-04 7:43 ` [Bug bootstrap/56198] " jakub at gcc dot gnu.org
2013-02-05 1:11 ` ian at gcc dot gnu.org
2013-02-05 1:13 ` ian at airs dot com
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).