From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugs-return-414913-listarch-gcc-bugs=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 11666 invoked by alias); 11 Feb 2013 15:10:11 -0000
Received: (qmail 11075 invoked by uid 48); 11 Feb 2013 15:09:41 -0000
From: "gjl at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/56263] [avr] Provide strict address-space checking
Date: Mon, 11 Feb 2013 15:10:00 -0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Keywords: diagnostic
X-Bugzilla-Severity: enhancement
X-Bugzilla-Who: gjl at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Priority: P5
X-Bugzilla-Assigned-To: gjl at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 4.8.0
X-Bugzilla-Changed-Fields:
Message-ID: <bug-56263-4-ctEsNQIOOl@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-56263-4@http.gcc.gnu.org/bugzilla/>
References: <bug-56263-4@http.gcc.gnu.org/bugzilla/>
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Mailing-List: contact gcc-bugs-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-bugs.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-bugs/>
List-Post: <mailto:gcc-bugs@gcc.gnu.org>
List-Help: <mailto:gcc-bugs-help@gcc.gnu.org>
Sender: gcc-bugs-owner@gcc.gnu.org
X-SW-Source: 2013-02/txt/msg01078.txt.bz2


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56263

--- Comment #2 from Georg-Johann Lay <gjl at gcc dot gnu.org> 2013-02-11 15:09:40 UTC ---
Created attachment 29418
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29418
draft patch

    PR target/56263
    * config/avr/avr.opt (-mstrict-addr-space-subsets): New option and...
    (avr_strict_addr_space_subsets)... attached variable.
    * config/avr/avr.c (avr_addr_space_subset_p): Use it to determine
    whether of not an address spaces are subsets.
    * doc/invoke.texi (AVR Options) <-mstrict-addr-space-subsets>:
    Document it.


I had a look at this.

With strict address spaces, GCC will emit zeroes as result of casts across
address spaces.  This means that code like

char read_char (const char *address, int data_in_flash)
{
    if (data_in_flash)
        return *(const __flash char*) address;
    else
        return *address;
}

will no more operate correctly.  For the same reason, it is no more possible to
use PSTR from AVR-LibC with functions that get an address space pointer because
PSTR puts (and must put) the literal in generic space.

(In reply to comment #1)
> I think the next test case should also be considered.
> 
> const char __flash* const __flash names[] =
> {
>     "flash_str1",
>     "flash_str2"

This cannot work because ISO/IEC TR18037 forces these literals into generic
space.

> };
> 
> const char __flash* name1 = names[0]; // ok
> const char*         name2 = names[1]; // error

Attached is the draft patch that I used.  This means that in order to make this
work, the compiler proper has to be extended and the feature cannot be
implemented in the avr backend alone.  Thus suspending for now and for an other
stage.