[Bug middle-end/56288] New: always true conditional expression in verify_ssa_name

[Bug middle-end/56288] New: always true conditional expression in verify_ssa_name

[pageexec at freemail dot hu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56288

             Bug #: 56288
           Summary: always true conditional expression in verify_ssa_name
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: pageexec@freemail.hu


git commit ec11736b57986660deef21d6375d2f23edf290d2 introduced
SSA_NAME_IDENTIFIER in addition to SSA_NAME_VAR where the latter can now return
NULL_TREE. so far so good, all users have been adjusted for this new condition
except there is i think a mistake in gcc/tree-ssa.c:verify_ssa_name that had
this change:

-  if (TREE_TYPE (ssa_name) != TREE_TYPE (SSA_NAME_VAR (ssa_name)))
+  if (SSA_NAME_VAR (ssa_name) != NULL_TREE
+      && TREE_TYPE (ssa_name) != TREE_TYPE (ssa_name))

i think the intention was more like preserving the original check for TREE_TYPE
(ssa_name) != TREE_TYPE (SSA_NAME_VAR (ssa_name)) instead.

[Bug middle-end/56288] always true conditional expression in verify_ssa_name

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56288

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2013-02-11
         AssignedTo|unassigned at gcc dot       |rguenth at gcc dot gnu.org
                   |gnu.org                     |
     Ever Confirmed|0                           |1

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> 2013-02-11 16:11:53 UTC ---
Oops.  Mine.

[Bug middle-end/56288] always true conditional expression in verify_ssa_name

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56288

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> 2013-02-12 11:18:17 UTC ---
Author: rguenth
Date: Tue Feb 12 11:18:05 2013
New Revision: 195973

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195973
Log:
2013-02-12  Richard Biener  <rguenther@suse.de>

    PR middle-end/56288
    * tree-ssa.c (verify_ssa_name): Fix check, move
    SSA_NAME_IN_FREE_LIST check up.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/tree-ssa.c

[Bug middle-end/56288] always true conditional expression in verify_ssa_name

[rguenth at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56288

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> 2013-02-12 11:18:41 UTC ---
Fixed.