[Bug c++/56291] New: ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[Bug c++/56291] New: ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[freddie_chopin at op dot pl]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

             Bug #: 56291
           Summary: ICE for C++11 in output_constructor_regular_field, at
                    varasm.c:4821
    Classification: Unclassified
           Product: gcc
           Version: 4.7.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: freddie_chopin@op.pl


[freddie@arch ~]$ cat file.cpp
class Base
{
public:
 constexpr Base() : v(1) {};
 int v;
};

class Derived : public Base
{
public:
 constexpr Derived() : Base() {};
 virtual void function();
};

Derived d;[freddie@arch ~]$ g++ -std=c++11 -c file.cpp
file.cpp:15:10: internal compiler error: in output_constructor_regular_field,
at varasm.c:4821
Please submit a full bug report,
with preprocessed source if appropriate.
See <https://bugs.archlinux.org/> for instructions.
[freddie@arch ~]$ g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-unknown-linux-gnu/4.7.2/lto-wrapper
Target: x86_64-unknown-linux-gnu
Configured with: /build/src/gcc-4.7.2/configure --prefix=/usr --libdir=/usr/lib
--libexecdir=/usr/lib --mandir=/usr/share/man --infodir=/usr/share/info
--with-bugurl=https://bugs.archlinux.org/
--enable-languages=c,c++,ada,fortran,go,lto,objc,obj-c++ --enable-shared
--enable-threads=posix --with-system-zlib --enable-__cxa_atexit
--disable-libunwind-exceptions --enable-clocale=gnu --disable-libstdcxx-pch
--enable-libstdcxx-time --enable-gnu-unique-object --enable-linker-build-id
--with-ppl --enable-cloog-backend=isl --disable-ppl-version-check
--disable-cloog-version-check --enable-lto --enable-gold --enable-ld=default
--enable-plugin --with-plugin-ld=ld.gold --with-linker-hash-style=gnu
--enable-multilib --disable-libssp --disable-build-with-cxx
--disable-build-poststage1-with-cxx --enable-checking=release
Thread model: posix
gcc version 4.7.2 (GCC) 

---------------

Each of the listed things makes the problem go away:
- making function() non-virtual (or removing it)
- making both or at least Derived's constructor non-constexpr
- removing the member field "v" from Base (along with the initializer in the
constructor)

I've tested with g++, x86_64-w64-mingw32-g++, i686-w64-mingw32-g++ (all on
Linux), arm-none-eabi-g++, mingw32-g++ (both on Windows), all the toolchains I
have are 4.7.2 and in each of them the problem is identical. I've also have the
same error with 4.6.2 arm-none-eabi-g++.

Is anything more needed? Maybe this is already fixed (and/or reported)?

Thx in advance!

[Bug c++/56291] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|freddie_chopin at op dot pl |

--- Comment #1 from Paolo Carlini <paolo.carlini at oracle dot com> 2013-02-12 00:45:09 UTC ---
Current mainline and 4_7-branch work for me. The weird thing is, stock 4.7.2
also works fine for me - I think this is essentially a duplicate of c++/54253.
Are you sure you are using a stock FSF 4.7.2?

[Bug c++/56291] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[freddie_chopin at op dot pl]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

--- Comment #2 from Freddie Chopin <freddie_chopin at op dot pl> 2013-02-12 07:14:17 UTC ---
Created attachment 29421
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29421
failing test case

[Bug c++/56291] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[freddie_chopin at op dot pl]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

Freddie Chopin <freddie_chopin at op dot pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |freddie_chopin at op dot pl

--- Comment #3 from Freddie Chopin <freddie_chopin at op dot pl> 2013-02-12 07:26:05 UTC ---
(In reply to comment #1)
> Current mainline and 4_7-branch work for me. The weird thing is, stock 4.7.2
> also works fine for me - I think this is essentially a duplicate of c++/54253.
> Are you sure you are using a stock FSF 4.7.2?

First of all, I've just noticed that in my example code the last newline is
missing, so a very important last line (that creates the object - without it
there's no problem too) got merged with the shell prompt. To be really sure,
I'm pasting the example again:

// starts here
class Base
{
public:
 constexpr Base() : v(1) {};
 int v;
};

class Derived : public Base
{
public:
 constexpr Derived() : Base() {};
 virtual void function();
};

Derived d;
// ends here

Sorry about that thing not being clearly stated in the first message. I've also
added an attachment this time, so there's no way to miss this last line.

As for your questions and suggestions. First of all this is not related to the
bug you mentioned - all three testcases attached there work for me without a
problem (I tested like this - g++ -std=c++11 -c <filename> -o
<output_filename>), and from the description I think the problem was a
segfault, while I have a ICE report coming from gcc_assert(). Am I using a
vanilla GCC - that's a good question (; The bare-metal ARM compiler (the one I
work most of the time and on which I noticed the problem) comes directly from
/branches/ARM/embedded-4_7-branch and I have 2 versions of it (both fail). I
also have another ARM compiler that's probably from this branch too (but I'm
not sure), and it fails there too. A compiler from previous branch -
/branches/ARM/embedded-4_6-branch - also fails. As for the "g++" on Linux, I
have no idea whether this is vanilla or modified for Arch package - any way I
can check that (other than comparing source code (; )? I definetely reports
just as "4.7.2"... When I look at the source code for varasm.c in the 4.7
branch all I can tell is that at least the line of the report I'm seeing
matches the line in the code;

---

  /* Advance to offset of this element.
     Note no alignment needed in an array, since that is guaranteed
     if each element has the proper size.  */
  if ((local->field != NULL_TREE || local->index != NULL_TREE)
      && fieldpos != local->total_bytes)
    {
      gcc_assert (fieldpos >= local->total_bytes); // this is line 4821 which
reports ICE
      assemble_zeros (fieldpos - local->total_bytes);
      local->total_bytes = fieldpos;
    }

---

Is there anywhere I could download a "really stock package" of GCC in binary
form to check it (I'm not an expert, just a user, so compiling that myself is
rather hard...) - for Linux or Windows?

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2013-02-12
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |jason at gcc dot gnu.org
   Target Milestone|---                         |4.6.4
            Summary|ICE for C++11 in            |[4.6/4.7/4.8 Regression]
                   |output_constructor_regular_ |ICE for C++11 in
                   |field, at varasm.c:4821     |output_constructor_regular_
                   |                            |field, at varasm.c:4821
     Ever Confirmed|0                           |1

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-02-12 08:57:16 UTC ---
Then please provide complete testcase next time, the one line shorter testcase
certainly ICEs with r191000 and doesn't with r191100, while the one with the
var definition started to ICE with
http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=166167

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[freddie_chopin at op dot pl]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

--- Comment #5 from Freddie Chopin <freddie_chopin at op dot pl> 2013-02-12 09:07:37 UTC ---
Yes, sorry about the fuzz with the testcase and thx for confirming.

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-02-12 11:50:02 UTC ---
I think the problem is in sort_constexpr_mem_initializers, which doesn't handle
this case.  CLASSTYPE_PRIMARY_BINFO (type) is NULL, thus it doesn't reorder
anything, but in this case, because the base class is not virtual, but type is,
the _vptr field comes last in the field list (and in the v vector), yet it is
placed before the base.
Jason, can you please have a look?  Do you think this is the only problematic
case left?  Worst case we could fall through into a full blown vec qsort based
on field offsets.

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[freddie_chopin at op dot pl]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

Freddie Chopin <freddie_chopin at op dot pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |freddie_chopin at op dot pl

--- Comment #7 from Freddie Chopin <freddie_chopin at op dot pl> 2013-02-12 15:08:42 UTC ---
I really don't understand why Paolo Carlini is constantly removing me from the
CC list...

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[jakub at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> 2013-02-12 15:17:45 UTC ---
Perhaps because you are the reporter and reporter is always CCed on the PRs, no
matter if on CC or not?

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[freddie_chopin at op dot pl]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

--- Comment #9 from Freddie Chopin <freddie_chopin at op dot pl> 2013-02-12 15:31:46 UTC ---
(In reply to comment #8)
> Perhaps because you are the reporter and reporter is always CCed on the PRs, no
> matter if on CC or not?

If you remove me from the CC list I won't receive the comments that appear
here, and I don't mind reading them. If my mailbox gets spammed with messages
from bugzilla I'll remove myself, so no worries (;

Thx in advance for NOT-removing me again.

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|freddie_chopin at op dot pl |

--- Comment #10 from Paolo Carlini <paolo.carlini at oracle dot com> 2013-02-12 15:51:07 UTC ---
Because you are *already* CC-ed as submitter.

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|unassigned at gcc dot       |jason at gcc dot gnu.org
                   |gnu.org                     |

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

--- Comment #11 from Jason Merrill <jason at gcc dot gnu.org> 2013-02-12 17:37:10 UTC ---
Author: jason
Date: Tue Feb 12 17:36:58 2013
New Revision: 195986

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195986
Log:
    PR c++/56291
    * semantics.c (sort_constexpr_mem_initializers): Handle
    vptr out of order.

Added:
    trunk/gcc/testsuite/g++.dg/cpp0x/constexpr-virtual4.C
Modified:
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/semantics.c

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

--- Comment #12 from Jason Merrill <jason at gcc dot gnu.org> 2013-02-12 17:40:38 UTC ---
Author: jason
Date: Tue Feb 12 17:40:32 2013
New Revision: 195987

URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=195987
Log:
    PR c++/56291
    * semantics.c (sort_constexpr_mem_initializers): Handle
    vptr out of order.

Added:
    branches/gcc-4_7-branch/gcc/testsuite/g++.dg/cpp0x/constexpr-virtual4.C
Modified:
    branches/gcc-4_7-branch/gcc/cp/ChangeLog
    branches/gcc-4_7-branch/gcc/cp/semantics.c

[Bug c++/56291] [4.6/4.7/4.8 Regression] ICE for C++11 in output_constructor_regular_field, at varasm.c:4821

[jason at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56291

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|4.6.4                       |4.7.3

--- Comment #13 from Jason Merrill <jason at gcc dot gnu.org> 2013-02-12 17:41:44 UTC ---
Fixed for 4.7.3.  Not backporting C++11 fixes to 4.6.