[Bug target/56361] New: assertion failure passing structs w/o fields by value on sparc64

[Bug target/56361] New: assertion failure passing structs w/o fields by value on sparc64

[jay.krell at cornell dot edu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56361

             Bug #: 56361
           Summary: assertion failure passing structs w/o fields by value
                    on sparc64
    Classification: Unclassified
           Product: gcc
           Version: 4.7.2
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: jay.krell@cornell.edu


We have a strange front end.
It declares structs with size but no fields.
It actually works..except sometimes for SPARC64.


We have a function that passes a few structs by value.
They are 12 bytes each.



4.7.2/config/sparc/sparc.c:
static rtx
function_arg_record_value (const_tree type, enum machine_mode mode,
               int slotno, int named, int regbase)
.
.
.

      else
    {
      /* ??? C++ has structures with no fields, and yet a size.  Give up
         for now and pass everything back in integer registers.  */
      nregs = (typesize + UNITS_PER_WORD - 1) / UNITS_PER_WORD;
    }
      if (nregs + slotno > SPARC_INT_ARG_MAX)
    nregs = SPARC_INT_ARG_MAX - slotno;
    }
  gcc_assert (nregs != 0);



SPARC_INT_ARG_MAX == 6
nregs = 2
slotno = 6
so then nregs = 0
and the assert fails


I think it should say:
  gcc_assert (nregs != 0 || parms.stack);

[Bug target/56361] assertion failure passing structs w/o fields by value on sparc64

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56361

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |WAITING
   Last reconfirmed|                            |2013-02-20
                 CC|                            |ebotcazou at gcc dot
                   |                            |gnu.org
     Ever Confirmed|0                           |1

--- Comment #1 from Eric Botcazou <ebotcazou at gcc dot gnu.org> 2013-02-20 18:57:04 UTC ---
That could make sense if you confirm that the generated code runs correctly
once the assertion is relaxed.

[Bug target/56361] assertion failure passing structs w/o fields by value on sparc64

[ebotcazou at gcc dot gnu.org]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56361

Eric Botcazou <ebotcazou at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|WAITING                     |RESOLVED
         Resolution|---                         |WONTFIX

--- Comment #2 from Eric Botcazou <ebotcazou at gcc dot gnu.org> ---
No feedback.