[Bug target/56406] New: attribute((target(xpto))) causes ICE in i386 and rs6000

[Bug target/56406] New: attribute((target(xpto))) causes ICE in i386 and rs6000

[paulo@matos-sorge.com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56406

             Bug #: 56406
           Summary: attribute((target(xpto))) causes ICE in i386 and
                    rs6000
    Classification: Unclassified
           Product: gcc
           Version: 4.7.3
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: paulo@matos-sorge.com


While doing some tests I came across this ICE:
int __attribute__((__target__(xpto)))
foo(int x)
{
  if (x == 1)
    return x;
  else
    return x * foo (x-1);
}


If any word instead  of xpto works. The compiler fails with:
internal compiler error: in ix86_valid_target_attribute_inner_p, at
config/i386/i386.c:4214


This is because it's expecting either a STRING_CST ("xpto") or a TREE_CHAIN. If
an identifier node is seen instead we hit a gcc_unreachable. The other backend
that should be affected by this (but I didn't reproduce it) is rs6000.

[Bug target/56406] attribute((target(xpto))) causes ICE in i386 and rs6000

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56406

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
   Target Milestone|---                         |7.0
         Depends on|                            |79906, 55742
      Known to work|                            |4.8.1
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
rs6000 version was PR 79906.
x86 was fixed with PR 55742.

So all fixed.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55742
[Bug 55742] [4.8 regression] __attribute__ in class function declaration cause
"prototype does not match" errors.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79906
[Bug 79906] ICE in rs6000_inner_target_options, at config/rs6000/rs6000.c:39199