[Bug libstdc++/56430] New: In __airy: return-statement with a value, in function returning 'void'.

[Bug libstdc++/56430] New: In __airy: return-statement with a value, in function returning 'void'.

[3dw4rd at verizon dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56430

             Bug #: 56430
           Summary: In __airy: return-statement with a value, in function
                    returning 'void'.
    Classification: Unclassified
           Product: gcc
           Version: 4.8.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
        AssignedTo: unassigned@gcc.gnu.org
        ReportedBy: 3dw4rd@verizon.net


Created attachment 29525
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29525
Patch removing return of number from void function (returning from other
functions).

In __airy, an internal implementation function inside
include/tr1/modified_bessel_func.tcc, there was a return of a number from a
void function.

This function was not used obviously - it was intended for a future extension
that is slated for 4.9.  It seems sensible to me however to fix the bug.  This
function is being used in new development.  There's no reason to let it lie and
there is little risk in fixing it.

Testing the attached patch on x86_64-linux.

[Bug libstdc++/56430] In __airy: return-statement with a value, in function returning 'void'.

[3dw4rd at verizon dot net]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56430

--- Comment #1 from Ed Smith-Rowland <3dw4rd at verizon dot net> 2013-02-22 22:33:37 UTC ---
Created attachment 29526
  --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=29526
Patch with better test case.

Added checks for new template functions.

[Bug libstdc++/56430] In __airy: return-statement with a value, in function returning 'void'.

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56430

--- Comment #2 from Paolo Carlini <paolo.carlini at oracle dot com> 2013-02-22 23:23:16 UTC ---
Normally we don't keep around functions like this. The issue is better resolved
by simply removing it, for 4.8.0 and a corresponding patch is preapproved. In
the future please don't open this kind of issue about internal details, just
send a patch to the mailing list, thanks in advance.

[Bug libstdc++/56430] In __airy: return-statement with a value, in function returning 'void'.

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56430

--- Comment #3 from Paolo Carlini <paolo.carlini at oracle dot com> ---
What happened to this issue?

[Bug libstdc++/56430] In __airy: return-statement with a value, in function returning 'void'.

[paolo.carlini at oracle dot com]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56430

Paolo Carlini <paolo.carlini at oracle dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |4.9.0

--- Comment #4 from Paolo Carlini <paolo.carlini at oracle dot com> ---
Fixed for 4.9.0.