public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/56444] New: mn10300.c:3228:16: error: unused variable ‘loops’
@ 2013-02-25 14:57 amylaar at gcc dot gnu.org
2013-02-25 16:29 ` [Bug target/56444] " law at redhat dot com
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: amylaar at gcc dot gnu.org @ 2013-02-25 14:57 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56444
Bug #: 56444
Summary: mn10300.c:3228:16: error: unused variable ‘loops’
Classification: Unclassified
Product: gcc
Version: 4.8.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: target
AssignedTo: unassigned@gcc.gnu.org
ReportedBy: amylaar@gcc.gnu.org
CC: aoliva@gcc.gnu.org, law@redhat.com
Blocks: 44756
Target: am33_2.0-linux, mn10300-elf
../../../gcc/gcc/config/mn10300/mn10300.c: In function ‘void
mn10300_scan_for_setlb_lcc()’:
../../../gcc/gcc/config/mn10300/mn10300.c:3228:16: error: unused variable
‘loops’ [-Werror=unused-variable]
struct loops loops;
^
cc1plus: all warnings being treated as errors
make[2]: *** [mn10300.o] Error 1
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/56444] mn10300.c:3228:16: error: unused variable ‘loops’
2013-02-25 14:57 [Bug target/56444] New: mn10300.c:3228:16: error: unused variable ‘loops’ amylaar at gcc dot gnu.org
@ 2013-02-25 16:29 ` law at redhat dot com
2013-02-25 17:59 ` amylaar at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: law at redhat dot com @ 2013-02-25 16:29 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56444
--- Comment #1 from Jeffrey A. Law <law at redhat dot com> 2013-02-25 16:29:13 UTC ---
This makes no sense:
static void
mn10300_scan_for_setlb_lcc (void)
{
struct loops loops;
loop_iterator liter;
loop_p loop;
DUMP ("Looking for loops that can use the SETLB insn", NULL_RTX);
df_analyze ();
compute_bb_for_insn ();
/* Find the loops. */
if (flow_loops_find (& loops) < 1)
DUMP ("No loops found", NULL_RTX);
current_loops = & loops;
Note the uses of "loops".
Joern, I think you need to look at this a little deeper to see what's really
happening.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/56444] mn10300.c:3228:16: error: unused variable ‘loops’
2013-02-25 14:57 [Bug target/56444] New: mn10300.c:3228:16: error: unused variable ‘loops’ amylaar at gcc dot gnu.org
2013-02-25 16:29 ` [Bug target/56444] " law at redhat dot com
@ 2013-02-25 17:59 ` amylaar at gcc dot gnu.org
2013-02-25 18:40 ` law at redhat dot com
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: amylaar at gcc dot gnu.org @ 2013-02-25 17:59 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56444
Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rguenther at suse dot de
--- Comment #2 from Jorn Wolfgang Rennecke <amylaar at gcc dot gnu.org> 2013-02-25 17:58:55 UTC ---
(In reply to comment #1)
> /* Find the loops. */
> if (flow_loops_find (& loops) < 1)
> DUMP ("No loops found", NULL_RTX);
> current_loops = & loops;
>
> Note the uses of "loops".
That use has been removed recently:
r195998 | rguenth | 2013-02-13 09:38:09 +0000 (Wed, 13 Feb 2013) | 5 lines
2013-02-13 Richard Biener <rguenther@suse.de>
* config/mn10300/mn10300.c (mn10300_scan_for_setlb_lcc):
Fix loop discovery code.
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/56444] mn10300.c:3228:16: error: unused variable ‘loops’
2013-02-25 14:57 [Bug target/56444] New: mn10300.c:3228:16: error: unused variable ‘loops’ amylaar at gcc dot gnu.org
2013-02-25 16:29 ` [Bug target/56444] " law at redhat dot com
2013-02-25 17:59 ` amylaar at gcc dot gnu.org
@ 2013-02-25 18:40 ` law at redhat dot com
2013-02-26 10:49 ` rguenth at gcc dot gnu.org
2013-02-26 10:50 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: law at redhat dot com @ 2013-02-25 18:40 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56444
--- Comment #3 from Jeffrey A. Law <law at redhat dot com> 2013-02-25 18:40:01 UTC ---
In that case, fix, post & commit as obvious.
jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/56444] mn10300.c:3228:16: error: unused variable ‘loops’
2013-02-25 14:57 [Bug target/56444] New: mn10300.c:3228:16: error: unused variable ‘loops’ amylaar at gcc dot gnu.org
` (2 preceding siblings ...)
2013-02-25 18:40 ` law at redhat dot com
@ 2013-02-26 10:49 ` rguenth at gcc dot gnu.org
2013-02-26 10:50 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-02-26 10:49 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56444
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> 2013-02-26 10:49:30 UTC ---
Author: rguenth
Date: Tue Feb 26 10:49:25 2013
New Revision: 196280
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=196280
Log:
2013-02-26 Richard Biener <rguenther@suse.de>
PR target/56444
* config/mn10300/mn10300.c (mn10300_scan_for_setlb_lcc): Remove
unused variable loops.
Modified:
trunk/gcc/ChangeLog
trunk/gcc/config/mn10300/mn10300.c
^ permalink raw reply [flat|nested] 6+ messages in thread* [Bug target/56444] mn10300.c:3228:16: error: unused variable ‘loops’
2013-02-25 14:57 [Bug target/56444] New: mn10300.c:3228:16: error: unused variable ‘loops’ amylaar at gcc dot gnu.org
` (3 preceding siblings ...)
2013-02-26 10:49 ` rguenth at gcc dot gnu.org
@ 2013-02-26 10:50 ` rguenth at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2013-02-26 10:50 UTC (permalink / raw)
To: gcc-bugs
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56444
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution| |FIXED
--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> 2013-02-26 10:49:40 UTC ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-02-26 10:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-02-25 14:57 [Bug target/56444] New: mn10300.c:3228:16: error: unused variable ‘loops’ amylaar at gcc dot gnu.org
2013-02-25 16:29 ` [Bug target/56444] " law at redhat dot com
2013-02-25 17:59 ` amylaar at gcc dot gnu.org
2013-02-25 18:40 ` law at redhat dot com
2013-02-26 10:49 ` rguenth at gcc dot gnu.org
2013-02-26 10:50 ` rguenth at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).