public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/56493] Performance regression in google dense hashmap
Date: Sat, 15 Jun 2013 07:12:00 -0000	[thread overview]
Message-ID: <bug-56493-4-yqhy2cFCYS@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-56493-4@http.gcc.gnu.org/bugzilla/>

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56493

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org,
                   |                            |ktietz at gcc dot gnu.org,
                   |                            |law at gcc dot gnu.org

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
The reduced testcase has been slowed down by r176072, aka PR45437.  If you want
to speed it up by source code changes, q += (unsigned int) f(i); would do
instead of q += f(i);, or you can do q = q + f(i);.
Before that bugfix, the C++ FE produced
(void) (q = (int) ((unsigned int) f (i) + (unsigned int) q))
which is generally wrong (say if q was addressable and f could modify it),
after it we generate
(void) (q = TARGET_EXPR <D.2078, f (i)>;, (int) ((long unsigned int) q +
D.2078);)
The question is why the narrowing of the operation (to be done on unsigned int
rather than long unsigned int) isn't performed here, that is something we do
right now solely in the FE.  There are PRs (PR45397 and PR47477) about lack of
type demotion (and promotion) on GIMPLE, but don't know what the current state
of that is.


  parent reply	other threads:[~2013-06-15  7:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01 13:10 [Bug c++/56493] New: " andrewjcg at gmail dot com
2013-03-01 13:12 ` [Bug c++/56493] " andrewjcg at gmail dot com
2013-03-01 13:13 ` andrewjcg at gmail dot com
2013-03-01 14:29 ` redi at gcc dot gnu.org
2013-03-01 22:09 ` andrewjcg at gmail dot com
2013-03-01 22:11 ` andrewjcg at gmail dot com
2013-03-02  0:57 ` redi at gcc dot gnu.org
2013-03-09  4:18 ` andrewjcg at gmail dot com
2013-03-09 10:57 ` redi at gcc dot gnu.org
2013-04-13  1:37 ` cberner at fb dot com
2013-04-13  1:44 ` andrewjcg at gmail dot com
2013-06-15  7:12 ` jakub at gcc dot gnu.org [this message]
2013-06-16  0:03 ` jim at meyering dot net
2013-06-16 10:25 ` jakub at gcc dot gnu.org
2014-12-03  9:40 ` ubizjak at gmail dot com
2014-12-03  9:56 ` [Bug c++/56493] [4.8/4.9/5 Regression] " jakub at gcc dot gnu.org
2014-12-03 10:13 ` rguenth at gcc dot gnu.org
2014-12-03 10:20 ` rguenth at gcc dot gnu.org
2014-12-03 10:21 ` rguenth at gcc dot gnu.org
2014-12-03 10:34 ` jakub at gcc dot gnu.org
2014-12-03 11:26 ` rguenth at gcc dot gnu.org
2014-12-04  9:47 ` jakub at gcc dot gnu.org
2014-12-04  9:48 ` jakub at gcc dot gnu.org
2014-12-04  9:49 ` jakub at gcc dot gnu.org
2014-12-10 12:34 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-56493-4-yqhy2cFCYS@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).