public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dominiq at lps dot ens.fr" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug fortran/56500] [OOP] "IMPLICIT CLASS(...)" wrongly rejected
Date: Sun, 17 Mar 2013 19:46:00 -0000 [thread overview]
Message-ID: <bug-56500-4-j5WTLQ9hV9@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-56500-4@http.gcc.gnu.org/bugzilla/>
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56500
--- Comment #5 from Dominique d'Humieres <dominiq at lps dot ens.fr> 2013-03-17 19:46:16 UTC ---
> The patches of comment 2 and comment 3 regtest cleanly.
With the patches applied to a clean revision 196754 I have lot of errors in my
tests and at least one failure for the test suite:
[macbook] f90/bug% /opt/gcc/gcc4.9p-196754p1/bin/gfortran
/opt/gcc/work/gcc/testsuite/gfortran.dg/array_constructor_42.f90
/opt/gcc/work/gcc/testsuite/gfortran.dg/array_constructor_42.f90:13.21:
intrinsic :: real
1
Error: Symbol 'real' at (1) has no IMPLICIT type
/opt/gcc/work/gcc/testsuite/gfortran.dg/array_constructor_42.f90:20.21:
intrinsic :: real
1
Error: Symbol 'real' at (1) has no IMPLICIT type
The patch I have is
diff -up ../_clean/gcc/fortran/decl.c ../p_work/gcc/fortran/decl.c
--- ../_clean/gcc/fortran/decl.c 2013-02-02 11:15:07.000000000 +0100
+++ ../p_work/gcc/fortran/decl.c 2013-03-17 18:43:50.000000000 +0100
@@ -6293,6 +6293,13 @@ attr_decl1 (void)
}
}
+ if (sym->ts.type == BT_UNKNOWN
+ && gfc_set_default_type (sym, 1, NULL) == FAILURE)
+ {
+ m = MATCH_ERROR;
+ goto cleanup;
+ }
+
/* Update symbol table. DIMENSION attribute is set in
gfc_set_array_spec(). For CLASS variables, this must be applied
to the first component, or '_data' field. */
diff -up ../_clean/gcc/fortran/resolve.c ../p_work/gcc/fortran/resolve.c
--- ../_clean/gcc/fortran/resolve.c 2013-03-10 14:25:57.000000000 +0100
+++ ../p_work/gcc/fortran/resolve.c 2013-03-17 18:43:50.000000000 +0100
@@ -318,7 +318,13 @@ resolve_formal_arglist (gfc_symbol *proc
{
if (sym->ts.type == BT_UNKNOWN && !proc->attr.intrinsic
&& (!sym->attr.function || sym->result == sym))
- gfc_set_default_type (sym, 1, sym->ns);
+ {
+ gfc_set_default_type (sym, 1, sym->ns);
+ if (sym->ts.type == BT_CLASS
+ && gfc_build_class_symbol (&sym->ts, &sym->attr,
+ &sym->as, false) == FAILURE)
+ continue;
+ }
}
as = sym->ts.type == BT_CLASS && sym->attr.class_ok
(the patch in comment #3 is rejected and I have applied it manually, may be I
made a mistake I cannot spot).
next prev parent reply other threads:[~2013-03-17 19:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 18:07 [Bug fortran/56500] New: " burnus at gcc dot gnu.org
2013-03-02 0:07 ` [Bug fortran/56500] " burnus at gcc dot gnu.org
2013-03-17 12:55 ` janus at gcc dot gnu.org
2013-03-17 13:12 ` janus at gcc dot gnu.org
2013-03-17 16:00 ` janus at gcc dot gnu.org
2013-03-17 19:46 ` dominiq at lps dot ens.fr [this message]
2013-03-17 21:02 ` janus at gcc dot gnu.org
2013-03-17 21:30 ` dominiq at lps dot ens.fr
2013-03-17 22:38 ` janus at gcc dot gnu.org
2013-03-18 12:17 ` dominiq at lps dot ens.fr
2013-03-18 12:57 ` janus at gcc dot gnu.org
2013-04-01 15:34 ` janus at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-56500-4-j5WTLQ9hV9@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).